New issue
Advanced search Search tips

Issue 624450 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Convert "ios_packed_resources" gyp target to gn

Project Member Reported by eugene...@chromium.org, Jun 29 2016

Issue description

App Version (from "Chrome Settings > About Chrome"): ToT

Steps to reproduce: 
1.) Generate ninja: "gn gen --args='target_os="ios"' out/Default-iphoneos"
2.) Build: "ninja -C out/Default-iphoneos ios_chrome_unittests"
3.) List bundle content: "out/Default-iphoneos/ios_chrome_unittests.app"

Observed behavior: 
pak files are not in the bundle

Expected behavior: 
pak files should be in the bundle (they are present with gyp builds)

 
Status: WontFix (was: Assigned)
Given that the unit tests pass with gn I think they are not required in the application bundle. And if they are not required, then it is not a problem if they are not present. Marking as WontFix.
Status: Assigned (was: WontFix)
This is a problem for a unit test I'm currently writing:
https://codereview.chromium.org/2108783005/patch/20001/30001

I'm going to land this test for GYP only for now, but we actually need it for GN as well.
Cc: rohitrao@chromium.org
The bug description is incorrect. This is a new .pem file, and I answered in the description how to fix this. I object with landing this CL with gn not working.

AFAICT, the fix should be simple, and the .pem file were not packed with gyp either (your CL add them to the action that copy the resources in the bundle).
Cc: sdefresne@chromium.org
Owner: eugene...@chromium.org
Summary: ios_chrome_unittests use different location for ok_cert.pem with gyp and gn (was: ios_chrome_unittests does not contain *.pak resources if built with GN)
BTW, with ToT, the files are present in ios_chrome_unittests.app:

$ find out/gn-Debug-iphonesimulator/ios_chrome_unittests.app -name ok_cert.pem
out/gn-Debug-iphonesimulator/ios_chrome_unittests.app/net/data/ssl/certificates/ok_cert.pem

It is just in a different location than with gyp (but correct according to the net team). So, it should be a matter of updating the gyp action to instead copy the files to net/data/ssl/certificates instead of ios/web/net/data/ssl/certificates.
Cc: -sdefresne@chromium.org
Owner: sdefresne@chromium.org
Summary: ios_chrome_unittests does not contain *.pak resources if built with GN (was: ios_chrome_unittests use different location for ok_cert.pem with gyp and gn)
>> The bug description is incorrect. 
The bug description was correct and I restored it back. pak files are missing only for gn and those are needed by test (SSL Interstitial load resources from pak files):
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/28485/steps/ios_chrome_unittests%20%28iPhone%205s%20iOS%209.0%29/logs/stdio

pem file was a separate case, for which I've chosen to ask a question rather than file a bug, so thank you for answering that question, now I see that pem files are copied, and I do not need to change anything.

>> I object with landing this CL with gn not working.
Sure, I did not get approval for this CL yet. That's the reason for filing this bug. :)

BTW, I do not think it is fair to block the whole refactoring, because bundle built with GN is not the same as bundle built with GYP. Having tests in GYP is better than having no tests. Functionality I'm refactoring did not have tests before, so I'm not removing any tests. Landing CL w/o GN test has a lot of benefits, which I believe overweight drawbacks. If GN fix is not complex then I can definitely hold on landing this.
I will try fixing this and will ask you questions if I have troubles. I have to learn how to use GN anyways :)
I take my words back, ios_packed_resources is a large target and it has not been ported to GN. Sylvain, please help :)
I can reverse your argument and say that breaking a target that currently run the same tests with both gyp and gn to run different tests depending on which build system is used is putting strain on the migration effort that is already lacking in resources.

This would not be constructive and I think it is best to work together to fix the issue. The reason I said that the description was incorrect was that in the pointed CL, you asked how to pack the net certificates files and thus I thought this was the problem you were encountering.

I'll try getting the 'ios_packed_resources' target to gn, thank you for noticing it was missing. I understand this is blocking you, so I'll prioritize this.

It would have been good to have the whole information in the original bug, including why it was a problem [i.e. new test added that need to load some resources] and what was the failure [i.e. the call stack added in comment #5], this would have helped me work on it instead of closing with WnF.
Summary: Convert "ios_packed_resources" gyp target to gn (was: ios_chrome_unittests does not contain *.pak resources if built with GN)
Status: Fixed (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f2aa8c246b42214a88c98333bc67f4701c05998d

commit f2aa8c246b42214a88c98333bc67f4701c05998d
Author: sdefresne <sdefresne@google.com>
Date: Thu Jun 30 17:28:37 2016

Status: Verified (was: Fixed)
Sorry for confusion and thank you for fixing this bug so quickly (it would take me forever to add ios_packed_resources target).



Sign in to add a comment