Convert "ios_packed_resources" gyp target to gn |
||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): ToT Steps to reproduce: 1.) Generate ninja: "gn gen --args='target_os="ios"' out/Default-iphoneos" 2.) Build: "ninja -C out/Default-iphoneos ios_chrome_unittests" 3.) List bundle content: "out/Default-iphoneos/ios_chrome_unittests.app" Observed behavior: pak files are not in the bundle Expected behavior: pak files should be in the bundle (they are present with gyp builds)
,
Jun 29 2016
This is a problem for a unit test I'm currently writing: https://codereview.chromium.org/2108783005/patch/20001/30001 I'm going to land this test for GYP only for now, but we actually need it for GN as well.
,
Jun 29 2016
The bug description is incorrect. This is a new .pem file, and I answered in the description how to fix this. I object with landing this CL with gn not working. AFAICT, the fix should be simple, and the .pem file were not packed with gyp either (your CL add them to the action that copy the resources in the bundle).
,
Jun 29 2016
BTW, with ToT, the files are present in ios_chrome_unittests.app: $ find out/gn-Debug-iphonesimulator/ios_chrome_unittests.app -name ok_cert.pem out/gn-Debug-iphonesimulator/ios_chrome_unittests.app/net/data/ssl/certificates/ok_cert.pem It is just in a different location than with gyp (but correct according to the net team). So, it should be a matter of updating the gyp action to instead copy the files to net/data/ssl/certificates instead of ios/web/net/data/ssl/certificates.
,
Jun 29 2016
>> The bug description is incorrect. The bug description was correct and I restored it back. pak files are missing only for gn and those are needed by test (SSL Interstitial load resources from pak files): https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/28485/steps/ios_chrome_unittests%20%28iPhone%205s%20iOS%209.0%29/logs/stdio pem file was a separate case, for which I've chosen to ask a question rather than file a bug, so thank you for answering that question, now I see that pem files are copied, and I do not need to change anything. >> I object with landing this CL with gn not working. Sure, I did not get approval for this CL yet. That's the reason for filing this bug. :)
,
Jun 29 2016
BTW, I do not think it is fair to block the whole refactoring, because bundle built with GN is not the same as bundle built with GYP. Having tests in GYP is better than having no tests. Functionality I'm refactoring did not have tests before, so I'm not removing any tests. Landing CL w/o GN test has a lot of benefits, which I believe overweight drawbacks. If GN fix is not complex then I can definitely hold on landing this.
,
Jun 29 2016
I will try fixing this and will ask you questions if I have troubles. I have to learn how to use GN anyways :)
,
Jun 29 2016
I take my words back, ios_packed_resources is a large target and it has not been ported to GN. Sylvain, please help :)
,
Jun 30 2016
I can reverse your argument and say that breaking a target that currently run the same tests with both gyp and gn to run different tests depending on which build system is used is putting strain on the migration effort that is already lacking in resources. This would not be constructive and I think it is best to work together to fix the issue. The reason I said that the description was incorrect was that in the pointed CL, you asked how to pack the net certificates files and thus I thought this was the problem you were encountering. I'll try getting the 'ios_packed_resources' target to gn, thank you for noticing it was missing. I understand this is blocking you, so I'll prioritize this. It would have been good to have the whole information in the original bug, including why it was a problem [i.e. new test added that need to load some resources] and what was the failure [i.e. the call stack added in comment #5], this would have helped me work on it instead of closing with WnF.
,
Jun 30 2016
,
Jun 30 2016
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81c9ff1602706f86f8304226d3c2ab85ebee115a commit 81c9ff1602706f86f8304226d3c2ab85ebee115a Author: sdefresne <sdefresne@chromium.org> Date: Thu Jun 30 13:00:24 2016 Convert "ios_packed_resources" gyp target to gn. This target was overlooked and will be used by refactoring of ios_chrome_unittests. BUG= 624450 Review-Url: https://codereview.chromium.org/2119433002 Cr-Commit-Position: refs/heads/master@{#403159} [modify] https://crrev.com/81c9ff1602706f86f8304226d3c2ab85ebee115a/ios/chrome/BUILD.gn [modify] https://crrev.com/81c9ff1602706f86f8304226d3c2ab85ebee115a/ios/chrome/app/resources/BUILD.gn [add] https://crrev.com/81c9ff1602706f86f8304226d3c2ab85ebee115a/ios/chrome/app/resources/ios_chrome_repack.gni [modify] https://crrev.com/81c9ff1602706f86f8304226d3c2ab85ebee115a/ios/chrome/ios_chrome_resources.gyp
,
Jun 30 2016
,
Jun 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f2aa8c246b42214a88c98333bc67f4701c05998d commit f2aa8c246b42214a88c98333bc67f4701c05998d Author: sdefresne <sdefresne@google.com> Date: Thu Jun 30 17:28:37 2016
,
Jun 30 2016
Sorry for confusion and thank you for fixing this bug so quickly (it would take me forever to add ios_packed_resources target). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sdefresne@chromium.org
, Jun 29 2016