New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624446 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit 16 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ArcAppModelBuilderTest.RequestShortcutIcons and RemoveAppCleanUpFolder flaky on Linux ChromiumOS Tests

Project Member Reported by glevin@chromium.org, Jun 29 2016

Issue description

The new ArcAppModelBuilderTest.RequestShortcutIcons unit test sometimes crashes on Linux ChromiumOS Tests.

In this instance, the test crashed four times, and failed:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/15693

In this instance, it crashed once, but was rerun and passed:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/15694/steps/unit_tests%20on%20Ubuntu-12.04/logs/stdio

Here's the stack trace:

ArcAppModelBuilderTest.RequestShortcutIcons (run #1):
[ RUN      ] ArcAppModelBuilderTest.RequestShortcutIcons
Received signal 11 SEGV_MAPERR 000000000000
#0 0x7f1e9048a2ce base::debug::StackTrace::StackTrace()
#1 0x7f1e90489e0f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f1e7c6d4cb0 <unknown>
#3 0x7f1e8bebede4 content::UtilityProcessHostImpl::GetRemoteInterfaces()
#4 0x00000684e6e0 ImageDecoder::StartBatchMode()
#5 0x00000684de95 ImageDecoder::DecodeImageInSandbox()
#6 0x000006852269 _ZNK4base8internal15RunnableAdapterIM12ImageDecoderFviRKNSt7__debug6vectorIhSaIhEEENS2_10ImageCodecEbEE3RunIRK13scoped_refptrIS2_EJRKiS8_RKS9_RKbEEEvOT_DpOT0_
#7 0x0000068520f6 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS0_15RunnableAdapterIM12ImageDecoderFviRKNSt7__debug6vectorIhSaIhEEENS5_10ImageCodecEbEEEJRK13scoped_refptrIS5_ERKiSB_RKSC_RKbEEEvOT_DpOT0_
#8 0x000006852066 _ZN4base8internal7InvokerINS0_9BindStateINS0_15RunnableAdapterIM12ImageDecoderFviRKNSt7__debug6vectorIhSaIhEEENS4_10ImageCodecEbEEEJPS4_RiS8_RSB_RbEEEFvvEE7RunImplIRKSE_RKSt5tupleIJ13scoped_refptrIS4_EiS8_SB_bEEJLm0ELm1ELm2ELm3ELm4EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#9 0x000006851bec _ZN4base8internal7InvokerINS0_9BindStateINS0_15RunnableAdapterIM12ImageDecoderFviRKNSt7__debug6vectorIhSaIhEEENS4_10ImageCodecEbEEEJPS4_RiS8_RSB_RbEEEFvvEE3RunEPNS0_13BindStateBaseE
#10 0x7f1e9046bfee base::Callback<>::Run()
#11 0x7f1e9048f5ae base::debug::TaskAnnotator::RunTask()
#12 0x7f1e90504ba1 base::MessageLoop::RunTask()
#13 0x7f1e90504e28 base::MessageLoop::DeferOrRunPendingTask()
#14 0x7f1e90505082 base::MessageLoop::DoWork()
#15 0x7f1e9051c35c base::MessagePumpLibevent::Run()
#16 0x7f1e9050461a base::MessageLoop::RunHandler()
#17 0x7f1e905a2514 base::RunLoop::Run()
#18 0x7f1e905a2749 base::RunLoop::RunUntilIdle()
#19 0x000001ff199a ArcAppModelBuilderTest_RequestShortcutIcons_Test::TestBody()
#20 0x00000190ca3a _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateENSt3tr15tupleIJEEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS9_KFS3_vEEES3_PT_T0_RKS6_
#21 0x0000063b3e4e testing::internal::HandleExceptionsInMethodIfSupported<>()
#22 0x0000063a9315 testing::Test::Run()
#23 0x0000063a9a38 testing::TestInfo::Run()
#24 0x0000063a9fda testing::TestCase::Run()
#25 0x0000063af32c testing::internal::UnitTestImpl::RunAllTests()
#26 0x000001d43d8a _ZN7testing8internal12InvokeHelperIbNSt3tr15tupleIJEEEE12InvokeMethodI25MockServiceProcessControlMS7_FbvEEEbPT_T0_RKS4_
#27 0x0000063b536e testing::internal::HandleExceptionsInMethodIfSupported<>()
#28 0x0000063aefcf testing::UnitTest::Run()
#29 0x000002029f21 RUN_ALL_TESTS()
#30 0x000002029072 base::TestSuite::Run()
#31 0x000006359ced content::UnitTestTestSuite::Run()
[etc]
 
Labels: -Pri-2 Pri-1
Prioritizing test flake fix.

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d3d53820d4fa0c06fe46ac4279e7f88992a5df

commit c8d3d53820d4fa0c06fe46ac4279e7f88992a5df
Author: brucedawson <brucedawson@chromium.org>
Date: Wed Jul 06 20:39:51 2016

Disable ArcAppModelBuilderTest.RequestShortcutIcons on ChromeOS

BUG= 624446 

Review-Url: https://codereview.chromium.org/2129743002
Cr-Commit-Position: refs/heads/master@{#403946}

[modify] https://crrev.com/c8d3d53820d4fa0c06fe46ac4279e7f88992a5df/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Cc: xiaoh...@chromium.org
 Issue 626108  has been merged into this issue.
Cc: ben@chromium.org
 Issue 625048  has been merged into this issue.
Summary: ArcAppModelBuilderTest.RequestShortcutIcons and RemoveAppCleanUpFolder flaky on Linux ChromiumOS Tests (was: ArcAppModelBuilderTest.RequestShortcutIcons is flaky on Linux ChromiumOS Tests)
ArcAppModelBuilderTest.RemoveAppCleanUpFolder has also been flaky, with a similar stack:

[ RUN      ] ArcAppModelBuilderTest.RemoveAppCleanUpFolder
Received signal 11 SEGV_MAPERR 000000000000
#0 0x0000054b19f7 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f2bb03f9cb0 <unknown>
#2 0x000002c4e15b content::UtilityProcessHostImpl::GetRemoteInterfaces()
#3 0x0000051aa66d ImageDecoder::StartBatchMode()
#4 0x0000051aa059 ImageDecoder::DecodeImageInSandbox()
#5 0x0000055249e6 base::debug::TaskAnnotator::RunTask()
#6 0x0000054c8e15 base::MessageLoop::RunTask()
#7 0x0000054c9108 base::MessageLoop::DeferOrRunPendingTask()
#8 0x0000054c944b base::MessageLoop::DoWork()
#9 0x0000054cb029 base::MessagePumpLibevent::Run()
#10 0x0000054e2dae base::RunLoop::Run()
#11 0x000001ccedfb ArcAppModelBuilderTest_RemoveAppCleanUpFolder_Test::TestBody()
#12 0x000004cbe247 testing::Test::Run()
#13 0x000004cbef03 testing::TestInfo::Run()
#14 0x000004cbf393 testing::TestCase::Run()
#15 0x000004cc6569 testing::internal::UnitTestImpl::RunAllTests()
#16 0x000004cc620e testing::UnitTest::Run()
#17 0x000001cdf806 base::TestSuite::Run()
#18 0x000001cebb44 base::LaunchUnitTests()
#19 0x000001cda8a6 main
#20 0x7f2babaa17ed __libc_start_main
#21 0x000000680821 <unknown>
  r8: 00007f2ba4ea5700  r9: 00007f2ba4ea5700 r10: 00007f2ba4ea59d0 r11: 0000000000000206
 r12: 00007fff47fba4f8 r13: 0000000002c4e190 r14: 00000000097a2e70 r15: 00000000097a2e08
  di: 0000000000000000  si: 0000000000000000  bp: 0000000000000000  bx: 00000000ee32b201
  dx: 00001a53ee2d9dc0  ax: 00001a53ee3dc100  cx: 0000000000000003  sp: 00007fff47fba4b8
  ip: 0000000002c4e15b efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
[7867/7867] ArcAppModelBuilderTest.RemoveAppCleanUpFolder (CRASHED)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4303e815b33c5d970e210ca9edd2b6bafedc8ad3

commit 4303e815b33c5d970e210ca9edd2b6bafedc8ad3
Author: lhchavez <lhchavez@chromium.org>
Date: Fri Jul 15 00:04:00 2016

Fix ArcAppModelBuilderTest

Several tests in this suite were flaky. This change:

* Sets up a real I/O thread for the ExtensionsService and
  sets the profile mapping in case the garbage collector
  kicks in.
* Does a better job of waiting for the icons to be loaded.
* Uniformly disables safe icon decoding since it introduces
  extra thread hops that are difficult to synchronize for.

BUG= 627853 
BUG= 624446 
TEST=./unit_tests --gtest-filter=ArcAppModelBuilderTest*
TEST=for each test:
     ./unit_tests --gtest-filter=${t} --single-process-tests

Review-Url: https://codereview.chromium.org/2150583002
Cr-Commit-Position: refs/heads/master@{#405643}

[modify] https://crrev.com/4303e815b33c5d970e210ca9edd2b6bafedc8ad3/chrome/browser/chromeos/profiles/profile_helper.h
[modify] https://crrev.com/4303e815b33c5d970e210ca9edd2b6bafedc8ad3/chrome/browser/ui/app_list/app_list_test_util.cc
[modify] https://crrev.com/4303e815b33c5d970e210ca9edd2b6bafedc8ad3/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/4303e815b33c5d970e210ca9edd2b6bafedc8ad3/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/4303e815b33c5d970e210ca9edd2b6bafedc8ad3/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Owner: lhchavez@chromium.org
Status: Fixed (was: Assigned)
Labels: VerifyIn-54
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment