checkdeps is broken on windows |
|||
Issue description
It gives a ton of errors (i.e. all of includes in webkit and other directories). sample error:
ERROR in D:\src\chrome2\src\third_party\libwebp\utils\rescaler.h
Illegal include: "third_party\libwebp\webp\types.h"
Because of no rule applying.
Looking at recent changes to checkdeps, I only find:
https://codereview.chromium.org/1954943003
https://codereview.chromium.org/1975793002
We need to fix checkdeps on Windows so it passes.
And since it regressed, we need to run it on a waterfall bot. We have not run it on non-linux trybots for a long time because it's slow. For the last few years, we haven't had OS specific breakage. I think that points to platform specific breakages being very rare, so no need to slow down all tryruns for this and just putting it on a waterfall builder that's not mirrored to trybots is fine (Win x64 on chromnium?).
,
Jun 29 2016
Ok I tracked this down to the os.path.normpath additions which changed from forward slashes to backward slashes.
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fdab8abba2415d4bd126d8a66da107b2485d2c9 commit 7fdab8abba2415d4bd126d8a66da107b2485d2c9 Author: jam <jam@chromium.org> Date: Thu Jun 30 19:12:36 2016 Roll buildtools to fix checkdeps on Windows. BUG= 624445 Review-Url: https://codereview.chromium.org/2105263003 Cr-Commit-Position: refs/heads/master@{#403242} [modify] https://crrev.com/7fdab8abba2415d4bd126d8a66da107b2485d2c9/DEPS
,
Jul 12 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jam@chromium.org
, Jun 29 2016