New issue
Advanced search Search tips

Issue 624442 link

Starred by 1 user
Status: Fixed
Owner:
rajendrant@chromium.org
Closed: Jun 2016
Cc:
rajendrant@chromium.org
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

DataSaverWithServerBrowserTest.ReloadPage is flaky

Project Member Reported by tbansal@chromium.org, Jun 29 2016 
DataSaverWithServerBrowserTest.ReloadPage is flaky

An example trybot run: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/2102/steps/browser_tests%20on%20Windows-10-10586/logs/stdio

Quoting from petewil's email:
"Looking at the flakiness dashboard for this test (https://build.chromium.org/f/chromium/flakiness/, and use "DataSaverWithServerBrowserTest.ReloadPage" in the GTestFilter box), I see it has been failing off and on for awhile.  I see about 5 faliures over the past week, and more if I scroll back a ways."

Comment 1 by tbansal@chromium.org, Jun 29 2016 

Looking at the logs:
(1) There is a save-data header when it is not expected to be there.
(2) The browser is requesting favicons.

The favicon request can go to network after the page load has finished. So, it is possible that after the data saver is disabled, the pending favicon request from the previous page load goes out, and that can cause the test to fail.

One possible fix might be to check the save-data header only on requests whose url contains "google/google.html", instead of checking the save-data header on all requests.

Comment 2 by rajendrant@chromium.org, Jun 29 2016 

Thanks Tarun, that looks like a possible explanation.
Though EmbeddedTestServer returns 404 directly for the favicon request.
favicon request does not reach the request handler callback.
Maybe it reaches in some wierd cases.

I could not repro this with logs.

[5054:5111:0628/181154:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico
[5054:5111:0628/181154:WARNING:data_saver_browsertest.cc(74)] relative_url /google/google.html
[5054:5111:0628/181154:WARNING:data_saver_browsertest.cc(74)] relative_url /google/logo.gif
[5054:5111:0628/181154:WARNING:data_saver_browsertest.cc(74)] relative_url /google/x2.gif

I will fix it to not check save-data header for /favicon.ico
And see if the test is still flaky in the next few weeks.

Comment 3 by rajendrant@chromium.org, Jun 29 2016

Owner: rajendrant@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/954faf4ed3a27940a2433743917ed86a739026e8

commit 954faf4ed3a27940a2433743917ed86a739026e8
Author: rajendrant <rajendrant@chromium.org>
Date: Wed Jun 29 19:27:50 2016

Ignore favicon request in DataSaverWithServerBrowserTest.ReloadPage

Favicon request could be received for the previous page load when data
saver was enabled and could contain save-data header, while the test
expects no save-data header.

BUG= 624442 

Review-Url: https://codereview.chromium.org/2106213002
Cr-Commit-Position: refs/heads/master@{#402895}

[modify] https://crrev.com/954faf4ed3a27940a2433743917ed86a739026e8/chrome/browser/data_saver/data_saver_browsertest.cc

Comment 5 by rajendrant@chromium.org, Jun 29 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment