NTP Card heading display modifications |
|||||||
Issue descriptionModify the 'Articles for you' heading display. We have removed the snap to scroll behaviour so the heading only displays for a very short period of time as currently the display is when the first card is close to the top of the screen. The conclusion was to try display the heading at the same time as peeking the card which will cause the peek to be slowed down by half until the heading is displayed
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 4 2016
,
Jul 4 2016
Implementation videos: https://drive.google.com/open?id=0B1IgAIJ9cgizY3AwUGJfRC1RVWc
,
Jul 5 2016
LGTM, thanks Nicole!
,
Jul 5 2016
(Should I mark this as fixed? :) )
,
Jul 5 2016
,
Jul 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aeb3bf3e1304d72bc1ea65942d216555ad3dc13 commit 8aeb3bf3e1304d72bc1ea65942d216555ad3dc13 Author: mcwilliams <mcwilliams@chromium.org> Date: Tue Jul 05 18:18:12 2016 NTP, modify the snippet header display to above the peeking card Currently the NTP header displays when the first card reaches the top of the screen, this was good when we have snap scrolling which has now been removed. The heading height will now increase and show from under the peeking card at a percent of the scroll when the card is peeking, the card will peek at the balance of the scroll value until the header is at max height and normal scroll will resume. videos: https://drive.google.com/open?id=0B1IgAIJ9cgizY3AwUGJfRC1RVWc BUG= 624439 Review-Url: https://codereview.chromium.org/2120283003 Cr-Commit-Position: refs/heads/master@{#403802} [modify] https://crrev.com/8aeb3bf3e1304d72bc1ea65942d216555ad3dc13/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/8aeb3bf3e1304d72bc1ea65942d216555ad3dc13/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/8aeb3bf3e1304d72bc1ea65942d216555ad3dc13/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/8aeb3bf3e1304d72bc1ea65942d216555ad3dc13/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
,
Jul 6 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fi...@chromium.org
, Jul 1 2016