Issue metadata
Sign in to add a comment
|
Tracking bug for regressions caused by enabling Ignition on Svelte devices. |
||||||||||||||||||||||
Issue descriptionTracking bug for regressions caused by enabling Ignition on Svelte devices. These are expected, as we are explicitly trading off memory usage for JS throughput performance.
,
Jun 29 2016
We won't fix these for Svelte devices, since we are trading off memory usage for raw JS throughput benchmark performance.
,
Jun 29 2016
=== Auto-CCing suspected CL author rmcilroy@chromium.org === Hi rmcilroy@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [Gin] Enable V8 Ignition interpreter for low end Android devices. Author : rmcilroy Commit description: Enable V8 Ignition interpreter for Ignition on low-end (Svelte) devices. This is still controlled by a field-trial flag and so can be turned off in the field if necessary. Perf Sheriffs: This CL is likely to cause regressions on some benchmarks This is expected, as we are trading off memory usage for benchmark performance on low-memory devices, but please file bugs against me for tracking. BUG= v8:4280 ,v8:4868,594228 Review-Url: https://codereview.chromium.org/2101933003 Cr-Commit-Position: refs/heads/master@{#402472} Commit : f407ceccdc10ccd6e277fb72675fcf0be040cded Date : Tue Jun 28 15:12:32 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@402471 2172.8 26.659 5 good chromium@402472 5134.6 43.5465 5 bad <-- chromium@402473 5110.4 23.2013 5 bad chromium@402474 5116.6 24.7346 5 bad chromium@402477 5103.6 14.8762 5 bad chromium@402483 5094.2 15.8177 5 bad Bisect job ran on: android_one_perf_bisect Bug ID: 624411 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests sunspider Test Metric: Total/Total Relative Change: 134.45% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1378 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008513894422733824 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=6360401705435136 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 30 2016
,
Jul 1 2016
This is causing a timeouts on Kraken on A1 devices. Is the correct course of action disabling this on A1 devices?
,
Jul 1 2016
Ahh sorry about that. Yes we could either disable Kraken on A1 devices (I'm not sure how easy it is to disable a benchmark on a per-bot level) or increase the timeout a bit. Any thoughts on what's easiest?
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e996041c947c8c47bf932aba583b34a518e3cbc commit 2e996041c947c8c47bf932aba583b34a518e3cbc Author: rnephew <rnephew@chromium.org> Date: Fri Jul 01 21:05:02 2016 [Android] Disable Kraken test on Svelt devices. BUG= 624411 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2113033003 Cr-Commit-Position: refs/heads/master@{#403528} [modify] https://crrev.com/2e996041c947c8c47bf932aba583b34a518e3cbc/tools/perf/benchmarks/kraken.py
,
Dec 13 2017
,
Dec 13 2017
,
Dec 14 2017
,
Dec 14 2017
,
Dec 15 2017
It looks like Kraken is still disabled on svelte devices. We should probably re-enable now that we should be fast enough. I'll cook up a CL.
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05400aa561a0f4b314910fce0e62af1c1e76a35a commit 05400aa561a0f4b314910fce0e62af1c1e76a35a Author: Ross McIlroy <rmcilroy@chromium.org> Date: Mon Dec 18 14:36:29 2017 [Perf] Reenable Kraken on Svelte devices. BUG= chromium:624411 Change-Id: Icf3bdf7f004751639f86beb0eb03b2deab902c5d Reviewed-on: https://chromium-review.googlesource.com/829379 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524705} [modify] https://crrev.com/05400aa561a0f4b314910fce0e62af1c1e76a35a/tools/perf/benchmarks/kraken.py
,
Dec 18 2017
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5dd076fef8c38f4d32775878e5e7b7a97a818e4 commit a5dd076fef8c38f4d32775878e5e7b7a97a818e4 Author: Annie Sullivan <sullivan@chromium.org> Date: Wed Mar 28 22:33:27 2018 Re-enable kraken for Android One (mistaken disable). This was caught by a benchmark owner from the new weekly email. It looks like what happened is: 1. December 18, kraken was re-enabled in kraken.py 2. December 19, new expectations.config landed without merging the above enable. Bug: 624411 Change-Id: I7b3a8ea8043c837b0aa78361ff8ae75c1da519fe Reviewed-on: https://chromium-review.googlesource.com/984966 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#546627} [modify] https://crrev.com/a5dd076fef8c38f4d32775878e5e7b7a97a818e4/tools/perf/expectations.config |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmcilroy@chromium.org
, Jun 29 2016