Rampup time until 1M regressed with M50, proposed fix: https://codereview.webrtc.org/2061193002 Seems to reduce rampup time in dev: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=11a7d987ba13f9a71505ebad8e02d45b
Before we approve merge to M52, Could you please confirm whether this change is baked/verified in Canary and safe to merge? Also is this change applicable to all OS or any specific OS?
Been in trunk since: https://chromium.googlesource.com/chromium/src/+/913a1ada197598c05da66784500fce2ec5287ebb (Jun 20), I think it's currently running in dev.
All OS'es. :)
Your change meets the bar and is auto-approved for M52 (branch: 2743)
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/921d16afda7ee9ac2b2389b7c5e5aa909984f399 commit 921d16afda7ee9ac2b2389b7c5e5aa909984f399 Author: Peter Boström <pbos@webrtc.org> Date: Thu Jun 30 14:03:11 2016 Remove audio/video distinction for probe packets. Allows detecting large-enough audio packets as part of a probe, speculative fix for a rampup-time regression in M50. These packets are accounted on the send side when probing. BUG= webrtc:5985 R=philipel@webrtc.org, stefan@webrtc.org, mflodman@webrtc.org TBR=mflodman@webrtc.org Review URL: https://codereview.webrtc.org/2061193002 . Cr-Commit-Position: refs/heads/master@{#13210} (cherry picked from commit a7d88d38448f6a5677a017562765ab505b89d468) BUG= chromium:624374 Review URL: https://codereview.webrtc.org/2112643005 . Cr-Commit-Position: refs/branch-heads/52@{#9} Cr-Branched-From: a376e70cf9d0df3c35d53533b454da542661775b-refs/heads/master@{#12798} [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/audio/audio_receive_stream.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/audio/audio_receive_stream_unittest.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/congestion_controller/congestion_controller.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/include/send_time_history.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/send_time_history.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/test/packet.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp_play.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/modules/rtp_rtcp/source/rtp_sender.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/video/rtp_stream_receiver.cc [modify] https://crrev.com/921d16afda7ee9ac2b2389b7c5e5aa909984f399/webrtc/voice_engine/channel.cc
Comment 1 by gov...@chromium.org
, Jun 29 2016