New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624366 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Trace of cube is seen on ‘Cube 3D/click and drag to rotate’ experiment.

Project Member Reported by tkonch...@chromium.org, Jun 29 2016

Issue description

Chrome Version:53.0.2783.2 65c6178c55984c82fb8bebd4999395c4b364b621-refs/branch-heads/2783@{#3} (32/64 bit)
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac(10.10.5,10.11.4)

Test url:http://paulrhayes.com/experiments/cube-3d/touch.html

1.Launch chrome,navigate to above URL.
2.Click and drag the mouse from right-to-left/(up-to-down) direction then immediately change direction.
3.Observe.

Actual: Trace of cube is seen.
Expected: Trace of cube should not seen.

This regression issue broken in ‘M 53’ and below is narrow bisect:

https://chromium.googlesource.com/chromium/src/+log/8a208672ab14fa87cd1dd5ad6043a11c22e4d71e..d4cff44e1023869434c07689e29ee4440a3b7a2e?pretty=fuller&n=1000

Suspecting: r397201

Good build: 53.0.2753.0 
Bad build: 53.0.2754.0

Please re-assign if your change is not cause of this issue.

 
Please find the screencast
Actual1.mov
9.6 MB Download
Cc: rnimmagadda@chromium.org
Just to update.

Still able to repro this issue on Chrome Canary Version - 54.0.2787.0 
@jayadasika: Friendly Ping!


Cc: ranjitkan@chromium.org
Just to update, unable to reproduce the issue on MAC 10.11.5 (Retina), but still seeing it on Windows 7 and Ubuntu 14.04 on canary build 54.0.2799.0.

@jaydasika: Request you to please take a look into it. Issue is marked with a blocker label and M53 is going to be pushed to beta soon.

Thanks.!
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f03aa24a39fc23c5749b50966c8d1967063faa81

commit f03aa24a39fc23c5749b50966c8d1967063faa81
Author: jaydasika <jaydasika@chromium.org>
Date: Mon Jul 18 23:28:54 2016

cc: Clear entries from animations maps only when main thread wins

Because we will may need these values in future commits.

BUG= 624366 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105173006
Cr-Commit-Position: refs/heads/master@{#406131}

[modify] https://crrev.com/f03aa24a39fc23c5749b50966c8d1967063faa81/cc/layers/layer_impl.cc
[modify] https://crrev.com/f03aa24a39fc23c5749b50966c8d1967063faa81/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/f03aa24a39fc23c5749b50966c8d1967063faa81/cc/trees/layer_tree_impl.cc

Labels: Merge-Request-53

Comment 7 by dimu@google.com, Jul 20 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Unable to repro this issue on Windows 7 & Ubuntu Trusty for Google Chrome Canary Version - 54.0.2803.0 

On MAC (10.11.5) for Google Chrome Canary Version - 54.0.2802.2

Screen-recording is attached.

Thank you.
624366.mp4
960 KB View Download
Labels: TE-Verified-M54 TE-Verified-54.0.2803.0 TE-Verified-54.0.2802.2
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 21 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe476267130ef80014bebddba2cc929b7826080

commit ffe476267130ef80014bebddba2cc929b7826080
Author: Jayadev Dasika <jaydasika@google.com>
Date: Thu Jul 21 18:24:17 2016

cc: Clear entries from animations maps only when main thread wins

Because we will may need these values in future commits.

BUG= 624366 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105173006
Cr-Commit-Position: refs/heads/master@{#406131}
(cherry picked from commit f03aa24a39fc23c5749b50966c8d1967063faa81)

Review URL: https://codereview.chromium.org/2173483002 .

Cr-Commit-Position: refs/branch-heads/2785@{#269}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/ffe476267130ef80014bebddba2cc929b7826080/cc/layers/layer_impl.cc
[modify] https://crrev.com/ffe476267130ef80014bebddba2cc929b7826080/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/ffe476267130ef80014bebddba2cc929b7826080/cc/trees/layer_tree_impl.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-M53 TE-Verified-53.0.2785.30
Retested the above issue on All-OS(Win, Mac 10.11.5 & Ubuntu 14.04) with chrome version - 53.0.2785.30 and trace of cube not seen on moving the cube right-to-left/(up-to-down) direction and then immediately changing direction. 

Hence marking it as TE-Verified-53.0.2785.30.

Attach is the screen-recording.

Thank you!
retest-624366.ogv
3.5 MB View Download

Sign in to add a comment