Transition ios/web to ARC, particularly all files listed in following gn files: ./ios/web//app/BUILD.gn ./ios/web//BUILD.gn ./ios/web//public/app/BUILD.gn ./ios/web//shell/BUILD.gn ./ios/web//test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad commit eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad Author: stkhapugin <stkhapugin@chromium.org> Date: Tue Aug 23 13:17:11 2016 Converts top-level ios/web files, interstitials and navigation directories to ARC. Removes property_releaser usage. Includes results of ARCMigrate run. BUG= 624365 TEST=None Review-Url: https://codereview.chromium.org/2202623002 Cr-Commit-Position: refs/heads/master@{#413717} [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/BUILD.gn [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/active_state_manager_impl.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/alloc_with_zone_interceptor.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/browser_state.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/browser_url_rewriter_impl.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/interstitials/html_web_interstitial_impl.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/interstitials/native_web_interstitial_impl.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/interstitials/web_interstitial_impl.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/navigation/crw_session_certificate_policy_manager.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/navigation/crw_session_controller.h [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/navigation/crw_session_controller.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/navigation/crw_session_entry.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/navigation/navigation_item_impl.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/navigation/navigation_manager_impl.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/navigation/nscoder_util.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/url_scheme_util.mm [modify] https://crrev.com/eb706fb3fce4cb2ee01ba6725163ab6d52c0f0ad/ios/web/web_view_creation_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/752abca03af110f7641b17fc2153babc87a01ba9 commit 752abca03af110f7641b17fc2153babc87a01ba9 Author: stkhapugin <stkhapugin@chromium.org> Date: Thu Aug 25 13:26:09 2016 Converts ios/web/net to ARC. Converts files located in ios/web/net. Removes property_releaser usage. Includes results of ARCMigrate run. Replaces WeakNSObjects with __weak variables. Inserts compile guards. Additionaly, renames ivars from trailing underscore to leading. BUG= 624365 TEST=None Review-Url: https://codereview.chromium.org/2247303009 Cr-Commit-Position: refs/heads/master@{#414417} [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/BUILD.gn [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/clients/crw_js_injection_network_client.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/clients/crw_js_injection_network_client_factory.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/clients/crw_redirect_network_client.h [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/clients/crw_redirect_network_client.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/clients/crw_redirect_network_client_factory.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/cookie_notification_bridge.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/crw_cert_verification_controller.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/crw_ssl_status_updater.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/request_group_util.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/request_tracker_factory_impl.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/request_tracker_impl.mm [modify] https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9/ios/web/net/web_http_protocol_handler_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee84494fa63915bf539470d3d334649d8ef7cbc8 commit ee84494fa63915bf539470d3d334649d8ef7cbc8 Author: stkhapugin <stkhapugin@chromium.org> Date: Tue Oct 25 14:42:41 2016 [ObjC ARC] Converts ios/web/app to ARC Notable changes: none BUG= 624365 TEST=None Review-Url: https://codereview.chromium.org/2449903002 Cr-Commit-Position: refs/heads/master@{#427347} [modify] https://crrev.com/ee84494fa63915bf539470d3d334649d8ef7cbc8/ios/web/app/BUILD.gn [modify] https://crrev.com/ee84494fa63915bf539470d3d334649d8ef7cbc8/ios/web/app/web_main.mm [modify] https://crrev.com/ee84494fa63915bf539470d3d334649d8ef7cbc8/ios/web/app/web_main_loop.mm [modify] https://crrev.com/ee84494fa63915bf539470d3d334649d8ef7cbc8/ios/web/app/web_main_runner.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ced02a1df33b4862def20cf065624eb5cf3aa2 commit 73ced02a1df33b4862def20cf065624eb5cf3aa2 Author: stkhapugin <stkhapugin@chromium.org> Date: Tue Oct 25 14:41:42 2016 [ObjC ARC] Converts ios/web/public/app to ARC Notable changes: None BUG= 624365 TEST=None Review-Url: https://codereview.chromium.org/2446163003 Cr-Commit-Position: refs/heads/master@{#427346} [modify] https://crrev.com/73ced02a1df33b4862def20cf065624eb5cf3aa2/ios/web/public/app/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832 commit bd8522e26c5b1c19576d2cf0dbd9783f6cf76832 Author: stkhapugin <stkhapugin@chromium.org> Date: Wed Oct 26 17:29:35 2016 [ObjC ARC] Converts ios/web/shell/test to ARC. Notable changes:none BUG= 624365 Review-Url: https://codereview.chromium.org/2446893004 Cr-Commit-Position: refs/heads/master@{#427731} [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/BUILD.gn [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/app/navigation_test_util.mm [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/app/web_shell_test_util.mm [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/app/web_view_interaction_test_util.mm [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/earl_grey/shell_actions.mm [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/earl_grey/shell_base_test_case.mm [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/earl_grey/shell_earl_grey.mm [modify] https://crrev.com/bd8522e26c5b1c19576d2cf0dbd9783f6cf76832/ios/web/shell/test/earl_grey/shell_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b6f44b09855a803914efd9877fddb471a97cbf1 commit 9b6f44b09855a803914efd9877fddb471a97cbf1 Author: stkhapugin <stkhapugin@chromium.org> Date: Mon Nov 07 17:29:06 2016 [ObjC ARC] Converts crw_web_controller to ARC. Notable changes: * crw_web_controller.mm used to have a dictionary storing selectors just for keeping the KVO code clean. ARC cannot call a selector from a string like this, because it cannot guarantee correct memory management in this case. So it was replaced with an array of observed key paths to keep some of the code cleanness, while the KVO callback has a huge switch. BUG= 624365 TEST=None Review-Url: https://codereview.chromium.org/2434853002 Cr-Commit-Position: refs/heads/master@{#430304} [modify] https://crrev.com/9b6f44b09855a803914efd9877fddb471a97cbf1/ios/web/BUILD.gn [modify] https://crrev.com/9b6f44b09855a803914efd9877fddb471a97cbf1/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/9b6f44b09855a803914efd9877fddb471a97cbf1/ios/web/web_state/ui/crw_web_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85d802e4f2fc5ee1c7480f8f99e83455035f65c8 commit 85d802e4f2fc5ee1c7480f8f99e83455035f65c8 Author: baxley <baxley@chromium.org> Date: Tue Nov 08 00:36:22 2016 Revert of [ObjC ARC] Converts crw_web_controller to ARC. (patchset #8 id:140001 of https://codereview.chromium.org/2434853002/ ) Reason for revert: This caused multiple Chrome for iOS unit tests to fail when creating tabs. It resulted in tests crashing when checking if currently on the web thread. Original issue's description: > [ObjC ARC] Converts crw_web_controller to ARC. > > Notable changes: > * crw_web_controller.mm used to have a dictionary storing selectors just > for keeping the KVO code clean. ARC cannot call a selector from a string > like this, because it cannot guarantee correct memory management in > this case. So it was replaced with an array of observed key paths to > keep some of the code cleanness, while the KVO callback has a huge > switch. > > BUG= 624365 > TEST=None > > Committed: https://crrev.com/9b6f44b09855a803914efd9877fddb471a97cbf1 > Cr-Commit-Position: refs/heads/master@{#430304} TBR=sdefresne@chromium.org,eugenebut@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 624365 Review-Url: https://codereview.chromium.org/2482803003 Cr-Commit-Position: refs/heads/master@{#430443} [modify] https://crrev.com/85d802e4f2fc5ee1c7480f8f99e83455035f65c8/ios/web/BUILD.gn [modify] https://crrev.com/85d802e4f2fc5ee1c7480f8f99e83455035f65c8/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/85d802e4f2fc5ee1c7480f8f99e83455035f65c8/ios/web/web_state/ui/crw_web_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a701a189ea1d9778d2f7e6e7596a4cd22ca33b79 commit a701a189ea1d9778d2f7e6e7596a4cd22ca33b79 Author: stkhapugin <stkhapugin@chromium.org> Date: Mon Nov 21 14:59:21 2016 [ARC] Converts ios/web:user_agent to ARC. Notable changes: None BUG= 624365 TEST=None Review-Url: https://codereview.chromium.org/2497263002 Cr-Commit-Position: refs/heads/master@{#433543} [modify] https://crrev.com/a701a189ea1d9778d2f7e6e7596a4cd22ca33b79/ios/web/BUILD.gn [modify] https://crrev.com/a701a189ea1d9778d2f7e6e7596a4cd22ca33b79/ios/web/public/user_agent.mm
This is done, right?
Comment 1 by stkhapugin@chromium.org
, Jun 29 2016