Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 624363 Transition ios/ to ARC
Starred by 3 users Project Member Reported by stkhapugin@chromium.org, Jun 29 2016 Back to list
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocked on: View detail
issue 624365
issue 659147
issue 663723
issue 645125
issue 691068

Blocking:
issue 636372



Sign in to add a comment
Transition ios/ to use Objective-C Automatic Reference Counting.
 
Blockedon: 624365
Blocking: 636372
Blockedon: 645125
Blockedon: 659147
Blockedon: 663723
Project Member Comment 6 by bugdroid1@chromium.org, Nov 18 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1

commit dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Nov 18 18:25:47 2016

[ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2506153004
Cr-Commit-Position: refs/heads/master@{#433243}

[modify] https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1/ios/chrome/browser/prefs/pref_observer_bridge.mm

Project Member Comment 7 by bugdroid1@chromium.org, Nov 18 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5735d3c3b80eea8ba1e05f67fff0708cb672423d

commit 5735d3c3b80eea8ba1e05f67fff0708cb672423d
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Nov 18 18:44:11 2016

[ObjC ARC] Converts ios/chrome/browser/sync/sessions:sessions to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2517583002
Cr-Commit-Position: refs/heads/master@{#433252}

[modify] https://crrev.com/5735d3c3b80eea8ba1e05f67fff0708cb672423d/ios/chrome/browser/sync/sessions/BUILD.gn
[modify] https://crrev.com/5735d3c3b80eea8ba1e05f67fff0708cb672423d/ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm

Project Member Comment 8 by bugdroid1@chromium.org, Nov 18 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86f0d15d008ee8616bc96ad5274e6f43f39e6c18

commit 86f0d15d008ee8616bc96ad5274e6f43f39e6c18
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Nov 18 18:48:49 2016

[ObjC ARC] Converts ios/chrome/browser/google:google_logo to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2511043004
Cr-Commit-Position: refs/heads/master@{#433257}

[modify] https://crrev.com/86f0d15d008ee8616bc96ad5274e6f43f39e6c18/ios/chrome/browser/google/BUILD.gn
[modify] https://crrev.com/86f0d15d008ee8616bc96ad5274e6f43f39e6c18/ios/chrome/browser/google/google_logo_service.mm
[modify] https://crrev.com/86f0d15d008ee8616bc96ad5274e6f43f39e6c18/ios/chrome/browser/google/google_logo_service_factory.mm

Project Member Comment 9 by bugdroid1@chromium.org, Nov 19 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d818f8b62ef17511721b558228cff6a6e460d7f8

commit d818f8b62ef17511721b558228cff6a6e460d7f8
Author: michaeldo <michaeldo@chromium.org>
Date: Sat Nov 19 02:27:06 2016

Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ )

Reason for revert:
Breaks roll. Details sent via email.

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1
> Cr-Commit-Position: refs/heads/master@{#433243}

TBR=noyau@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2511883007
Cr-Commit-Position: refs/heads/master@{#433383}

[modify] https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8/ios/chrome/browser/prefs/pref_observer_bridge.mm

Project Member Comment 10 by bugdroid1@chromium.org, Nov 21 2016
Project Member Comment 12 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2746c677e15ba729068bcfeaaae2a280f7cc9d2

commit e2746c677e15ba729068bcfeaaae2a280f7cc9d2
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 13:26:26 2016

[ObjC ARC] Converts ios/chrome/test:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2508733007
Cr-Commit-Position: refs/heads/master@{#433521}

[modify] https://crrev.com/e2746c677e15ba729068bcfeaaae2a280f7cc9d2/ios/chrome/test/BUILD.gn
[modify] https://crrev.com/e2746c677e15ba729068bcfeaaae2a280f7cc9d2/ios/chrome/test/google_toolbox_unittest.mm

Project Member Comment 13 by bugdroid1@chromium.org, Nov 21 2016
Project Member Comment 14 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b707163072fb44b4486821de9b1ecf2a06278269

commit b707163072fb44b4486821de9b1ecf2a06278269
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 13:55:54 2016

[ObjC ARC] Converts ios/chrome/browser/ssl:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2514833002
Cr-Commit-Position: refs/heads/master@{#433527}

[modify] https://crrev.com/b707163072fb44b4486821de9b1ecf2a06278269/ios/chrome/browser/ssl/BUILD.gn
[modify] https://crrev.com/b707163072fb44b4486821de9b1ecf2a06278269/ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm

Project Member Comment 15 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf2457880cd0ce7bf7d58a5a8c8dd4c559dc521

commit cdf2457880cd0ce7bf7d58a5a8c8dd4c559dc521
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 14:14:12 2016

[ObjC ARC] Converts ios/chrome/common/app_group:app_group to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2513673003
Cr-Commit-Position: refs/heads/master@{#433530}

[modify] https://crrev.com/cdf2457880cd0ce7bf7d58a5a8c8dd4c559dc521/ios/chrome/common/app_group/BUILD.gn
[modify] https://crrev.com/cdf2457880cd0ce7bf7d58a5a8c8dd4c559dc521/ios/chrome/common/app_group/app_group_constants.mm
[modify] https://crrev.com/cdf2457880cd0ce7bf7d58a5a8c8dd4c559dc521/ios/chrome/common/app_group/app_group_metrics.mm

Project Member Comment 16 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c39ac38482e62040d3ad2f4678cafae8f56c4e2

commit 1c39ac38482e62040d3ad2f4678cafae8f56c4e2
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 14:17:46 2016

[ObjC ARC] Converts ios/chrome/browser/ui/webui:webui to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2518573002
Cr-Commit-Position: refs/heads/master@{#433533}

[modify] https://crrev.com/1c39ac38482e62040d3ad2f4678cafae8f56c4e2/ios/chrome/browser/ui/webui/BUILD.gn
[modify] https://crrev.com/1c39ac38482e62040d3ad2f4678cafae8f56c4e2/ios/chrome/browser/ui/webui/version_ui.mm

Project Member Comment 17 by bugdroid1@chromium.org, Nov 21 2016
Project Member Comment 18 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f955b4e2549239be02c262fba8f241664f399b

commit 02f955b4e2549239be02c262fba8f241664f399b
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 14:33:11 2016

[ObjC ARC] Converts ios/testing:ocmock_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2516673002
Cr-Commit-Position: refs/heads/master@{#433537}

[modify] https://crrev.com/02f955b4e2549239be02c262fba8f241664f399b/ios/testing/BUILD.gn
[modify] https://crrev.com/02f955b4e2549239be02c262fba8f241664f399b/ios/testing/ocmock_complex_type_helper.mm

Project Member Comment 20 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e364086a931229086302db18dc39a1a82358b533

commit e364086a931229086302db18dc39a1a82358b533
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 16:01:03 2016

[ObjC ARC] Converts ios/chrome/browser/ui/context_menu:context_menu to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2512003003
Cr-Commit-Position: refs/heads/master@{#433553}

[modify] https://crrev.com/e364086a931229086302db18dc39a1a82358b533/ios/chrome/browser/ui/context_menu/BUILD.gn
[modify] https://crrev.com/e364086a931229086302db18dc39a1a82358b533/ios/chrome/browser/ui/context_menu/context_menu_coordinator.mm

Project Member Comment 21 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2dd94492b98952e219b65246958e87c15c5304b

commit a2dd94492b98952e219b65246958e87c15c5304b
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 16:21:23 2016

[ObjC ARC] Converts ios/chrome/browser/passwords:passwords_generation_utils to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2512983002
Cr-Commit-Position: refs/heads/master@{#433557}

[modify] https://crrev.com/a2dd94492b98952e219b65246958e87c15c5304b/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/a2dd94492b98952e219b65246958e87c15c5304b/ios/chrome/browser/passwords/password_generation_utils.mm

Project Member Comment 22 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b558d73a06d3e2cdd8ec4352b6fe08749af4b3

commit 07b558d73a06d3e2cdd8ec4352b6fe08749af4b3
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 16:34:56 2016

[ObjC ARC] Converts ios/chrome/common/app_group:client to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2513013002
Cr-Commit-Position: refs/heads/master@{#433559}

[modify] https://crrev.com/07b558d73a06d3e2cdd8ec4352b6fe08749af4b3/ios/chrome/common/app_group/BUILD.gn
[modify] https://crrev.com/07b558d73a06d3e2cdd8ec4352b6fe08749af4b3/ios/chrome/common/app_group/app_group_metrics_client.mm

Project Member Comment 23 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb695127d97eb9847ef9c06e92de7e8c662224f7

commit eb695127d97eb9847ef9c06e92de7e8c662224f7
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 16:35:58 2016

[ObjC ARC] Converts ios/chrome/browser/suggestions:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2512793004
Cr-Commit-Position: refs/heads/master@{#433560}

[modify] https://crrev.com/eb695127d97eb9847ef9c06e92de7e8c662224f7/ios/chrome/browser/suggestions/BUILD.gn
[modify] https://crrev.com/eb695127d97eb9847ef9c06e92de7e8c662224f7/ios/chrome/browser/suggestions/ios_image_decoder_impl_unittest.mm

Project Member Comment 25 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0640337e8f5b67e940390fcb6b4efc846afdc9a7

commit 0640337e8f5b67e940390fcb6b4efc846afdc9a7
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 16:48:56 2016

[ObjC ARC] Converts ios/chrome/browser:about_flags to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2517623002
Cr-Commit-Position: refs/heads/master@{#433566}

[modify] https://crrev.com/0640337e8f5b67e940390fcb6b4efc846afdc9a7/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/0640337e8f5b67e940390fcb6b4efc846afdc9a7/ios/chrome/browser/about_flags.mm

Project Member Comment 27 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b14005ec88afb781002383f3ae413e91d4a3fd54

commit b14005ec88afb781002383f3ae413e91d4a3fd54
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 16:57:25 2016

[ObjC ARC] Converts ios/chrome/browser:browser_impl to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2512193002
Cr-Commit-Position: refs/heads/master@{#433570}

[modify] https://crrev.com/b14005ec88afb781002383f3ae413e91d4a3fd54/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/b14005ec88afb781002383f3ae413e91d4a3fd54/ios/chrome/browser/ios_chrome_main_parts.mm

Project Member Comment 28 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad6d05ff7d988491befdf74a448598d35af54121

commit ad6d05ff7d988491befdf74a448598d35af54121
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 17:08:49 2016

[ObjC ARC] Converts ios/chrome/browser/webp_transcode:webp_transcode to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2515743002
Cr-Commit-Position: refs/heads/master@{#433572}

[modify] https://crrev.com/ad6d05ff7d988491befdf74a448598d35af54121/ios/chrome/browser/webp_transcode/BUILD.gn
[modify] https://crrev.com/ad6d05ff7d988491befdf74a448598d35af54121/ios/chrome/browser/webp_transcode/webp_decoder.mm

Project Member Comment 29 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f64ce26c730b77a01a5569184b71ff0ad0aa87f

commit 0f64ce26c730b77a01a5569184b71ff0ad0aa87f
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 17:30:51 2016

[ObjC ARC] Converts ios/chrome/browser/google:google to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2516633002
Cr-Commit-Position: refs/heads/master@{#433577}

[modify] https://crrev.com/0f64ce26c730b77a01a5569184b71ff0ad0aa87f/ios/chrome/browser/google/BUILD.gn
[modify] https://crrev.com/0f64ce26c730b77a01a5569184b71ff0ad0aa87f/ios/chrome/browser/google/google_brand.mm

Project Member Comment 30 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4975b5100ec05385ad9ffadbada0d84aa73d4142

commit 4975b5100ec05385ad9ffadbada0d84aa73d4142
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 17:39:38 2016

[ObjC ARC] Converts ios/chrome/browser/webp_transcode:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2515733002
Cr-Commit-Position: refs/heads/master@{#433579}

[modify] https://crrev.com/4975b5100ec05385ad9ffadbada0d84aa73d4142/ios/chrome/browser/webp_transcode/BUILD.gn
[modify] https://crrev.com/4975b5100ec05385ad9ffadbada0d84aa73d4142/ios/chrome/browser/webp_transcode/webp_decoder_unittest.mm

Project Member Comment 31 by bugdroid1@chromium.org, Nov 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa95b671739c02859d8e6f8a6e274d90e3d3f3a9

commit fa95b671739c02859d8e6f8a6e274d90e3d3f3a9
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Nov 21 18:15:46 2016

[ObjC ARC] Converts ios/public/provider/web:web to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2519483002
Cr-Commit-Position: refs/heads/master@{#433587}

[modify] https://crrev.com/fa95b671739c02859d8e6f8a6e274d90e3d3f3a9/ios/public/provider/web/BUILD.gn
[modify] https://crrev.com/fa95b671739c02859d8e6f8a6e274d90e3d3f3a9/ios/public/provider/web/web_controller_provider.mm

Project Member Comment 33 by bugdroid1@chromium.org, Nov 22 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bbdb78cb38b2b39e2adba32fee547680a64d594

commit 4bbdb78cb38b2b39e2adba32fee547680a64d594
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Nov 22 00:05:34 2016

[ObjC ARC] Converts ios/chrome/browser/ui/webui/history:history to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2519453002
Cr-Commit-Position: refs/heads/master@{#433708}

[modify] https://crrev.com/4bbdb78cb38b2b39e2adba32fee547680a64d594/ios/chrome/browser/ui/webui/history/BUILD.gn
[modify] https://crrev.com/4bbdb78cb38b2b39e2adba32fee547680a64d594/ios/chrome/browser/ui/webui/history/history_ui.mm

Project Member Comment 36 by bugdroid1@chromium.org, Nov 22 2016
Project Member Comment 37 by bugdroid1@chromium.org, Nov 22 2016
Project Member Comment 38 by bugdroid1@chromium.org, Nov 24 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2

commit 0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Nov 24 18:46:43 2016

[ObjC ARC] Converts ios/chrome/browser/net:net to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2516653002
Cr-Commit-Position: refs/heads/master@{#434369}

[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/BUILD.gn
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/chrome_cookie_store_ios_client.mm
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/connection_type_observer_bridge.mm
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/image_fetcher.mm
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/ios_chrome_http_user_agent_settings.mm
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/metrics_network_client.mm
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/metrics_network_client_manager.mm
[modify] https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2/ios/chrome/browser/net/retryable_url_fetcher.mm

Project Member Comment 39 by bugdroid1@chromium.org, Nov 24 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7ecc87fb1c5b2ce43ba29418298f34653585908

commit b7ecc87fb1c5b2ce43ba29418298f34653585908
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Nov 24 18:56:57 2016

[ObjC ARC] Converts ios/chrome/browser/reading_list:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2511993003
Cr-Commit-Position: refs/heads/master@{#434373}

[modify] https://crrev.com/b7ecc87fb1c5b2ce43ba29418298f34653585908/ios/chrome/browser/reading_list/BUILD.gn

Project Member Comment 41 by bugdroid1@chromium.org, Nov 30 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa554a4b832c0d1b826da1fca37c7dec2c20cce0

commit fa554a4b832c0d1b826da1fca37c7dec2c20cce0
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Nov 30 13:31:00 2016

[ObjC ARC] Converts ios/testing/earl_grey:earl_grey_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2508973007
Cr-Commit-Position: refs/heads/master@{#435241}

[modify] https://crrev.com/fa554a4b832c0d1b826da1fca37c7dec2c20cce0/ios/testing/earl_grey/BUILD.gn
[modify] https://crrev.com/fa554a4b832c0d1b826da1fca37c7dec2c20cce0/ios/testing/earl_grey/matchers.mm

Project Member Comment 42 by bugdroid1@chromium.org, Nov 30 2016
Project Member Comment 43 by bugdroid1@chromium.org, Nov 30 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b88732e627633f1843665e3d532275aa79db3756

commit b88732e627633f1843665e3d532275aa79db3756
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Nov 30 17:51:44 2016

[ObjC ARC] Converts ios/chrome/browser/invalidation:invalidation to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2512123003
Cr-Commit-Position: refs/heads/master@{#435322}

[modify] https://crrev.com/b88732e627633f1843665e3d532275aa79db3756/ios/chrome/browser/invalidation/BUILD.gn
[modify] https://crrev.com/b88732e627633f1843665e3d532275aa79db3756/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm

Project Member Comment 44 by bugdroid1@chromium.org, Nov 30 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6003cf9974cf584ae8523e02a0bc001178fb73ae

commit 6003cf9974cf584ae8523e02a0bc001178fb73ae
Author: sdefresne <sdefresne@chromium.org>
Date: Wed Nov 30 18:11:35 2016

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.Automatically generated ARCMig… (patchset #1 id:1 of https://codereview.chromium.org/2513003002/ )

Reason for revert:
This break the roll because id<AutofillClientIOSBridge> was a weak reference and is now turned into a strong reference.

Since the id<AutofillClientIOSBridge> owns the AutofillClientIOS in the downstream tree this causes a reference cycle and cause a SigninManagerBase::Observer to survive the destruction of SigninManagerBase.

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/bb77ce777e93d29d2bd6969e70da4c11708c1c5a
> Cr-Commit-Position: refs/heads/master@{#435285}

TBR=jdonnelly@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2543683002
Cr-Commit-Position: refs/heads/master@{#435336}

[modify] https://crrev.com/6003cf9974cf584ae8523e02a0bc001178fb73ae/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/6003cf9974cf584ae8523e02a0bc001178fb73ae/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
[modify] https://crrev.com/6003cf9974cf584ae8523e02a0bc001178fb73ae/ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm

Project Member Comment 46 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d66f0fed724f3eff65201ae8e132713ea3b4b726

commit d66f0fed724f3eff65201ae8e132713ea3b4b726
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 12:48:26 2016

[ObjC ARC] Converts ios/chrome/browser/first_run:first_run to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2532533002
Cr-Commit-Position: refs/heads/master@{#436269}

[modify] https://crrev.com/d66f0fed724f3eff65201ae8e132713ea3b4b726/ios/chrome/browser/first_run/BUILD.gn
[modify] https://crrev.com/d66f0fed724f3eff65201ae8e132713ea3b4b726/ios/chrome/browser/first_run/first_run.mm
[modify] https://crrev.com/d66f0fed724f3eff65201ae8e132713ea3b4b726/ios/chrome/browser/first_run/first_run_configuration.mm

Project Member Comment 47 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4299c50ed4048a55d6f14d7220de5ef51cc411c9

commit 4299c50ed4048a55d6f14d7220de5ef51cc411c9
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 13:25:59 2016

[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2528003002
Cr-Commit-Position: refs/heads/master@{#436275}

[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/BUILD.gn
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/CLLocation+OmniboxGeolocation.mm
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/CLLocation+XGeoHeader.mm
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/location_manager.h
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/location_manager.mm
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.h
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.mm
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/omnibox_geolocation_config.mm
[modify] https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9/ios/chrome/browser/geolocation/omnibox_geolocation_local_state.mm

Project Member Comment 48 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f0d6624cef1f5b9f2f2578e702834f5c77347d4

commit 1f0d6624cef1f5b9f2f2578e702834f5c77347d4
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 13:27:13 2016

[ObjC ARC] Converts ios/chrome/browser/open_from_clipboard:open_from_clipboard to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2515723002
Cr-Commit-Position: refs/heads/master@{#436276}

[modify] https://crrev.com/1f0d6624cef1f5b9f2f2578e702834f5c77347d4/ios/chrome/browser/open_from_clipboard/BUILD.gn
[modify] https://crrev.com/1f0d6624cef1f5b9f2f2578e702834f5c77347d4/ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm

Project Member Comment 49 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d6dd774e50cf758953a2606dc5904cddde5c799

commit 6d6dd774e50cf758953a2606dc5904cddde5c799
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 13:59:31 2016

[ObjC ARC] Converts ios/public/consumer/base:base to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2533453002
Cr-Commit-Position: refs/heads/master@{#436281}

[delete] https://crrev.com/7530d98e8559cf6f598b57a073d19cf7470ba752/ios/consumer/base/debugger.mm
[modify] https://crrev.com/6d6dd774e50cf758953a2606dc5904cddde5c799/ios/public/consumer/base/BUILD.gn

Project Member Comment 50 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dc011f657a3d5fec551b2f5512f8d62a2a01458

commit 9dc011f657a3d5fec551b2f5512f8d62a2a01458
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 14:04:41 2016

[ObjC ARC] Converts ios/chrome/browser/geolocation:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2510133003
Cr-Commit-Position: refs/heads/master@{#436283}

[modify] https://crrev.com/9dc011f657a3d5fec551b2f5512f8d62a2a01458/ios/chrome/browser/geolocation/BUILD.gn
[modify] https://crrev.com/9dc011f657a3d5fec551b2f5512f8d62a2a01458/ios/chrome/browser/geolocation/test_location_manager.h
[modify] https://crrev.com/9dc011f657a3d5fec551b2f5512f8d62a2a01458/ios/chrome/browser/geolocation/test_location_manager.mm

Project Member Comment 51 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a34599dd9fd9f5cbfff9316f6d5de97f78f9b204

commit a34599dd9fd9f5cbfff9316f6d5de97f78f9b204
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 14:26:44 2016

[ObjC ARC] Converts ios/chrome/browser/ui/commands:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2511423002
Cr-Commit-Position: refs/heads/master@{#436284}

[modify] https://crrev.com/a34599dd9fd9f5cbfff9316f6d5de97f78f9b204/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/a34599dd9fd9f5cbfff9316f6d5de97f78f9b204/ios/chrome/browser/ui/commands/set_up_for_testing_command_unittest.mm

Project Member Comment 53 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a6a279b85842250fd42dbccae2d7e0e695beebf

commit 1a6a279b85842250fd42dbccae2d7e0e695beebf
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 14:32:50 2016

[ObjC ARC] Converts ios/testing:ios_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2517463004
Cr-Commit-Position: refs/heads/master@{#436287}

[modify] https://crrev.com/1a6a279b85842250fd42dbccae2d7e0e695beebf/ios/testing/BUILD.gn
[modify] https://crrev.com/1a6a279b85842250fd42dbccae2d7e0e695beebf/ios/testing/wait_util.mm

Project Member Comment 55 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/520469a7da6ed46c94557ca30fb06ff7e66c79c1

commit 520469a7da6ed46c94557ca30fb06ff7e66c79c1
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 15:26:57 2016

[ObjC ARC] Converts ios/chrome/browser/ui/voice:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2516663002
Cr-Commit-Position: refs/heads/master@{#436295}

[modify] https://crrev.com/520469a7da6ed46c94557ca30fb06ff7e66c79c1/ios/chrome/browser/ui/voice/BUILD.gn
[modify] https://crrev.com/520469a7da6ed46c94557ca30fb06ff7e66c79c1/ios/chrome/browser/ui/voice/text_to_speech_player_unittest.mm

Project Member Comment 58 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e5f7dbadf9378884651af992fec7f770f01984

commit a3e5f7dbadf9378884651af992fec7f770f01984
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 05 16:10:06 2016

[ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2516643002
Cr-Commit-Position: refs/heads/master@{#436305}

[modify] https://crrev.com/a3e5f7dbadf9378884651af992fec7f770f01984/ios/chrome/browser/itunes_links/BUILD.gn
[modify] https://crrev.com/a3e5f7dbadf9378884651af992fec7f770f01984/ios/chrome/browser/itunes_links/itunes_links_observer.mm

Project Member Comment 60 by bugdroid1@chromium.org, Dec 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc4ae6b485f2561dfa08cee89d6ed62bdacea0e0

commit fc4ae6b485f2561dfa08cee89d6ed62bdacea0e0
Author: lpromero <lpromero@chromium.org>
Date: Mon Dec 05 16:22:13 2016

Revert of [ObjC ARC] Converts ios/public/consumer/base:base to ARC.Automatically generated ARCMigrate commi… (patchset #2 id:20001 of https://codereview.chromium.org/2533453002/ )

Reason for revert:
The .cc is nowhere to be found.

Original issue's description:
> [ObjC ARC] Converts ios/public/consumer/base:base to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/6d6dd774e50cf758953a2606dc5904cddde5c799
> Cr-Commit-Position: refs/heads/master@{#436281}

TBR=sdefresne@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2548313003
Cr-Commit-Position: refs/heads/master@{#436310}

[add] https://crrev.com/fc4ae6b485f2561dfa08cee89d6ed62bdacea0e0/ios/consumer/base/debugger.mm
[modify] https://crrev.com/fc4ae6b485f2561dfa08cee89d6ed62bdacea0e0/ios/public/consumer/base/BUILD.gn

Project Member Comment 61 by bugdroid1@chromium.org, Dec 6
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9b86a463c54cbc4a90efd58be2bbcc2b8c46caab

commit 9b86a463c54cbc4a90efd58be2bbcc2b8c46caab
Author: stkhapugin <stkhapugin@google.com>
Date: Tue Dec 06 17:32:09 2016

Project Member Comment 64 by bugdroid1@chromium.org, Dec 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6809e0da7b2a28371b7455e246d70b256fa0bdbe

commit 6809e0da7b2a28371b7455e246d70b256fa0bdbe
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Dec 06 20:21:40 2016

Revert of [ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2555673003/ )

Reason for revert:
Non-ARC files that include autofill_client_ios.h "cannot create __weak reference in file using manual reference counting".

Original issue's description:
> [ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
> Originally landed as http://crrev.com/2513003002#ps1
>
> Committed: https://crrev.com/302d816fa77d64bd662c13e64e5a71352b728cfc
> Cr-Commit-Position: refs/heads/master@{#436645}

TBR=sdefresne@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2560453003
Cr-Commit-Position: refs/heads/master@{#436690}

[modify] https://crrev.com/6809e0da7b2a28371b7455e246d70b256fa0bdbe/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/6809e0da7b2a28371b7455e246d70b256fa0bdbe/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/6809e0da7b2a28371b7455e246d70b256fa0bdbe/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
[modify] https://crrev.com/6809e0da7b2a28371b7455e246d70b256fa0bdbe/ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm

Project Member Comment 65 by bugdroid1@chromium.org, Dec 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ce7e82e1e3a7f32e1775d3470027fa9cc8317e

commit d9ce7e82e1e3a7f32e1775d3470027fa9cc8317e
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Dec 07 13:03:40 2016

[ObjC ARC] Converts ios/chrome/browser/itunes_links:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2560473002
Cr-Commit-Position: refs/heads/master@{#436929}

[modify] https://crrev.com/d9ce7e82e1e3a7f32e1775d3470027fa9cc8317e/ios/chrome/browser/itunes_links/BUILD.gn
[modify] https://crrev.com/d9ce7e82e1e3a7f32e1775d3470027fa9cc8317e/ios/chrome/browser/itunes_links/itunes_links_observer_unittest.mm

Project Member Comment 67 by bugdroid1@chromium.org, Dec 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dccb2e26346c079e52c21f4d699589417905c408

commit dccb2e26346c079e52c21f4d699589417905c408
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Dec 07 14:25:16 2016

[ObjC ARC] Converts ios/chrome/browser/device_sharing:device_sharing to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2560503002
Cr-Commit-Position: refs/heads/master@{#436944}

[modify] https://crrev.com/dccb2e26346c079e52c21f4d699589417905c408/ios/chrome/browser/device_sharing/BUILD.gn
[modify] https://crrev.com/dccb2e26346c079e52c21f4d699589417905c408/ios/chrome/browser/device_sharing/device_sharing_manager.mm

Project Member Comment 68 by bugdroid1@chromium.org, Dec 7
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0f2a056244886d1f7899f8a2eb85a40e141e1664

commit 0f2a056244886d1f7899f8a2eb85a40e141e1664
Author: stkhapugin <stkhapugin@google.com>
Date: Wed Dec 07 19:33:42 2016

Project Member Comment 69 by bugdroid1@chromium.org, Dec 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce

commit 3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Dec 08 09:59:28 2016

[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Notable issues:
 * After replacing scoped_nsobjects with strong ivars, the tests started failing
because of the change in destruction order of TestWebState and its observer.
Patched TestWebState to reset its observers upon destruction, similar to
WebStateImpl.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2559693003
Cr-Commit-Position: refs/heads/master@{#437223}

[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/chrome/browser/passwords/credential_manager_js_unittest.mm
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/chrome/browser/passwords/credential_manager_unittest.mm
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/chrome/browser/passwords/password_controller_js_unittest.mm
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/chrome/browser/passwords/password_generation_agent_unittest.mm
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/web/public/test/test_web_state.h
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/web/public/test/test_web_state.mm
[modify] https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce/ios/web/public/web_state/web_state_observer.h

Project Member Comment 70 by bugdroid1@chromium.org, Dec 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54842ee261813f25854ace5fd23854238a3f544a

commit 54842ee261813f25854ace5fd23854238a3f544a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Dec 12 16:59:49 2016

[ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2569713002
Cr-Commit-Position: refs/heads/master@{#437891}

[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/UIView+SizeClassSupport.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/animation_util.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/background_generator.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/browser_otr_state.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/favicon_view.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/file_locations.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/image_util.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/native_content_controller.h
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/native_content_controller.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/orientation_limiting_navigation_controller.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/reversed_animation.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/rtl_geometry.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/show_mail_composer_util.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/show_privacy_settings_util.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a/ios/chrome/browser/ui/uikit_ui_util.mm

Project Member Comment 71 by bugdroid1@chromium.org, Dec 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/232afa8c76cdbc55d6a5d790c47dc1430b74e404

commit 232afa8c76cdbc55d6a5d790c47dc1430b74e404
Author: rohitrao <rohitrao@chromium.org>
Date: Mon Dec 12 23:10:49 2016

Revert of [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2569713002/ )

Reason for revert:
Speculatively reverting because downstream device tests are failing.

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a
> Cr-Commit-Position: refs/heads/master@{#437891}

TBR=marq@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2567203002
Cr-Commit-Position: refs/heads/master@{#437943}

[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/UIView+SizeClassSupport.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/animation_util.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/background_generator.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/browser_otr_state.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/favicon_view.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/file_locations.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/image_util.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/native_content_controller.h
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/native_content_controller.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/orientation_limiting_navigation_controller.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/reversed_animation.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/rtl_geometry.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/show_mail_composer_util.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/show_privacy_settings_util.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404/ios/chrome/browser/ui/uikit_ui_util.mm

Project Member Comment 73 by bugdroid1@chromium.org, Dec 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6bf535854df1a3abfc70c64387c8c6beeb67d9f

commit b6bf535854df1a3abfc70c64387c8c6beeb67d9f
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Dec 13 14:05:19 2016

[ObjC ARC] Reland of Converts ios/chrome/browser/ui:ui to ARC.

Reland of https://codereview.chromium.org/2569713002/ that was reverted
with https://codereview.chromium.org/2567203002/ but turned out to not
be the reason for the failures.

Original CL description:

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2569213002
Cr-Commit-Position: refs/heads/master@{#438159}

[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/UIView+SizeClassSupport.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/animation_util.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/background_generator.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/browser_otr_state.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/favicon_view.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/file_locations.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/image_util.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/native_content_controller.h
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/native_content_controller.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/orientation_limiting_navigation_controller.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/reversed_animation.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/rtl_geometry.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/show_mail_composer_util.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/show_privacy_settings_util.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f/ios/chrome/browser/ui/uikit_ui_util.mm

Project Member Comment 74 by bugdroid1@chromium.org, Dec 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1be17914535f9aacc2b54fc5f9b5a899d20350e

commit c1be17914535f9aacc2b54fc5f9b5a899d20350e
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Dec 13 14:30:53 2016

[ObjC ARC] Converts ios/chrome/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2566993002
Cr-Commit-Position: refs/heads/master@{#438164}

[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/app_startup_parameters.h
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/app_startup_parameters.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/chrome_coordinator.h
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/chrome_coordinator.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/chrome_paths.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/chrome_url_util.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/crash_loop_detection_util.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/file_metadata_util.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/install_time_util.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/installation_notifier.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/ios_chrome_io_thread.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/open_url_util.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/root_coordinator.h
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/root_coordinator.mm
[modify] https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e/ios/chrome/browser/xcallback_parameters.mm

Project Member Comment 76 by bugdroid1@chromium.org, Dec 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1430a0933113c948217272e05cc24691c86f3da2

commit 1430a0933113c948217272e05cc24691c86f3da2
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Dec 13 16:05:28 2016

[ObjC ARC] Converts ios/chrome/browser/infobars:infobars to ARC.

Semi-automatically generated ARCMigrate commit

Notable issues:Had to fix includes and subclasses.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2574463002
Cr-Commit-Position: refs/heads/master@{#438183}

[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/BUILD.gn
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/confirm_infobar_controller.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/infobar.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/infobar_container_ios.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/infobar_container_view.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/infobar_controller.h
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/infobar_controller.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/infobar_manager_impl.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/infobars/infobar_utils.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/native_app_launcher/native_app_infobar_delegate.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/passwords/update_password_infobar_controller.h
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/passwords/update_password_infobar_controller.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/translate/after_translate_infobar_controller.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/translate/before_translate_infobar_controller.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/translate/never_translate_infobar_controller.mm
[modify] https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2/ios/chrome/browser/translate/translate_message_infobar_controller.mm

Project Member Comment 77 by bugdroid1@chromium.org, Dec 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e

commit 22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e
Author: olivierrobin <olivierrobin@chromium.org>
Date: Tue Dec 13 16:29:30 2016

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2569713003/ )

Reason for revert:
Breaks compilation of autofill_controller_unittest.mm

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/01e99d0af3a84ae96857d34e096ff4f876e56c2a
> Cr-Commit-Position: refs/heads/master@{#438167}

TBR=noyau@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2577443002
Cr-Commit-Position: refs/heads/master@{#438188}

[modify] https://crrev.com/22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
[modify] https://crrev.com/22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e/ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm

Project Member Comment 79 by bugdroid1@chromium.org, Dec 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a14298b8d714a8f67b4559867d256c5b3047dc

commit 58a14298b8d714a8f67b4559867d256c5b3047dc
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Dec 15 18:53:23 2016

[ObjC ARC] Converts ios/chrome/browser/web:web to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2518583002
Cr-Commit-Position: refs/heads/master@{#438883}

[modify] https://crrev.com/58a14298b8d714a8f67b4559867d256c5b3047dc/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/58a14298b8d714a8f67b4559867d256c5b3047dc/ios/chrome/browser/web/dom_altering_lock.mm
[modify] https://crrev.com/58a14298b8d714a8f67b4559867d256c5b3047dc/ios/chrome/browser/web/resubmit_data_controller.mm

Project Member Comment 80 by bugdroid1@chromium.org, Dec 15
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/83df44b32845a03d390aad7c44c83aac85842c77

commit 83df44b32845a03d390aad7c44c83aac85842c77
Author: stkhapugin <stkhapugin@google.com>
Date: Thu Dec 15 19:19:31 2016

Project Member Comment 81 by bugdroid1@chromium.org, Jan 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fd3bd6a236776370e8c8fc9562d279b6cd9fbc2

commit 8fd3bd6a236776370e8c8fc9562d279b6cd9fbc2
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Jan 05 21:21:08 2017

Merge //ios/chrome/browser/ui:ui_arc with //ios/chrome/browser/ui.

Since both targets require ARC and //ios/chrome/browser/ui has a
public_deps on //ios/chrome/browser/ui:ui_arc, the separation is
no longer necessary.

BUG=624363

Review-Url: https://codereview.chromium.org/2617603003
Cr-Commit-Position: refs/heads/master@{#441756}

[modify] https://crrev.com/8fd3bd6a236776370e8c8fc9562d279b6cd9fbc2/ios/chrome/browser/ui/BUILD.gn

Project Member Comment 82 by bugdroid1@chromium.org, Jan 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79d15aac4eec7b91d05bdc669ccea50846d25a78

commit 79d15aac4eec7b91d05bdc669ccea50846d25a78
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Jan 10 16:19:31 2017

[ObjC ARC] Converts ios/chrome/app/safe_mode:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2627623002
Cr-Commit-Position: refs/heads/master@{#442603}

[modify] https://crrev.com/79d15aac4eec7b91d05bdc669ccea50846d25a78/ios/chrome/app/safe_mode/BUILD.gn
[modify] https://crrev.com/79d15aac4eec7b91d05bdc669ccea50846d25a78/ios/chrome/app/safe_mode/safe_mode_egtest.mm

Project Member Comment 83 by bugdroid1@chromium.org, Jan 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3968913b2ea443786c937d27d9ced8a4249174a

commit f3968913b2ea443786c937d27d9ced8a4249174a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Jan 10 18:17:51 2017

[ObjC ARC] Converts ios/chrome/browser/device_sharing:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2623533003
Cr-Commit-Position: refs/heads/master@{#442632}

[modify] https://crrev.com/f3968913b2ea443786c937d27d9ced8a4249174a/ios/chrome/browser/device_sharing/BUILD.gn
[modify] https://crrev.com/f3968913b2ea443786c937d27d9ced8a4249174a/ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm

Project Member Comment 84 by bugdroid1@chromium.org, Jan 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae00364f8accb45d8ee99270c9bfff763731c3f3

commit ae00364f8accb45d8ee99270c9bfff763731c3f3
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Jan 11 10:34:00 2017

[ObjC ARC] Converts ios/chrome/browser/device_sharing:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2627633002
Cr-Commit-Position: refs/heads/master@{#442859}

[modify] https://crrev.com/ae00364f8accb45d8ee99270c9bfff763731c3f3/ios/chrome/browser/device_sharing/BUILD.gn
[modify] https://crrev.com/ae00364f8accb45d8ee99270c9bfff763731c3f3/ios/chrome/browser/device_sharing/handoff_manager_egtest.mm

Project Member Comment 85 by bugdroid1@chromium.org, Jan 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7caec88b05daa5caec5c923ff60d84e96a98f8ff

commit 7caec88b05daa5caec5c923ff60d84e96a98f8ff
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Jan 11 10:41:49 2017

[ObjC ARC] Converts ios/chrome/app/spotlight:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2627453003
Cr-Commit-Position: refs/heads/master@{#442863}

[modify] https://crrev.com/7caec88b05daa5caec5c923ff60d84e96a98f8ff/ios/chrome/app/spotlight/BUILD.gn
[modify] https://crrev.com/7caec88b05daa5caec5c923ff60d84e96a98f8ff/ios/chrome/app/spotlight/spotlight_manager_unittest.mm

Project Member Comment 86 by bugdroid1@chromium.org, Jan 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b103d6c66bbd7bebfe22affab2ea4930685a55bc

commit b103d6c66bbd7bebfe22affab2ea4930685a55bc
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Jan 12 15:50:28 2017

[ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC.

Semi-autogenerated ARCMigrate commit.
Notable issues:
 * Since one of the weak_nsobjects is exposed in a header and I change it to a __weak instead, converted two unit tests to ARC alongside this.
 * Fixed some assignments of newly created views to weak properties by introducing an intermediate local variable to retain the view until it's added as subview.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2624963003
Cr-Commit-Position: refs/heads/master@{#443240}

[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/clear_browsing_bar.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/favicon_view.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/favicon_view.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/favicon_view_provider.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/favicon_view_provider.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_collection_view_controller.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_collection_view_controller_unittest.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_entries_status_item.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_entries_status_item.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_entry_inserter.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_entry_inserter.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_entry_item.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_entry_item.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_panel_view_controller.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_search_view.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_search_view_controller.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_service_facade.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_service_facade.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_service_facade_unittest.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/history_util.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/tab_history_cell.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/tab_history_cell.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/tab_history_popup_controller.mm
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/tab_history_view_controller.h
[modify] https://crrev.com/b103d6c66bbd7bebfe22affab2ea4930685a55bc/ios/chrome/browser/ui/history/tab_history_view_controller.mm

Project Member Comment 87 by bugdroid1@chromium.org, Jan 17
Project Member Comment 88 by bugdroid1@chromium.org, Jan 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7031a828c5dcedc937bbf375c42daab08ca6162f

commit 7031a828c5dcedc937bbf375c42daab08ca6162f
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Jan 18 19:03:59 2017

[ObjC ARC] Converts ios/chrome/browser/suggestions:suggestions to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Had to keep scoped_nsobject in image_fetcher_impl.mm
for simplicity.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2642813002
Cr-Commit-Position: refs/heads/master@{#444431}

[modify] https://crrev.com/7031a828c5dcedc937bbf375c42daab08ca6162f/ios/chrome/browser/suggestions/BUILD.gn
[modify] https://crrev.com/7031a828c5dcedc937bbf375c42daab08ca6162f/ios/chrome/browser/suggestions/image_fetcher_impl.mm
[modify] https://crrev.com/7031a828c5dcedc937bbf375c42daab08ca6162f/ios/chrome/browser/suggestions/ios_image_decoder_impl.mm
[modify] https://crrev.com/7031a828c5dcedc937bbf375c42daab08ca6162f/ios/chrome/browser/suggestions/suggestions_service_factory.mm

Project Member Comment 89 by bugdroid1@chromium.org, Jan 19
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4c1a7db53cb254200e60dad098be6a655f2ad0

commit 1c4c1a7db53cb254200e60dad098be6a655f2ad0
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Jan 19 13:17:19 2017

[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * In ContextualSearchController, there was a block with a weakSelf declared above it and never used. Replaced usage of self in the block with weakself.
* In window_gesture_observer had to suppress a warning, because ARC forbids calling arbitrary selectors.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2626073003
Cr-Commit-Position: refs/heads/master@{#444717}

[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/BUILD.gn
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_controller.h
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_header_view.h
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_header_view.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_highlighter_view.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_mask_view.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_metrics.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_promo_view.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_results_view.h
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/js_contextual_search_manager.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/panel_configuration.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.h
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/window_gesture_observer.h
[modify] https://crrev.com/1c4c1a7db53cb254200e60dad098be6a655f2ad0/ios/chrome/browser/ui/contextual_search/window_gesture_observer.mm

Project Member Comment 91 by bugdroid1@chromium.org, Jan 19
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7d87d252342973fcbb09c4cac54720c48e9f1be

commit e7d87d252342973fcbb09c4cac54720c48e9f1be
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Jan 19 15:39:41 2017

[ObjC ARC] Converts components/translate/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * added a missing include in translate_collection_view_controller.mm
 * replaced forward declarations with includes to fix compilation

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2645603002
Cr-Commit-Position: refs/heads/master@{#444742}

[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/BUILD.gn
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/ios_translate_driver.mm
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/js_language_detection_manager.mm
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/js_translate_manager.mm
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/language_detection_controller.h
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/language_detection_controller.mm
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/translate_controller.h
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/components/translate/ios/browser/translate_controller.mm
[modify] https://crrev.com/e7d87d252342973fcbb09c4cac54720c48e9f1be/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

Project Member Comment 92 by bugdroid1@chromium.org, Jan 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b9252e8ca973082966612c2fc23c60c6176a81a

commit 5b9252e8ca973082966612c2fc23c60c6176a81a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Jan 27 17:28:23 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/spotlight:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2654433010
Cr-Commit-Position: refs/heads/master@{#446702}

[modify] https://crrev.com/5b9252e8ca973082966612c2fc23c60c6176a81a/ios/public/provider/chrome/browser/spotlight/BUILD.gn
[modify] https://crrev.com/5b9252e8ca973082966612c2fc23c60c6176a81a/ios/public/provider/chrome/browser/spotlight/test_spotlight_provider.mm

Project Member Comment 93 by bugdroid1@chromium.org, Jan 30
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/754c3ba80aa6fccd46a02bcdd6689a7f524abc9a

commit 754c3ba80aa6fccd46a02bcdd6689a7f524abc9a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Jan 30 10:36:41 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/ui:ui to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2653233002
Cr-Commit-Position: refs/heads/master@{#446965}

[modify] https://crrev.com/754c3ba80aa6fccd46a02bcdd6689a7f524abc9a/ios/public/provider/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/754c3ba80aa6fccd46a02bcdd6689a7f524abc9a/ios/public/provider/chrome/browser/ui/default_ios_web_view_factory.mm

Project Member Comment 94 by bugdroid1@chromium.org, Jan 30
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e16d275194300325492301d27e8bc51d800ccaf

commit 7e16d275194300325492301d27e8bc51d800ccaf
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Jan 30 10:43:05 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/spotlight:spotlight to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2655553005
Cr-Commit-Position: refs/heads/master@{#446967}

[modify] https://crrev.com/7e16d275194300325492301d27e8bc51d800ccaf/ios/public/provider/chrome/browser/spotlight/BUILD.gn
[modify] https://crrev.com/7e16d275194300325492301d27e8bc51d800ccaf/ios/public/provider/chrome/browser/spotlight/spotlight_provider.mm

Project Member Comment 96 by bugdroid1@chromium.org, Feb 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17c21fefe0e32acf1196c71882e10277baf406c8

commit 17c21fefe0e32acf1196c71882e10277baf406c8
Author: noyau <noyau@chromium.org>
Date: Wed Feb 01 13:58:46 2017

Converts ios/chrome/browser/native_app_launcher:native_app_launcher_internal to ARC.

This CL also renames a method that used to start with new to remove this prefix.

BUG=624363

Review-Url: https://codereview.chromium.org/2664993003
Cr-Commit-Position: refs/heads/master@{#447505}

[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/chrome/browser/native_app_launcher/BUILD.gn
[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/chrome/browser/native_app_launcher/DEPS
[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm
[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm
[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_whitelist_manager.h
[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_whitelist_manager.mm
[modify] https://crrev.com/17c21fefe0e32acf1196c71882e10277baf406c8/ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h

Project Member Comment 97 by bugdroid1@chromium.org, Feb 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4e16ada59a11a0b003080f7f57b68dd3e503c5a

commit b4e16ada59a11a0b003080f7f57b68dd3e503c5a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Feb 02 10:45:22 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/voice:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2667753008
Cr-Commit-Position: refs/heads/master@{#447737}

[modify] https://crrev.com/b4e16ada59a11a0b003080f7f57b68dd3e503c5a/ios/public/provider/chrome/browser/voice/BUILD.gn
[modify] https://crrev.com/b4e16ada59a11a0b003080f7f57b68dd3e503c5a/ios/public/provider/chrome/browser/voice/test_voice_search_provider.mm

Project Member Comment 98 by bugdroid1@chromium.org, Feb 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72423c5c0fc7c777bf1c8eaa7ee5c9d7d6680a4f

commit 72423c5c0fc7c777bf1c8eaa7ee5c9d7d6680a4f
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Feb 02 10:46:53 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/user_feedback:user_feedback to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2668893005
Cr-Commit-Position: refs/heads/master@{#447738}

[modify] https://crrev.com/72423c5c0fc7c777bf1c8eaa7ee5c9d7d6680a4f/ios/public/provider/chrome/browser/user_feedback/BUILD.gn
[modify] https://crrev.com/72423c5c0fc7c777bf1c8eaa7ee5c9d7d6680a4f/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.mm

Project Member Comment 99 by bugdroid1@chromium.org, Feb 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef521c3175ac03bba73dd9711c50700c917e5b22

commit ef521c3175ac03bba73dd9711c50700c917e5b22
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Feb 02 16:21:42 2017

[ObjC ARC] Converts ios/chrome/browser/ui/elements:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * Silenced -Warc-performSelector-leaks when a button's selector is
being called. Seems ok for unit test.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2663073005
Cr-Commit-Position: refs/heads/master@{#447774}

[modify] https://crrev.com/ef521c3175ac03bba73dd9711c50700c917e5b22/ios/chrome/browser/ui/elements/BUILD.gn
[modify] https://crrev.com/ef521c3175ac03bba73dd9711c50700c917e5b22/ios/chrome/browser/ui/elements/activity_overlay_coordinator_unittest.mm
[modify] https://crrev.com/ef521c3175ac03bba73dd9711c50700c917e5b22/ios/chrome/browser/ui/elements/selector_coordinator_unittest.mm
[modify] https://crrev.com/ef521c3175ac03bba73dd9711c50700c917e5b22/ios/chrome/browser/ui/elements/selector_picker_view_controller_unittest.mm

Project Member Comment 100 by bugdroid1@chromium.org, Feb 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b25f7012f7e9c40aa71782367acf456ba919a5

commit f9b25f7012f7e9c40aa71782367acf456ba919a5
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Feb 02 18:18:07 2017

[ObjC ARC] Converts components/history/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2670693003
Cr-Commit-Position: refs/heads/master@{#447798}

[modify] https://crrev.com/f9b25f7012f7e9c40aa71782367acf456ba919a5/components/history/ios/browser/BUILD.gn
[modify] https://crrev.com/f9b25f7012f7e9c40aa71782367acf456ba919a5/components/history/ios/browser/web_state_top_sites_observer.mm

Project Member Comment 102 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edc1e9058dbd3c582b9f8e0f94a450db5bc05cb8

commit edc1e9058dbd3c582b9f8e0f94a450db5bc05cb8
Author: lod <lod@chromium.org>
Date: Mon Feb 06 15:40:05 2017

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2671363002
Cr-Commit-Position: refs/heads/master@{#448257}

[modify] https://crrev.com/edc1e9058dbd3c582b9f8e0f94a450db5bc05cb8/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/edc1e9058dbd3c582b9f8e0f94a450db5bc05cb8/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm

Project Member Comment 103 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da08bcd20a501948398e39977aa428d9df10d91

commit 3da08bcd20a501948398e39977aa428d9df10d91
Author: lod <lod@chromium.org>
Date: Mon Feb 06 15:43:40 2017

[ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2677933003
Cr-Commit-Position: refs/heads/master@{#448259}

[modify] https://crrev.com/3da08bcd20a501948398e39977aa428d9df10d91/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/3da08bcd20a501948398e39977aa428d9df10d91/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm

Project Member Comment 104 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/492650328da4acabc231977414adf983ed3c952d

commit 492650328da4acabc231977414adf983ed3c952d
Author: lod <lod@chromium.org>
Date: Mon Feb 06 17:46:56 2017

[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2672393002
Cr-Commit-Position: refs/heads/master@{#448293}

[modify] https://crrev.com/492650328da4acabc231977414adf983ed3c952d/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/492650328da4acabc231977414adf983ed3c952d/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm

Project Member Comment 105 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7db448e0187ef5db978a3e7d14aa7f8386396bb9

commit 7db448e0187ef5db978a3e7d14aa7f8386396bb9
Author: lod <lod@chromium.org>
Date: Mon Feb 06 17:48:00 2017

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:perf_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2675253003
Cr-Commit-Position: refs/heads/master@{#448294}

[modify] https://crrev.com/7db448e0187ef5db978a3e7d14aa7f8386396bb9/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/7db448e0187ef5db978a3e7d14aa7f8386396bb9/ios/chrome/browser/ui/ntp/new_tab_page_perftest.mm

Project Member Comment 106 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f48c0d29252161f18443369409d694adee2919cb

commit f48c0d29252161f18443369409d694adee2919cb
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 06 18:03:05 2017

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2680473002
Cr-Commit-Position: refs/heads/master@{#448300}

[modify] https://crrev.com/f48c0d29252161f18443369409d694adee2919cb/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/f48c0d29252161f18443369409d694adee2919cb/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Project Member Comment 107 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a890ff64eb76dcb0d877ccc610d6c5b5d5a638b6

commit a890ff64eb76dcb0d877ccc610d6c5b5d5a638b6
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 06 18:11:04 2017

[ObjC ARC] Converts ios/chrome/browser/ui/print:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2677253002
Cr-Commit-Position: refs/heads/master@{#448306}

[modify] https://crrev.com/a890ff64eb76dcb0d877ccc610d6c5b5d5a638b6/ios/chrome/browser/ui/print/BUILD.gn
[modify] https://crrev.com/a890ff64eb76dcb0d877ccc610d6c5b5d5a638b6/ios/chrome/browser/ui/print/print_controller_egtest.mm

Project Member Comment 108 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21b6f3db42a1ff35b33993812b2fd851922c4770

commit 21b6f3db42a1ff35b33993812b2fd851922c4770
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 06 18:12:19 2017

[ObjC ARC] Converts ios/chrome/browser/ui/authentication:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2674193003
Cr-Commit-Position: refs/heads/master@{#448307}

[modify] https://crrev.com/21b6f3db42a1ff35b33993812b2fd851922c4770/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/21b6f3db42a1ff35b33993812b2fd851922c4770/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm

Project Member Comment 109 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807f8f0f2e030129bebe6efd0bb26ddaed5a7366

commit 807f8f0f2e030129bebe6efd0bb26ddaed5a7366
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 06 18:26:26 2017

[ObjC ARC] Converts ios/chrome/browser/ui/first_run:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2679673002
Cr-Commit-Position: refs/heads/master@{#448314}

[modify] https://crrev.com/807f8f0f2e030129bebe6efd0bb26ddaed5a7366/ios/chrome/browser/ui/first_run/BUILD.gn
[modify] https://crrev.com/807f8f0f2e030129bebe6efd0bb26ddaed5a7366/ios/chrome/browser/ui/first_run/first_run_egtest.mm

Project Member Comment 111 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/983e068bc02286e6cd5f1c867e8ee2e7719e8322

commit 983e068bc02286e6cd5f1c867e8ee2e7719e8322
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 06 19:11:57 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2673483004
Cr-Commit-Position: refs/heads/master@{#448337}

[modify] https://crrev.com/983e068bc02286e6cd5f1c867e8ee2e7719e8322/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/983e068bc02286e6cd5f1c867e8ee2e7719e8322/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm

Project Member Comment 112 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b8ec1250bd59a373acfeb6040ded92310ad315a

commit 1b8ec1250bd59a373acfeb6040ded92310ad315a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 06 19:13:07 2017

[ObjC ARC] Converts ios/chrome/browser/metrics:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2674293003
Cr-Commit-Position: refs/heads/master@{#448338}

[modify] https://crrev.com/1b8ec1250bd59a373acfeb6040ded92310ad315a/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/1b8ec1250bd59a373acfeb6040ded92310ad315a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

Project Member Comment 113 by bugdroid1@chromium.org, Feb 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7719f15c6e4eeaaf2ba20f74507ff6d0e6702a6c

commit 7719f15c6e4eeaaf2ba20f74507ff6d0e6702a6c
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 06 19:18:15 2017

[ObjC ARC] Converts ios/chrome/browser/ui/context_menu:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2677523002
Cr-Commit-Position: refs/heads/master@{#448342}

[modify] https://crrev.com/7719f15c6e4eeaaf2ba20f74507ff6d0e6702a6c/ios/chrome/browser/ui/context_menu/BUILD.gn
[modify] https://crrev.com/7719f15c6e4eeaaf2ba20f74507ff6d0e6702a6c/ios/chrome/browser/ui/context_menu/context_menu_coordinator_unittest.mm

Project Member Comment 115 by bugdroid1@chromium.org, Feb 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97d545248e030879ef49e0aebb7f9643705360b1

commit 97d545248e030879ef49e0aebb7f9643705360b1
Author: lod <lod@chromium.org>
Date: Tue Feb 07 10:35:21 2017

[ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Removed the autorelease pool.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2672383002
Cr-Commit-Position: refs/heads/master@{#448585}

[modify] https://crrev.com/97d545248e030879ef49e0aebb7f9643705360b1/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/97d545248e030879ef49e0aebb7f9643705360b1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm

Project Member Comment 117 by bugdroid1@chromium.org, Feb 8
Project Member Comment 118 by bugdroid1@chromium.org, Feb 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1493b26bda043e9e54467c5c1adf22e320a6673

commit f1493b26bda043e9e54467c5c1adf22e320a6673
Author: lod <lod@chromium.org>
Date: Wed Feb 08 13:31:37 2017

[ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.

Automatically generated ARCMigrate commit
Notable issues:
autofill_client_ios had a variable commented as weak but not actually handled as such. Tried using Weak_NS_Object but it had incorrect behavior wrt autorelease pools. Since the file is only currently included in arc converted targets, __weak was used which functions correctly.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2686583002
Cr-Commit-Position: refs/heads/master@{#448979}

[modify] https://crrev.com/f1493b26bda043e9e54467c5c1adf22e320a6673/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/f1493b26bda043e9e54467c5c1adf22e320a6673/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/f1493b26bda043e9e54467c5c1adf22e320a6673/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
[modify] https://crrev.com/f1493b26bda043e9e54467c5c1adf22e320a6673/ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm
[modify] https://crrev.com/f1493b26bda043e9e54467c5c1adf22e320a6673/ios/chrome/browser/ui/autofill/card_unmask_prompt_view_bridge.mm
[modify] https://crrev.com/f1493b26bda043e9e54467c5c1adf22e320a6673/ios/chrome/browser/ui/autofill/storage_switch_tooltip.mm

Project Member Comment 119 by bugdroid1@chromium.org, Feb 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d57717758fba0a9d1f7b9a8a101d7f50909bec15

commit d57717758fba0a9d1f7b9a8a101d7f50909bec15
Author: lod <lod@chromium.org>
Date: Wed Feb 08 16:25:53 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tabs:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2682093002
Cr-Commit-Position: refs/heads/master@{#449009}

[modify] https://crrev.com/d57717758fba0a9d1f7b9a8a101d7f50909bec15/ios/chrome/browser/ui/tabs/BUILD.gn
[modify] https://crrev.com/d57717758fba0a9d1f7b9a8a101d7f50909bec15/ios/chrome/browser/ui/tabs/tab_strip_egtest.mm

Project Member Comment 121 by bugdroid1@chromium.org, Feb 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a833ef37b4b4b014924b420b385afa0bb6e47e4a

commit a833ef37b4b4b014924b420b385afa0bb6e47e4a
Author: lod <lod@chromium.org>
Date: Wed Feb 08 21:26:37 2017

[ObjC ARC] Converts ios/chrome/browser/ui/activity_services:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2680973004
Cr-Commit-Position: refs/heads/master@{#449098}

[modify] https://crrev.com/a833ef37b4b4b014924b420b385afa0bb6e47e4a/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/a833ef37b4b4b014924b420b385afa0bb6e47e4a/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm

Project Member Comment 122 by bugdroid1@chromium.org, Feb 9
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4da2c151d254da2f60b694981362860e005ed562

commit 4da2c151d254da2f60b694981362860e005ed562
Author: lod <lod@chromium.org>
Date: Thu Feb 09 09:34:11 2017

[ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2680803003
Cr-Commit-Position: refs/heads/master@{#449246}

[modify] https://crrev.com/4da2c151d254da2f60b694981362860e005ed562/ios/chrome/browser/ui/alert_coordinator/BUILD.gn
[modify] https://crrev.com/4da2c151d254da2f60b694981362860e005ed562/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm

Project Member Comment 124 by bugdroid1@chromium.org, Feb 9
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae94774be25333de017df83c67e674b6ac3dbe4b

commit ae94774be25333de017df83c67e674b6ac3dbe4b
Author: lod <lod@chromium.org>
Date: Thu Feb 09 13:29:50 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Added __unsafe_unretained annotation to ExecuteJavascript function in order to handle not-yet-ARC files.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684023003
Cr-Commit-Position: refs/heads/master@{#449278}

[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/accessibility_util.mm
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_actions.mm
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_assertions.mm
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_earl_grey.h
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_earl_grey.mm
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_matchers.mm
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_test_case.mm
[modify] https://crrev.com/ae94774be25333de017df83c67e674b6ac3dbe4b/ios/chrome/test/earl_grey/chrome_util.mm

Project Member Comment 125 by bugdroid1@chromium.org, Feb 9
Project Member Comment 132 by bugdroid1@chromium.org, Feb 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afbbf1feb13941a13695d63028c4796bd26c6c4a

commit afbbf1feb13941a13695d63028c4796bd26c6c4a
Author: lod <lod@chromium.org>
Date: Fri Feb 10 14:29:10 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tabs:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Added __unsafe_unretained annotations.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2686533006
Cr-Commit-Position: refs/heads/master@{#449613}

[modify] https://crrev.com/afbbf1feb13941a13695d63028c4796bd26c6c4a/ios/chrome/browser/ui/tabs/BUILD.gn
[modify] https://crrev.com/afbbf1feb13941a13695d63028c4796bd26c6c4a/ios/chrome/browser/ui/tabs/tab_strip_controller_unittest.mm

Project Member Comment 133 by bugdroid1@chromium.org, Feb 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86412cb8391076dbaf91ce14b6c9fefb7451c04c

commit 86412cb8391076dbaf91ce14b6c9fefb7451c04c
Author: lod <lod@chromium.org>
Date: Fri Feb 10 14:30:25 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2680973009
Cr-Commit-Position: refs/heads/master@{#449614}

[modify] https://crrev.com/86412cb8391076dbaf91ce14b6c9fefb7451c04c/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/86412cb8391076dbaf91ce14b6c9fefb7451c04c/ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm

Blockedon: 691068
Project Member Comment 136 by bugdroid1@chromium.org, Feb 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d0dbb08c8321e85a1ff056dd2e269f68c779f6

commit d7d0dbb08c8321e85a1ff056dd2e269f68c779f6
Author: lod <lod@chromium.org>
Date: Mon Feb 13 14:32:47 2017

[ObjC ARC] Converts ios/chrome/browser/upgrade:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684073007
Cr-Commit-Position: refs/heads/master@{#449950}

[modify] https://crrev.com/d7d0dbb08c8321e85a1ff056dd2e269f68c779f6/ios/chrome/browser/upgrade/BUILD.gn
[modify] https://crrev.com/d7d0dbb08c8321e85a1ff056dd2e269f68c779f6/ios/chrome/browser/upgrade/upgrade_center_unittest.mm

Project Member Comment 138 by bugdroid1@chromium.org, Feb 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a093a45c9ef9366183d392f5c054eecac3bd26

commit 77a093a45c9ef9366183d392f5c054eecac3bd26
Author: lod <lod@chromium.org>
Date: Mon Feb 13 14:48:04 2017

[ObjC ARC] Converts ios/chrome/browser/omaha:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2691433005
Cr-Commit-Position: refs/heads/master@{#449953}

[modify] https://crrev.com/77a093a45c9ef9366183d392f5c054eecac3bd26/ios/chrome/browser/omaha/BUILD.gn
[modify] https://crrev.com/77a093a45c9ef9366183d392f5c054eecac3bd26/ios/chrome/browser/omaha/omaha_service_unittest.mm

Project Member Comment 139 by bugdroid1@chromium.org, Feb 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e9840b30931657509e62fcb37735247515f481

commit 62e9840b30931657509e62fcb37735247515f481
Author: lod <lod@chromium.org>
Date: Mon Feb 13 14:49:17 2017

[ObjC ARC] Converts ios/chrome/browser/ui/promos:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2688703004
Cr-Commit-Position: refs/heads/master@{#449954}

[modify] https://crrev.com/62e9840b30931657509e62fcb37735247515f481/ios/chrome/browser/ui/promos/BUILD.gn
[modify] https://crrev.com/62e9840b30931657509e62fcb37735247515f481/ios/chrome/browser/ui/promos/signin_promo_view_controller_unittest.mm

Project Member Comment 140 by bugdroid1@chromium.org, Feb 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee2192b1f215da8c710bdf47d2643f43220db62d

commit ee2192b1f215da8c710bdf47d2643f43220db62d
Author: lod <lod@chromium.org>
Date: Mon Feb 13 15:21:47 2017

[ObjC ARC] Converts ios/chrome/browser/ui/omnibox:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2683423003
Cr-Commit-Position: refs/heads/master@{#449960}

[modify] https://crrev.com/ee2192b1f215da8c710bdf47d2643f43220db62d/ios/chrome/browser/ui/omnibox/BUILD.gn
[modify] https://crrev.com/ee2192b1f215da8c710bdf47d2643f43220db62d/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm

Project Member Comment 144 by bugdroid1@chromium.org, Feb 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5106048c624b4ae8421a1f88e7cbe4d7e85869

commit 6a5106048c624b4ae8421a1f88e7cbe4d7e85869
Author: lod <lod@chromium.org>
Date: Tue Feb 14 17:11:59 2017

[ObjC ARC] Converts ios/chrome/common:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Separated block_unittest.mm into its own target as it checks memory management and does not apply to an ARC environment. Bug opened at https://bugs.chromium.org/p/chromium/issues/detail?id=690941 to create a test to check for correct interaction of C++ and blocks in the ARC world.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2681353002
Cr-Commit-Position: refs/heads/master@{#450391}

[modify] https://crrev.com/6a5106048c624b4ae8421a1f88e7cbe4d7e85869/ios/chrome/common/BUILD.gn
[modify] https://crrev.com/6a5106048c624b4ae8421a1f88e7cbe4d7e85869/ios/chrome/common/ns_regular_expression_unittest.mm
[modify] https://crrev.com/6a5106048c624b4ae8421a1f88e7cbe4d7e85869/ios/chrome/common/string_util_unittest.mm

Project Member Comment 145 by bugdroid1@chromium.org, Feb 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/325f2c708daa27325c3df61be4b4598bbeb1ffab

commit 325f2c708daa27325c3df61be4b4598bbeb1ffab
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Feb 15 17:10:30 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2674313002
Cr-Commit-Position: refs/heads/master@{#450730}

[modify] https://crrev.com/325f2c708daa27325c3df61be4b4598bbeb1ffab/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/325f2c708daa27325c3df61be4b4598bbeb1ffab/ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm

Project Member Comment 146 by bugdroid1@chromium.org, Feb 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eac25584b5d780af4fb248ad81bf97b4642e8911

commit eac25584b5d780af4fb248ad81bf97b4642e8911
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Feb 15 17:16:12 2017

[ObjC ARC] Converts ios/chrome/browser/context_menu:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2672393003
Cr-Commit-Position: refs/heads/master@{#450731}

[modify] https://crrev.com/eac25584b5d780af4fb248ad81bf97b4642e8911/ios/chrome/browser/context_menu/BUILD.gn
[modify] https://crrev.com/eac25584b5d780af4fb248ad81bf97b4642e8911/ios/chrome/browser/context_menu/context_menu_egtest.mm

Project Member Comment 147 by bugdroid1@chromium.org, Feb 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d3c8f9e11b4a149345c1ead38132a0f6677cf0

commit b5d3c8f9e11b4a149345c1ead38132a0f6677cf0
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Feb 15 17:18:06 2017

[ObjC ARC] Converts ios/chrome/browser/ui/webui:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2677193003
Cr-Commit-Position: refs/heads/master@{#450732}

[modify] https://crrev.com/b5d3c8f9e11b4a149345c1ead38132a0f6677cf0/ios/chrome/browser/ui/webui/BUILD.gn
[modify] https://crrev.com/b5d3c8f9e11b4a149345c1ead38132a0f6677cf0/ios/chrome/browser/ui/webui/web_ui_egtest.mm

Project Member Comment 148 by bugdroid1@chromium.org, Feb 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f5f107d3c95b2a48c4dbb21befc5f7c810e190

commit 97f5f107d3c95b2a48c4dbb21befc5f7c810e190
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Feb 15 19:08:04 2017

[ObjC ARC] Converts ios/chrome/browser/ui/find_bar:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2676253003
Cr-Commit-Position: refs/heads/master@{#450755}

[modify] https://crrev.com/97f5f107d3c95b2a48c4dbb21befc5f7c810e190/ios/chrome/browser/ui/find_bar/BUILD.gn
[modify] https://crrev.com/97f5f107d3c95b2a48c4dbb21befc5f7c810e190/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

Project Member Comment 149 by bugdroid1@chromium.org, Feb 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2721a1e8771f3880b23ed94c787d9a1d3dd4cefd

commit 2721a1e8771f3880b23ed94c787d9a1d3dd4cefd
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Feb 15 19:48:55 2017

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2681463002
Cr-Commit-Position: refs/heads/master@{#450779}

[modify] https://crrev.com/2721a1e8771f3880b23ed94c787d9a1d3dd4cefd/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/2721a1e8771f3880b23ed94c787d9a1d3dd4cefd/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm

Project Member Comment 150 by bugdroid1@chromium.org, Feb 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea17954554e8b06addf76b35be0c7d67918e85e4

commit ea17954554e8b06addf76b35be0c7d67918e85e4
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 20 13:26:00 2017

[ObjC ARC] Converts ios/chrome/app/startup:startup to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2702253002
Cr-Commit-Position: refs/heads/master@{#451615}

[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/BUILD.gn
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/background_upload_alert.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/chrome_main_starter.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/client_registration.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/ios_chrome_main.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/ios_chrome_main_delegate.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/network_stack_setup.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/provider_registration.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/register_experimental_settings.mm
[modify] https://crrev.com/ea17954554e8b06addf76b35be0c7d67918e85e4/ios/chrome/app/startup/setup_debugging.mm

Project Member Comment 151 by bugdroid1@chromium.org, Feb 20
Project Member Comment 152 by bugdroid1@chromium.org, Feb 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd475891a5721fb6a45b2a7ff92f7f4b22858625

commit dd475891a5721fb6a45b2a7ff92f7f4b22858625
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Feb 20 18:03:54 2017

[ObjC ARC] Converts ios/chrome/app/spotlight:spotlight to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* in topsites_spotlight_manager.mm, added a strongself to avoid dereferncing a weak
 pointer (which would cause crashes, but is not a compiler-diagnosed error without
 ARC).

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2704193002
Cr-Commit-Position: refs/heads/master@{#451650}

[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/BUILD.gn
[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/actions_spotlight_manager.mm
[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/base_spotlight_manager.mm
[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/bookmarks_spotlight_manager.h
[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm
[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/spotlight_manager.mm
[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/spotlight_util.mm
[modify] https://crrev.com/dd475891a5721fb6a45b2a7ff92f7f4b22858625/ios/chrome/app/spotlight/topsites_spotlight_manager.mm

Project Member Comment 155 by bugdroid1@chromium.org, Feb 21
Project Member Comment 156 by bugdroid1@chromium.org, Feb 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c128dc4e5b8cca6204736217dd000655859afdfd

commit c128dc4e5b8cca6204736217dd000655859afdfd
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Feb 23 10:58:18 2017

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2677293002
Cr-Commit-Position: refs/heads/master@{#452451}

[modify] https://crrev.com/c128dc4e5b8cca6204736217dd000655859afdfd/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/c128dc4e5b8cca6204736217dd000655859afdfd/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Project Member Comment 157 by bugdroid1@chromium.org, Feb 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37fced85ea7c8f784efe85925bff95af50082b36

commit 37fced85ea7c8f784efe85925bff95af50082b36
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Feb 23 16:27:12 2017

[ObjC ARC] Converts ios/chrome/browser/payments:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2706193004
Cr-Commit-Position: refs/heads/master@{#452513}

[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/BUILD.gn
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_items_display_coordinator_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_items_display_view_controller_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_method_selection_coordinator_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_method_selection_view_controller_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_request_coordinator_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_request_test_util.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/payment_request_view_controller_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/shipping_address_selection_coordinator_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/shipping_address_selection_view_controller_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/shipping_option_selection_coordinator_unittest.mm
[modify] https://crrev.com/37fced85ea7c8f784efe85925bff95af50082b36/ios/chrome/browser/payments/shipping_option_selection_view_controller_unittest.mm

Project Member Comment 158 by bugdroid1@chromium.org, Feb 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c1d6844450a80766c882b007587f37e7b3e429d

commit 9c1d6844450a80766c882b007587f37e7b3e429d
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Feb 24 19:04:30 2017

[ObjC ARC] Converts ios/chrome/browser/payments:payments to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- Removed multiple delegate getter/setter/ivar combos with synthesize
- Fixed memory management in several blocks, for example:
 __weak ShippingOptionSelectionCoordinator* weakSelf = self;
  dispatch_after(
      dispatch_time(DISPATCH_TIME_NOW,
                    static_cast<int64_t>(0.2 * NSEC_PER_SEC)),
      dispatch_get_main_queue(), ^{
        ShippingOptionSelectionCoordinator* strongSelf = weakSelf;
        // Early return if the coordinator has been deallocated.
        if (!strongSelf)
          return;
        [_viewController setIsLoading:YES];
}

last line retains self through dereferenced ivar. Also further in the same block:

        [_delegate shippingOptionSelectionCoordinator:self  didSelectShippingOption:shippingOption];

direct reference to |self|

* In PaymentRequestViewController the following ivars are now strong:
  PriceItem* _paymentSummaryItem;
  ShippingAddressItem* _selectedShippingAddressItem;
  CollectionViewTextItem* _selectedShippingOptionItem;
  PaymentMethodItem* _selectedPaymentMethodItem;

* For multiple view controllers with errorMessage property, it was changed from assign to copy as this seems to reflect de-facto usage.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2710493006
Cr-Commit-Position: refs/heads/master@{#452891}

[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/BUILD.gn
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/js_payment_request_manager.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_items_display_coordinator.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_items_display_view_controller.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_method_selection_coordinator.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_method_selection_view_controller.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_request_coordinator.h
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_request_coordinator.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_request_manager.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_request_util.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_request_view_controller.h
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/payment_request_view_controller.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/shipping_address_selection_view_controller.h
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/shipping_address_selection_view_controller.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/shipping_option_selection_coordinator.mm
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/shipping_option_selection_view_controller.h
[modify] https://crrev.com/9c1d6844450a80766c882b007587f37e7b3e429d/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm

Project Member Comment 159 by bugdroid1@chromium.org, Mar 9
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8f4e1ce15fbe54f10910f18eefbbb2419d3b97d

commit c8f4e1ce15fbe54f10910f18eefbbb2419d3b97d
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Mar 09 16:29:51 2017

[ObjC ARC] Converts ios/chrome/browser/ui/collection_view/cells:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2742783002
Cr-Commit-Position: refs/heads/master@{#455762}

[modify] https://crrev.com/c8f4e1ce15fbe54f10910f18eefbbb2419d3b97d/ios/chrome/browser/ui/collection_view/cells/BUILD.gn
[modify] https://crrev.com/c8f4e1ce15fbe54f10910f18eefbbb2419d3b97d/ios/chrome/browser/ui/collection_view/cells/test_utils.mm

Project Member Comment 160 by bugdroid1@chromium.org, Mar 9
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cdd3bc1bae9ff0f2a2e6c4408e646e32de1e9f0

commit 2cdd3bc1bae9ff0f2a2e6c4408e646e32de1e9f0
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Mar 09 16:31:11 2017

[ObjC ARC] Converts ios/chrome/browser/ui/collection_view:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2743723002
Cr-Commit-Position: refs/heads/master@{#455763}

[modify] https://crrev.com/2cdd3bc1bae9ff0f2a2e6c4408e646e32de1e9f0/ios/chrome/browser/ui/collection_view/BUILD.gn
[modify] https://crrev.com/2cdd3bc1bae9ff0f2a2e6c4408e646e32de1e9f0/ios/chrome/browser/ui/collection_view/collection_view_controller_test.mm

Project Member Comment 162 by bugdroid1@chromium.org, Mar 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1b61106131df8a2eca7d0a71ea026d6e3707680

commit d1b61106131df8a2eca7d0a71ea026d6e3707680
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Mar 10 14:15:54 2017

[ObjC ARC] Converts a part of ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit (after manually splitting the target).

Converted a relevant unit test alongside this to prevent fiddling with BOOL GetPositionCache(bookmarks::BookmarkModel* model, BookmarkMenuItem** item,  CGFloat* position);
which has an out paramteter |item| that is __autoreleasing in ARC.

Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737793003
Cr-Commit-Position: refs/heads/master@{#456054}

[modify] https://crrev.com/d1b61106131df8a2eca7d0a71ea026d6e3707680/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/d1b61106131df8a2eca7d0a71ea026d6e3707680/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
[modify] https://crrev.com/d1b61106131df8a2eca7d0a71ea026d6e3707680/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
[modify] https://crrev.com/d1b61106131df8a2eca7d0a71ea026d6e3707680/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h
[modify] https://crrev.com/d1b61106131df8a2eca7d0a71ea026d6e3707680/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
[modify] https://crrev.com/d1b61106131df8a2eca7d0a71ea026d6e3707680/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm

Project Member Comment 163 by bugdroid1@chromium.org, Mar 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a

commit dfc151cf408ffc92bfdc1d40f06487f8a256bc0a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Mar 10 15:25:56 2017

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737603007
Cr-Commit-Position: refs/heads/master@{#456064}

[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.h
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_extended_button.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.h
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h
[modify] https://crrev.com/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm

Project Member Comment 164 by bugdroid1@chromium.org, Mar 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33939c01a9cc0064f9a9a50060af1036c5b86ae1

commit 33939c01a9cc0064f9a9a50060af1036c5b86ae1
Author: baxley <baxley@chromium.org>
Date: Fri Mar 10 16:56:49 2017

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC. (patchset #4 id:60001 of https://codereview.chromium.org/2737603007/ )

Reason for revert:
EG bookmarks tests started failing after this CL. Here is the first failure:
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25193

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2737603007
> Cr-Commit-Position: refs/heads/master@{#456064}
> Committed: https://chromium.googlesource.com/chromium/src/+/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a

TBR=lpromero@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2738053008
Cr-Commit-Position: refs/heads/master@{#456084}

[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.h
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_extended_button.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.h
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h
[modify] https://crrev.com/33939c01a9cc0064f9a9a50060af1036c5b86ae1/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm

Project Member Comment 165 by bugdroid1@chromium.org, Mar 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bbaaf780f18e55c5f7055933f557b49cfb8dd90

commit 7bbaaf780f18e55c5f7055933f557b49cfb8dd90
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Mar 14 13:26:07 2017

Converts  ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to "return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None

Initially was failing EG tests, see Notable issues for steps taken.

Review-Url: https://codereview.chromium.org/2741413005
Cr-Commit-Position: refs/heads/master@{#456684}

[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.h
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_extended_button.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.h
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h
[modify] https://crrev.com/7bbaaf780f18e55c5f7055933f557b49cfb8dd90/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm

Project Member Comment 166 by bugdroid1@chromium.org, Mar 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da3338bfc027c0b7a48e5b033feb04f24792b17

commit 3da3338bfc027c0b7a48e5b033feb04f24792b17
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Mar 23 16:19:51 2017

[ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* added some __bridge casts
* put some __weak and __unsafe_unretained classifiers in headers

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2707963002
Cr-Commit-Position: refs/heads/master@{#459107}

[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/BUILD.gn
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.h
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/page_info_view_controller.h
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
[modify] https://crrev.com/3da3338bfc027c0b7a48e5b033feb04f24792b17/ios/chrome/browser/ui/omnibox/truncating_attributed_label.mm

Project Member Comment 167 by bugdroid1@chromium.org, Mar 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b5abb6552410cef4b2de74624b24a32a3081a2

commit e1b5abb6552410cef4b2de74624b24a32a3081a2
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Mar 23 18:04:56 2017

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2746473003
Cr-Commit-Position: refs/heads/master@{#459141}

[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_menu_view.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_menu_view.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_navigation_controller.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/undo_manager_bridge_observer.h
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/undo_manager_bridge_observer.mm
[modify] https://crrev.com/e1b5abb6552410cef4b2de74624b24a32a3081a2/ios/chrome/browser/ui/bookmarks/undo_manager_wrapper.mm

Project Member Comment 169 by bugdroid1@chromium.org, Apr 4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d68bdda8117c2a5a056b9cbde8e2167667b8cda

commit 9d68bdda8117c2a5a056b9cbde8e2167667b8cda
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Apr 04 13:35:47 2017

[ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:recent_tabs to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2791393003
Cr-Commit-Position: refs/heads/master@{#461695}

[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_bridges.mm
[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller.mm
[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_view_controller.mm
[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/synced_sessions.mm
[modify] https://crrev.com/9d68bdda8117c2a5a056b9cbde8e2167667b8cda/ios/chrome/browser/ui/ntp/recent_tabs/synced_sessions_bridge.mm

Project Member Comment 170 by bugdroid1@chromium.org, Apr 4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f3bc2f34da74027cb7c9a13f284b1fe36fe2c8c

commit 4f3bc2f34da74027cb7c9a13f284b1fe36fe2c8c
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Apr 04 14:42:00 2017

[ObjC ARC] Converts ios/chrome/browser/sessions:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2794323002
Cr-Commit-Position: refs/heads/master@{#461708}

[modify] https://crrev.com/4f3bc2f34da74027cb7c9a13f284b1fe36fe2c8c/ios/chrome/browser/sessions/BUILD.gn
[modify] https://crrev.com/4f3bc2f34da74027cb7c9a13f284b1fe36fe2c8c/ios/chrome/browser/sessions/test_session_service.mm

Project Member Comment 171 by bugdroid1@chromium.org, Apr 4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaed52b14050ecd107d32e3d675655f22e768d61

commit aaed52b14050ecd107d32e3d675655f22e768d61
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Apr 04 14:43:39 2017

[ObjC ARC] Converts ios/chrome/browser/sessions:unit_tests_non_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2798603002
Cr-Commit-Position: refs/heads/master@{#461709}

[modify] https://crrev.com/aaed52b14050ecd107d32e3d675655f22e768d61/ios/chrome/browser/sessions/BUILD.gn
[modify] https://crrev.com/aaed52b14050ecd107d32e3d675655f22e768d61/ios/chrome/browser/sessions/session_service_unittest.mm

Project Member Comment 172 by bugdroid1@chromium.org, Apr 4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ff6b503d55bed35724a60b11e45ff170c70056

commit a1ff6b503d55bed35724a60b11e45ff170c70056
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Apr 04 14:48:31 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/ui:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2794173003
Cr-Commit-Position: refs/heads/master@{#461712}

[modify] https://crrev.com/a1ff6b503d55bed35724a60b11e45ff170c70056/ios/public/provider/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a1ff6b503d55bed35724a60b11e45ff170c70056/ios/public/provider/chrome/browser/ui/test_styled_text_field.mm

Project Member Comment 173 by bugdroid1@chromium.org, Apr 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaf17ac2acadc597bb6b08182f3045da0da8ecfb

commit aaf17ac2acadc597bb6b08182f3045da0da8ecfb
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Apr 06 08:35:15 2017

[ObjC ARC] Converts ios/chrome/browser/ui:perf_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2798903002
Cr-Commit-Position: refs/heads/master@{#462393}

[modify] https://crrev.com/aaf17ac2acadc597bb6b08182f3045da0da8ecfb/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/aaf17ac2acadc597bb6b08182f3045da0da8ecfb/ios/chrome/browser/ui/omnibox_perftest.mm

Project Member Comment 174 by bugdroid1@chromium.org, Apr 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93ca4d5f576787997917557eb88e77b452d15425

commit 93ca4d5f576787997917557eb88e77b452d15425
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Apr 07 10:26:48 2017

[ObjC ARC] Converts ios/chrome/browser/ui:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2802703002
Cr-Commit-Position: refs/heads/master@{#462829}

[modify] https://crrev.com/93ca4d5f576787997917557eb88e77b452d15425/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/93ca4d5f576787997917557eb88e77b452d15425/ios/chrome/browser/ui/browser_view_controller_testing.mm

Project Member Comment 175 by bugdroid1@chromium.org, Apr 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e757b63aa11bc5c4c3c30019c70e285d1266c9c2

commit e757b63aa11bc5c4c3c30019c70e285d1266c9c2
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Apr 10 12:31:27 2017

[ObjC ARC] Converts ios/chrome/browser/ui:ui_internal_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * This temporarily splits ui_internal into two targets to simplify review. The targets
are merged in a dependent CL.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2804703002
Cr-Commit-Position: refs/heads/master@{#463232}

[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/chrome_web_view_factory.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/external_file_controller.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/external_file_remover.h
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/external_file_remover.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/fade_truncated_label.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/fullscreen_controller.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/open_in_controller.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/open_in_toolbar.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/page_not_available_controller.h
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/page_not_available_controller.mm
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/preload_controller.h
[modify] https://crrev.com/e757b63aa11bc5c4c3c30019c70e285d1266c9c2/ios/chrome/browser/ui/preload_controller.mm

Project Member Comment 176 by bugdroid1@chromium.org, Apr 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b32bd33d9cc8fe5878699aec420309bdabaaec7e

commit b32bd33d9cc8fe5878699aec420309bdabaaec7e
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Apr 10 12:44:39 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/user_feedback:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2665353003
Cr-Commit-Position: refs/heads/master@{#463234}

[modify] https://crrev.com/b32bd33d9cc8fe5878699aec420309bdabaaec7e/ios/public/provider/chrome/browser/user_feedback/BUILD.gn
[modify] https://crrev.com/b32bd33d9cc8fe5878699aec420309bdabaaec7e/ios/public/provider/chrome/browser/user_feedback/test_user_feedback_provider.mm

Project Member Comment 179 by bugdroid1@chromium.org, Apr 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04e213a50baca2a83cb6f05fa30f57cce45818a2

commit 04e213a50baca2a83cb6f05fa30f57cce45818a2
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Apr 11 17:12:26 2017

[ObjC ARC] Converts ios/chrome/browser/ui/qr_scanner:qr_scanner to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2669143003
Cr-Commit-Position: refs/heads/master@{#463664}

[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/camera_controller.mm
[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/qr_scanner_alerts.mm
[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/qr_scanner_transitioning_delegate.mm
[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.h
[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm
[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller.h
[modify] https://crrev.com/04e213a50baca2a83cb6f05fa30f57cce45818a2/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller.mm

Project Member Comment 181 by bugdroid1@chromium.org, Apr 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/996f406fabe039d6f6f44528b63e5e90b38d22cc

commit 996f406fabe039d6f6f44528b63e5e90b38d22cc
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Apr 12 14:11:50 2017

[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* added autorelease pools in tests related to SettingsNavigationControllerTest to fix
 memory issues, specifically early deallocation of SigninManager where the observers
 (SigninObserverBridge of SettingsCollectionViewController) stored in WeakNSObject
 are not deallocated yet (in autorelease pool)
* Removes NS_RETURNS_RETAINED from a method that doesn't really need it

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2806323003
Cr-Commit-Position: refs/heads/master@{#464013}

[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/payments/credit_card_edit_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/payments/payment_items_display_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/payments/payment_method_selection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/payments/payment_request_error_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/payments/payment_request_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/payments/shipping_address_selection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/payments/shipping_option_selection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/collection_view/collection_view_controller_test.h
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/collection_view/collection_view_controller_test.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/autofill_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/block_popups_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/contextual_search_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/do_not_track_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/import_data_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/native_apps_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/physical_web_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/privacy_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/settings_navigation_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/settings_root_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/translate_collection_view_controller_unittest.mm
[modify] https://crrev.com/996f406fabe039d6f6f44528b63e5e90b38d22cc/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm

Project Member Comment 182 by bugdroid1@chromium.org, Apr 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c4eb23fd50e9e5199e8ab0fab8f652b69e277e

commit 65c4eb23fd50e9e5199e8ab0fab8f652b69e277e
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Apr 12 16:35:29 2017

[ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2676653003
Cr-Commit-Position: refs/heads/master@{#464053}

[modify] https://crrev.com/65c4eb23fd50e9e5199e8ab0fab8f652b69e277e/ios/chrome/browser/ui/downloads/BUILD.gn
[modify] https://crrev.com/65c4eb23fd50e9e5199e8ab0fab8f652b69e277e/ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm

Project Member Comment 183 by bugdroid1@chromium.org, Apr 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa0789757799f125a2c12d474b9f7cd6b0f73c8

commit caa0789757799f125a2c12d474b9f7cd6b0f73c8
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Apr 13 15:28:16 2017

[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2815513008
Cr-Commit-Position: refs/heads/master@{#464414}

[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/bar_button_activity_indicator.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
[modify] https://crrev.com/caa0789757799f125a2c12d474b9f7cd6b0f73c8/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

Project Member Comment 184 by bugdroid1@chromium.org, Apr 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a19562cbe74df0ff0ca935a9c5025617df8e33a4

commit a19562cbe74df0ff0ca935a9c5025617df8e33a4
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Apr 13 17:44:03 2017

[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc_transition to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2814813003
Cr-Commit-Position: refs/heads/master@{#464459}

[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/contextual_search_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/native_apps_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
[modify] https://crrev.com/a19562cbe74df0ff0ca935a9c5025617df8e33a4/ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm

Components: Infra>Client>ARC
Project Member Comment 186 by bugdroid1@chromium.org, Apr 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a388ddbe07f55e1c78816a0e9d42a8b55e058d37

commit a388ddbe07f55e1c78816a0e9d42a8b55e058d37
Author: gambard <gambard@chromium.org>
Date: Tue Apr 18 09:35:15 2017

[ObjC ARC] Converts ios/chrome/browser/ui/colors:colors to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2820323002
Cr-Commit-Position: refs/heads/master@{#465188}

[modify] https://crrev.com/a388ddbe07f55e1c78816a0e9d42a8b55e058d37/ios/chrome/browser/ui/colors/BUILD.gn
[modify] https://crrev.com/a388ddbe07f55e1c78816a0e9d42a8b55e058d37/ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.mm

Project Member Comment 187 by bugdroid1@chromium.org, Apr 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de4a87daad5ec01ffd65e353f47b5c3e7e44c11

commit 7de4a87daad5ec01ffd65e353f47b5c3e7e44c11
Author: gambard <gambard@chromium.org>
Date: Tue Apr 18 12:41:05 2017

[ObjC ARC] Converts components/favicon/ios:ios to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2823953003
Cr-Commit-Position: refs/heads/master@{#465208}

[modify] https://crrev.com/7de4a87daad5ec01ffd65e353f47b5c3e7e44c11/components/favicon/ios/BUILD.gn
[modify] https://crrev.com/7de4a87daad5ec01ffd65e353f47b5c3e7e44c11/components/favicon/ios/web_favicon_driver.mm

Project Member Comment 188 by bugdroid1@chromium.org, Apr 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7affbfc7f68bd3d39cdc111f70779cccdb750689

commit 7affbfc7f68bd3d39cdc111f70779cccdb750689
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Apr 18 13:32:47 2017

Reland of [ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC.

Notable changes:
* modifies a unit test to not fail with ARC.
* original CL https://codereview.chromium.org/2626073003

BUG=624363

Review-Url: https://codereview.chromium.org/2824493002
Cr-Commit-Position: refs/heads/master@{#465213}

[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/BUILD.gn
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_controller.h
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_header_view.h
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_header_view.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_highlighter_view.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_mask_view.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_metrics.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_promo_view.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_results_view.h
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/js_contextual_search_manager.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/panel_configuration.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.h
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator_unittest.mm
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/window_gesture_observer.h
[modify] https://crrev.com/7affbfc7f68bd3d39cdc111f70779cccdb750689/ios/chrome/browser/ui/contextual_search/window_gesture_observer.mm

Project Member Comment 190 by bugdroid1@chromium.org, Apr 19
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f851d02ff8f6825b592fc8f980cd48b640e10f4

commit 1f851d02ff8f6825b592fc8f980cd48b640e10f4
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Apr 19 13:28:30 2017

[ObjC ARC] Converts ios/chrome/browser/ui/side_swipe:side_swipe to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2827643002
Cr-Commit-Position: refs/heads/master@{#465577}

[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/BUILD.gn
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.h
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/history_side_swipe_provider.mm
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/side_swipe_controller.h
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.h
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm
[modify] https://crrev.com/1f851d02ff8f6825b592fc8f980cd48b640e10f4/ios/chrome/browser/ui/side_swipe/side_swipe_util.mm

Components: -Infra>Client>ARC Internals
Project Member Comment 192 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709926262c235d357de56e60c4e5be8a64996046

commit 709926262c235d357de56e60c4e5be8a64996046
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 06:46:28 2017

[ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:alert_coordinator_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2825023002
Cr-Commit-Position: refs/heads/master@{#465921}

[modify] https://crrev.com/709926262c235d357de56e60c4e5be8a64996046/ios/chrome/browser/ui/alert_coordinator/BUILD.gn
[modify] https://crrev.com/709926262c235d357de56e60c4e5be8a64996046/ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm

Project Member Comment 193 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68532f4b0711fed5763d9bce4e84f304f9207175

commit 68532f4b0711fed5763d9bce4e84f304f9207175
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 06:47:04 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/distribution:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2832493003
Cr-Commit-Position: refs/heads/master@{#465922}

[modify] https://crrev.com/68532f4b0711fed5763d9bce4e84f304f9207175/ios/public/provider/chrome/browser/distribution/BUILD.gn
[modify] https://crrev.com/68532f4b0711fed5763d9bce4e84f304f9207175/ios/public/provider/chrome/browser/distribution/test_app_distribution_provider.mm

Project Member Comment 194 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a33bf9e1f2b315799a05aa8fbf8a736f1ceb7d10

commit a33bf9e1f2b315799a05aa8fbf8a736f1ceb7d10
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 06:48:11 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/images:images to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2831633002
Cr-Commit-Position: refs/heads/master@{#465923}

[modify] https://crrev.com/a33bf9e1f2b315799a05aa8fbf8a736f1ceb7d10/ios/public/provider/chrome/browser/images/BUILD.gn
[modify] https://crrev.com/a33bf9e1f2b315799a05aa8fbf8a736f1ceb7d10/ios/public/provider/chrome/browser/images/branded_image_provider.mm

Project Member Comment 195 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b68896e78ef68ba075d12a87a1683da7e28d111

commit 2b68896e78ef68ba075d12a87a1683da7e28d111
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 06:48:57 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/omaha:omaha to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2832533002
Cr-Commit-Position: refs/heads/master@{#465924}

[modify] https://crrev.com/2b68896e78ef68ba075d12a87a1683da7e28d111/ios/public/provider/chrome/browser/omaha/BUILD.gn
[modify] https://crrev.com/2b68896e78ef68ba075d12a87a1683da7e28d111/ios/public/provider/chrome/browser/omaha/omaha_service_provider.mm

Project Member Comment 196 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15bf5d607901aad1083d9906402de007c0a273fc

commit 15bf5d607901aad1083d9906402de007c0a273fc
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 06:49:42 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/distribution:distribution to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2828003002
Cr-Commit-Position: refs/heads/master@{#465925}

[modify] https://crrev.com/15bf5d607901aad1083d9906402de007c0a273fc/ios/public/provider/chrome/browser/distribution/BUILD.gn
[modify] https://crrev.com/15bf5d607901aad1083d9906402de007c0a273fc/ios/public/provider/chrome/browser/distribution/app_distribution_provider.mm

Project Member Comment 197 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee4ca852c987cd0412ad9934946c34e9b4eeee3b

commit ee4ca852c987cd0412ad9934946c34e9b4eeee3b
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 06:50:25 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/omaha:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2830713002
Cr-Commit-Position: refs/heads/master@{#465926}

[modify] https://crrev.com/ee4ca852c987cd0412ad9934946c34e9b4eeee3b/ios/public/provider/chrome/browser/omaha/BUILD.gn
[modify] https://crrev.com/ee4ca852c987cd0412ad9934946c34e9b4eeee3b/ios/public/provider/chrome/browser/omaha/test_omaha_service_provider.mm

Project Member Comment 198 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c25d22f9c1cdf3997e9c5f6209ed018888c74797

commit c25d22f9c1cdf3997e9c5f6209ed018888c74797
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 06:51:10 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/images:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2832543002
Cr-Commit-Position: refs/heads/master@{#465927}

[modify] https://crrev.com/c25d22f9c1cdf3997e9c5f6209ed018888c74797/ios/public/provider/chrome/browser/images/BUILD.gn
[modify] https://crrev.com/c25d22f9c1cdf3997e9c5f6209ed018888c74797/ios/public/provider/chrome/browser/images/test_branded_image_provider.mm

Project Member Comment 199 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa89ede3945ca91f2c12500c213a4d08f8b29886

commit aa89ede3945ca91f2c12500c213a4d08f8b29886
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 11:15:52 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:utils to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2826413002
Cr-Commit-Position: refs/heads/master@{#465971}

[modify] https://crrev.com/aa89ede3945ca91f2c12500c213a4d08f8b29886/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/aa89ede3945ca91f2c12500c213a4d08f8b29886/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm

Project Member Comment 200 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc26e6771b4370bbc37fc6450fc97eb9c78daa62

commit dc26e6771b4370bbc37fc6450fc97eb9c78daa62
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 12:43:14 2017

[ObjC ARC] Converts ios/chrome/browser/ui/settings:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2831053003
Cr-Commit-Position: refs/heads/master@{#465984}

[modify] https://crrev.com/dc26e6771b4370bbc37fc6450fc97eb9c78daa62/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/dc26e6771b4370bbc37fc6450fc97eb9c78daa62/ios/chrome/browser/ui/settings/passphrase_collection_view_controller_test.mm

Project Member Comment 201 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a47740436146174ce74fca4fcbcf9b2b92c8e355

commit a47740436146174ce74fca4fcbcf9b2b92c8e355
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 12:45:46 2017

[ObjC ARC] Converts ios/chrome/browser/ui/side_swipe:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2827963005
Cr-Commit-Position: refs/heads/master@{#465985}

[modify] https://crrev.com/a47740436146174ce74fca4fcbcf9b2b92c8e355/ios/chrome/browser/ui/side_swipe/BUILD.gn
[modify] https://crrev.com/a47740436146174ce74fca4fcbcf9b2b92c8e355/ios/chrome/browser/ui/side_swipe/side_swipe_controller_unittest.mm

Project Member Comment 202 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45d637552defb050205b9a1301b6c540a39dda0c

commit 45d637552defb050205b9a1301b6c540a39dda0c
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 13:25:32 2017

[ObjC ARC] Converts ios/chrome/browser/ui/settings/utils:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2834623002
Cr-Commit-Position: refs/heads/master@{#465990}

[modify] https://crrev.com/45d637552defb050205b9a1301b6c540a39dda0c/ios/chrome/browser/ui/settings/utils/BUILD.gn
[modify] https://crrev.com/45d637552defb050205b9a1301b6c540a39dda0c/ios/chrome/browser/ui/settings/utils/fake_observable_boolean.mm

Project Member Comment 203 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e55a9eeab3362f2c90b63df1ecc74a3c2059ff3

commit 4e55a9eeab3362f2c90b63df1ecc74a3c2059ff3
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 14:06:28 2017

[ObjC ARC] Converts ios/chrome/browser/ui/promos:promos to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2827263003
Cr-Commit-Position: refs/heads/master@{#465995}

[modify] https://crrev.com/4e55a9eeab3362f2c90b63df1ecc74a3c2059ff3/ios/chrome/browser/ui/promos/BUILD.gn
[modify] https://crrev.com/4e55a9eeab3362f2c90b63df1ecc74a3c2059ff3/ios/chrome/browser/ui/promos/signin_promo_view_controller.mm

Project Member Comment 204 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4da3e35ba0d85a1130dac12acbb699ba0afb63e6

commit 4da3e35ba0d85a1130dac12acbb699ba0afb63e6
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 14:13:49 2017

[ObjC ARC] Converts ios/chrome/browser/ui/infobars:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2826083003
Cr-Commit-Position: refs/heads/master@{#465998}

[modify] https://crrev.com/4da3e35ba0d85a1130dac12acbb699ba0afb63e6/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/4da3e35ba0d85a1130dac12acbb699ba0afb63e6/ios/chrome/browser/ui/infobars/infobar_view_unittest.mm

Project Member Comment 205 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975b115ff82c6d407cd346afb4d4838f5d380eab

commit 975b115ff82c6d407cd346afb4d4838f5d380eab
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 14:41:38 2017

[ObjC ARC] Converts ios/chrome/browser/ui/print:print to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2828283002
Cr-Commit-Position: refs/heads/master@{#466005}

[modify] https://crrev.com/975b115ff82c6d407cd346afb4d4838f5d380eab/ios/chrome/browser/ui/print/BUILD.gn
[modify] https://crrev.com/975b115ff82c6d407cd346afb4d4838f5d380eab/ios/chrome/browser/ui/print/print_controller.mm

Project Member Comment 206 by bugdroid1@chromium.org, Apr 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3194254dc652c6ca45f7f7b11685ccd03252ea6b

commit 3194254dc652c6ca45f7f7b11685ccd03252ea6b
Author: gambard <gambard@chromium.org>
Date: Thu Apr 20 17:15:14 2017

[ObjC ARC] Converts ios/chrome/browser/ui/icons:icons to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2830033004
Cr-Commit-Position: refs/heads/master@{#466037}

[modify] https://crrev.com/3194254dc652c6ca45f7f7b11685ccd03252ea6b/ios/chrome/browser/ui/icons/BUILD.gn
[modify] https://crrev.com/3194254dc652c6ca45f7f7b11685ccd03252ea6b/ios/chrome/browser/ui/icons/chrome_icon.mm

Project Member Comment 207 by bugdroid1@chromium.org, Apr 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbdc3a57db54f6c15e343173885ba78b49b60730

commit bbdc3a57db54f6c15e343173885ba78b49b60730
Author: gambard <gambard@chromium.org>
Date: Fri Apr 21 07:05:29 2017

[ObjC ARC] Converts ios/chrome/browser/web:web_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2823953004
Cr-Commit-Position: refs/heads/master@{#466277}

[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/auto_reload_bridge.mm
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/auto_reload_controller.mm
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/blocked_popup_tab_helper.mm
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/chrome_web_client.mm
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/error_page_content.mm
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/error_page_generator.mm
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/external_app_launcher.mm
[modify] https://crrev.com/bbdc3a57db54f6c15e343173885ba78b49b60730/ios/chrome/browser/web/print_observer.mm

Project Member Comment 208 by bugdroid1@chromium.org, Apr 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bffdac48c4e7381755e0a09ef5f431e80c432b1b

commit bffdac48c4e7381755e0a09ef5f431e80c432b1b
Author: gambard <gambard@chromium.org>
Date: Fri Apr 21 07:06:22 2017

[ObjC ARC] Converts ios/chrome/browser/ui/webui:webui_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2829753004
Cr-Commit-Position: refs/heads/master@{#466278}

[modify] https://crrev.com/bffdac48c4e7381755e0a09ef5f431e80c432b1b/ios/chrome/browser/ui/webui/BUILD.gn
[modify] https://crrev.com/bffdac48c4e7381755e0a09ef5f431e80c432b1b/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm

Project Member Comment 209 by bugdroid1@chromium.org, Apr 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76b5917e530fcb4d728dff53ae925e01c815cdb

commit f76b5917e530fcb4d728dff53ae925e01c815cdb
Author: gambard <gambard@chromium.org>
Date: Fri Apr 21 10:47:10 2017

[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2831113003
Cr-Commit-Position: refs/heads/master@{#466306}

[modify] https://crrev.com/f76b5917e530fcb4d728dff53ae925e01c815cdb/ios/chrome/browser/ui/contextual_search/BUILD.gn
[modify] https://crrev.com/f76b5917e530fcb4d728dff53ae925e01c815cdb/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator+testing.mm

Project Member Comment 210 by bugdroid1@chromium.org, Apr 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bedb9d4efb97106bed60b6db89b675928d1d6850

commit bedb9d4efb97106bed60b6db89b675928d1d6850
Author: gambard <gambard@chromium.org>
Date: Fri Apr 21 16:06:55 2017

[ObjC ARC] Converts ios/chrome/browser/ui/infobars:infobars to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2831213005
Cr-Commit-Position: refs/heads/master@{#466353}

[modify] https://crrev.com/bedb9d4efb97106bed60b6db89b675928d1d6850/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/bedb9d4efb97106bed60b6db89b675928d1d6850/ios/chrome/browser/ui/infobars/infobar_view.h
[modify] https://crrev.com/bedb9d4efb97106bed60b6db89b675928d1d6850/ios/chrome/browser/ui/infobars/infobar_view.mm

Project Member Comment 211 by bugdroid1@chromium.org, Apr 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfbf87d97979e6a32080320bd5ade308b7a1844a

commit bfbf87d97979e6a32080320bd5ade308b7a1844a
Author: gambard <gambard@chromium.org>
Date: Tue Apr 25 12:49:35 2017

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2826073003
Cr-Commit-Position: refs/heads/master@{#466957}

[modify] https://crrev.com/bfbf87d97979e6a32080320bd5ade308b7a1844a/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/bfbf87d97979e6a32080320bd5ade308b7a1844a/ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm

Project Member Comment 212 by bugdroid1@chromium.org, Apr 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7397a48a29569458940d1b5f8b44fbf776b4efa

commit d7397a48a29569458940d1b5f8b44fbf776b4efa
Author: gambard <gambard@chromium.org>
Date: Thu Apr 27 15:17:20 2017

[ObjC ARC] Converts ios/chrome/browser/ui/downloads:downloads to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2835643002
Cr-Commit-Position: refs/heads/master@{#467682}

[modify] https://crrev.com/d7397a48a29569458940d1b5f8b44fbf776b4efa/ios/chrome/browser/ui/downloads/BUILD.gn
[modify] https://crrev.com/d7397a48a29569458940d1b5f8b44fbf776b4efa/ios/chrome/browser/ui/downloads/download_manager_controller.mm

Project Member Comment 215 by bugdroid1@chromium.org, Apr 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f67705094cf459bb5eda915a47bc2780cc22868

commit 8f67705094cf459bb5eda915a47bc2780cc22868
Author: gambard <gambard@chromium.org>
Date: Fri Apr 28 09:59:34 2017

[ObjC ARC] Converts ios/chrome/browser/ui/util:util to ARC.

Automatically generated ARCMigrate commit
Notable issues:static_cast changed to __bridge cast.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2819283004
Cr-Commit-Position: refs/heads/master@{#467946}

[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/BUILD.gn
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/CRUILabel+AttributeUtils.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/core_text_util.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/i18n_string.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/label_link_controller.h
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/label_link_controller.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/label_observer.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/manual_text_framer.h
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/manual_text_framer.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/pasteboard_util.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/snapshot_util.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/text_frame.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/text_region_mapper.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/top_view_controller.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/transparent_link_button.mm
[modify] https://crrev.com/8f67705094cf459bb5eda915a47bc2780cc22868/ios/chrome/browser/ui/util/unicode_util.mm

Project Member Comment 216 by bugdroid1@chromium.org, Apr 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b

commit 8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b
Author: olivierrobin <olivierrobin@chromium.org>
Date: Fri Apr 28 10:12:53 2017

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2808873002
Cr-Commit-Position: refs/heads/master@{#467947}

[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/BUILD.gn
[add] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/DEPS
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/new_tab_button.mm
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/toolbar_button_tints.mm
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.mm
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member Comment 217 by bugdroid1@chromium.org, Apr 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42dd78c534edf6e6f7318c37dcd64f5b06709f30

commit 42dd78c534edf6e6f7318c37dcd64f5b06709f30
Author: sczs <sczs@chromium.org>
Date: Fri Apr 28 13:36:00 2017

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2808873002/ )

Reason for revert:
Reverting since ios_chrome_smoke_egtests its failing and it broke the autoroller.

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/chromium-autoroller/builds/373/steps/ios_chrome_smoke_egtests%20%28iPhone%205s%20iOS%2010.0%29/logs/stdio

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2808873002
> Cr-Commit-Position: refs/heads/master@{#467947}
> Committed: https://chromium.googlesource.com/chromium/src/+/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b

TBR=stkhapugin@chromium.org,sdefresne@chromium.org,gambard@chromium.org,olivierrobin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2852713002
Cr-Commit-Position: refs/heads/master@{#467981}

[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/BUILD.gn
[delete] https://crrev.com/394a4f2f148ad91c04bacb5df265248898844a3b/ios/chrome/browser/ui/toolbar/DEPS
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/new_tab_button.mm
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/toolbar_button_tints.mm
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.mm
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/42dd78c534edf6e6f7318c37dcd64f5b06709f30/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member Comment 218 by bugdroid1@chromium.org, Apr 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc2e2e83c42d118bdf3dfbd0afde6114205b9874

commit fc2e2e83c42d118bdf3dfbd0afde6114205b9874
Author: gambard <gambard@chromium.org>
Date: Fri Apr 28 20:53:31 2017

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:perf_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2827253003
Cr-Commit-Position: refs/heads/master@{#468124}

[modify] https://crrev.com/fc2e2e83c42d118bdf3dfbd0afde6114205b9874/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/fc2e2e83c42d118bdf3dfbd0afde6114205b9874/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm

Project Member Comment 219 by bugdroid1@chromium.org, May 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba4d7df1bcc063577dc66378f7465120fce5468a

commit ba4d7df1bcc063577dc66378f7465120fce5468a
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue May 02 14:59:39 2017

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2810193004
Cr-Commit-Position: refs/heads/master@{#468634}

[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/card_set.h
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/card_set.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/card_stack_layout_manager.h
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/card_stack_layout_manager.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/card_stack_pinch_gesture_recognizer.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/card_view.h
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/card_view.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/close_button.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/page_animation_util.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/stack_card.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/stack_view_controller.h
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/ba4d7df1bcc063577dc66378f7465120fce5468a/ios/chrome/browser/ui/stack_view/title_label.mm

Project Member Comment 220 by bugdroid1@chromium.org, May 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8824f0e53e5b5baf3284d3a9e80855bcdacfa2e0

commit 8824f0e53e5b5baf3284d3a9e80855bcdacfa2e0
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue May 02 15:34:10 2017

[ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2847963002
Cr-Commit-Position: refs/heads/master@{#468643}

[modify] https://crrev.com/8824f0e53e5b5baf3284d3a9e80855bcdacfa2e0/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/8824f0e53e5b5baf3284d3a9e80855bcdacfa2e0/ios/chrome/browser/prefs/pref_observer_bridge.h
[modify] https://crrev.com/8824f0e53e5b5baf3284d3a9e80855bcdacfa2e0/ios/chrome/browser/prefs/pref_observer_bridge.mm

Project Member Comment 221 by bugdroid1@chromium.org, May 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d30c08f5979bb312459afee2871e74a5b43d094

commit 9d30c08f5979bb312459afee2871e74a5b43d094
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue May 02 16:00:28 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Replaced 2 instances of replaceOldTabModel:(TabModel**)oldTabModel withTabModel:(TabModel*)newTabModel method with an equivalent construct that does not pass pointers to pointers to objc objects. Feel free to suggest a better way that I can implement in a follow-up CL.
* some weak pointer dereferencing replaced with strong pointer dereferencing in blocks
* In tab_model_snapshot.mm, added a bridge cast. I'm not sure if this should be a conversion to std::string, because std::stringstream.operator<<(NSString*) can be both.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2810193002
Cr-Commit-Position: refs/heads/master@{#468652}

[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_model_snapshot.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_button.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_cache.h
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_cache.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_header_cell.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_header_view.h
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_header_view.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_collection_view_layout.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.h
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_view.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_session_changes.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_tab_strip_placeholder_view.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_view.h
[modify] https://crrev.com/9d30c08f5979bb312459afee2871e74a5b43d094/ios/chrome/browser/ui/tab_switcher/tab_switcher_view.mm

Project Member Comment 223 by bugdroid1@chromium.org, May 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740ceaa120d7b3d03450bb801e59208a2a645cad

commit 740ceaa120d7b3d03450bb801e59208a2a645cad
Author: michaeldo <michaeldo@chromium.org>
Date: Tue May 02 16:16:37 2017

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2810193004/ )

Reason for revert:
Causes crashes of ios_chrome_integration_egtests, ios_chrome_settings_egtests, and ios_chrome_ui_egtests test suites. Ref: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/27109

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2810193004
> Cr-Commit-Position: refs/heads/master@{#468634}
> Committed: https://chromium.googlesource.com/chromium/src/+/ba4d7df1bcc063577dc66378f7465120fce5468a

TBR=marq@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2859503002
Cr-Commit-Position: refs/heads/master@{#468664}

[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/card_set.h
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/card_set.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/card_stack_layout_manager.h
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/card_stack_layout_manager.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/card_stack_pinch_gesture_recognizer.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/card_view.h
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/card_view.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/close_button.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/page_animation_util.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/stack_card.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/stack_view_controller.h
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/740ceaa120d7b3d03450bb801e59208a2a645cad/ios/chrome/browser/ui/stack_view/title_label.mm

Project Member Comment 225 by bugdroid1@chromium.org, May 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5815c61aa07c697f16cd03a9affb47952314e000

commit 5815c61aa07c697f16cd03a9affb47952314e000
Author: gambard <gambard@chromium.org>
Date: Tue May 02 16:37:46 2017

[ObjC ARC] Converts components/autofill/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2849533003
Cr-Commit-Position: refs/heads/master@{#468677}

[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/BUILD.gn
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/autofill_driver_ios.h
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/autofill_driver_ios.mm
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/credit_card_util.mm
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/form_suggestion.mm
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/js_autofill_manager.mm
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/js_suggestion_manager.mm
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/personal_data_manager_observer_bridge.h
[modify] https://crrev.com/5815c61aa07c697f16cd03a9affb47952314e000/components/autofill/ios/browser/personal_data_manager_observer_bridge.mm

Project Member Comment 227 by bugdroid1@chromium.org, May 3
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aa19d360acef358288a23b8e9b69d1292bafc0a

commit 5aa19d360acef358288a23b8e9b69d1292bafc0a
Author: gambard <gambard@chromium.org>
Date: Wed May 03 15:21:43 2017

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.

Reland of https://codereview.chromium.org/2808873002/

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2851303006
Cr-Commit-Position: refs/heads/master@{#468976}

[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/BUILD.gn
[add] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/DEPS
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/new_tab_button.mm
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/toolbar_button_tints.mm
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.mm
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/5aa19d360acef358288a23b8e9b69d1292bafc0a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member Comment 229 by bugdroid1@chromium.org, May 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/680ec74a33fcffefd0b1ed6a39686bc8451d80ab

commit 680ec74a33fcffefd0b1ed6a39686bc8451d80ab
Author: baxley <baxley@chromium.org>
Date: Mon May 15 23:52:06 2017

[ObjC ARC] Converts ios/chrome/browser/net:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363, 690057
TEST=None

Review-Url: https://codereview.chromium.org/2884043002
Cr-Commit-Position: refs/heads/master@{#471949}

[modify] https://crrev.com/680ec74a33fcffefd0b1ed6a39686bc8451d80ab/ios/chrome/browser/net/BUILD.gn
[modify] https://crrev.com/680ec74a33fcffefd0b1ed6a39686bc8451d80ab/ios/chrome/browser/net/cookies_egtest.mm

Project Member Comment 230 by bugdroid1@chromium.org, May 16
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1918812f554cb98a80103562674f5b5b569648db

commit 1918812f554cb98a80103562674f5b5b569648db
Author: baxley <baxley@chromium.org>
Date: Tue May 16 16:05:54 2017

[ObjC ARC] Converts ios/chrome/browser/translate:external_url_eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2884073002
Cr-Commit-Position: refs/heads/master@{#472121}

[modify] https://crrev.com/1918812f554cb98a80103562674f5b5b569648db/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/1918812f554cb98a80103562674f5b5b569648db/ios/chrome/browser/translate/translate_egtest.mm

Project Member Comment 231 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29c52e534042bff7e45c4a2784d7f4922885b12a

commit 29c52e534042bff7e45c4a2784d7f4922885b12a
Author: baxley <baxley@chromium.org>
Date: Wed May 17 04:13:49 2017

[ObjC ARC] Converts ios/chrome/browser/autofill:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2884723002
Cr-Commit-Position: refs/heads/master@{#472318}

[modify] https://crrev.com/29c52e534042bff7e45c4a2784d7f4922885b12a/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/29c52e534042bff7e45c4a2784d7f4922885b12a/ios/chrome/browser/autofill/form_input_egtest.mm

Project Member Comment 232 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/659885eebc27bf7a49b806d2f8b104b547b36605

commit 659885eebc27bf7a49b806d2f8b104b547b36605
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed May 17 11:52:53 2017

[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2813223002
Cr-Commit-Position: refs/heads/master@{#472426}

[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/reauthentication_module.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/settings_collection_view_controller.h
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/settings_utils.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm
[modify] https://crrev.com/659885eebc27bf7a49b806d2f8b104b547b36605/ios/chrome/test/earl_grey/BUILD.gn

Project Member Comment 233 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8677520a8befbd56e37e6a864ec395eb9146f540

commit 8677520a8befbd56e37e6a864ec395eb9146f540
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 12:39:21 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_device_check_egtests to ARC.

The automatic arc script doesn't work for this target because it simply
adds configs += [ "//build/config/compiler:enable_arc" ] to
chrome_ios_eg_test("ios_chrome_device_check_egtests"), however, the
body of a  template invocation doesn't take configs.

This CL manually moves "device_check_egtest.mm" to a separate
source_set and adds configs += [ "//build/config/compiler:enable_arc" ]
to that source_set.

Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2882253002
Cr-Commit-Position: refs/heads/master@{#472430}

[modify] https://crrev.com/8677520a8befbd56e37e6a864ec395eb9146f540/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/8677520a8befbd56e37e6a864ec395eb9146f540/ios/chrome/test/earl_grey/chrome_ios_eg_test.gni
[modify] https://crrev.com/8677520a8befbd56e37e6a864ec395eb9146f540/ios/chrome/test/earl_grey/device_check_egtest.mm

Project Member Comment 234 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d45a3eaaabb9a4ee55fffb80430116bd8271b75

commit 0d45a3eaaabb9a4ee55fffb80430116bd8271b75
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 16:25:11 2017

[ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2887563002
Cr-Commit-Position: refs/heads/master@{#472471}

[modify] https://crrev.com/0d45a3eaaabb9a4ee55fffb80430116bd8271b75/ios/chrome/test/base/BUILD.gn
[modify] https://crrev.com/0d45a3eaaabb9a4ee55fffb80430116bd8271b75/ios/chrome/test/base/scoped_block_swizzler_unittest.mm

Project Member Comment 235 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/108d7013f655111f9e528bd8b8161ee58a54914f

commit 108d7013f655111f9e528bd8b8161ee58a54914f
Author: baxley <baxley@chromium.org>
Date: Wed May 17 19:01:15 2017

[ObjC ARC] Converts ios/chrome/browser/web:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2890003002
Cr-Commit-Position: refs/heads/master@{#472517}

[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/browsing_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/browsing_prevent_default_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/child_window_open_by_dom_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/forms_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/http_auth_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/js_print_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/navigation_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/progress_indicator_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/stop_loading_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/window_open_by_dom_egtest.mm

Project Member Comment 236 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0182ad5525a53fbd14266e3f044ad32bddc6faa0

commit 0182ad5525a53fbd14266e3f044ad32bddc6faa0
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 19:44:01 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:hooks to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2885453004
Cr-Commit-Position: refs/heads/master@{#472538}

[modify] https://crrev.com/0182ad5525a53fbd14266e3f044ad32bddc6faa0/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/0182ad5525a53fbd14266e3f044ad32bddc6faa0/ios/chrome/test/earl_grey/eg_tests_hook.mm

Project Member Comment 237 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45371c8b1e01bac440bc20f29782ceec2580bbc7

commit 45371c8b1e01bac440bc20f29782ceec2580bbc7
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 20:15:43 2017

[ObjC ARC] Converts ios/chrome/browser/web:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2879423002
Cr-Commit-Position: refs/heads/master@{#472545}

[modify] https://crrev.com/45371c8b1e01bac440bc20f29782ceec2580bbc7/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/45371c8b1e01bac440bc20f29782ceec2580bbc7/ios/chrome/browser/web/chrome_web_test.mm
[modify] https://crrev.com/45371c8b1e01bac440bc20f29782ceec2580bbc7/ios/chrome/browser/web/fake_mailto_handler_helpers.mm

Project Member Comment 238 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/110127094406d74519ddd40c92ec5bd0abeb5c1d

commit 110127094406d74519ddd40c92ec5bd0abeb5c1d
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 20:53:58 2017

[ObjC ARC] Converts ios/chrome/browser/web:perf_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2886843003
Cr-Commit-Position: refs/heads/master@{#472559}

[modify] https://crrev.com/110127094406d74519ddd40c92ec5bd0abeb5c1d/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/110127094406d74519ddd40c92ec5bd0abeb5c1d/ios/chrome/browser/web/early_page_script_perftest.mm

Project Member Comment 240 by bugdroid1@chromium.org, May 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5222823cb86a00c1fcf5c90f0e08cd52367505

commit 6c5222823cb86a00c1fcf5c90f0e08cd52367505
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu May 18 16:25:47 2017

[ObjC ARC] Converts ios/chrome/test/base:perf_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2881273002
Cr-Commit-Position: refs/heads/master@{#472837}

[modify] https://crrev.com/6c5222823cb86a00c1fcf5c90f0e08cd52367505/ios/chrome/test/base/BUILD.gn
[modify] https://crrev.com/6c5222823cb86a00c1fcf5c90f0e08cd52367505/ios/chrome/test/base/perf_test_ios.mm

Project Member Comment 241 by bugdroid1@chromium.org, May 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b6ee089c18c84e6dbd51d6ce04634b7103e3da

commit 07b6ee089c18c84e6dbd51d6ce04634b7103e3da
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu May 18 19:25:41 2017

[ObjC ARC] Converts ios/chrome/test/base:base to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2882113004
Cr-Commit-Position: refs/heads/master@{#472899}

[modify] https://crrev.com/07b6ee089c18c84e6dbd51d6ce04634b7103e3da/ios/chrome/test/base/BUILD.gn
[modify] https://crrev.com/07b6ee089c18c84e6dbd51d6ce04634b7103e3da/ios/chrome/test/base/scoped_block_swizzler.mm

Project Member Comment 242 by bugdroid1@chromium.org, May 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f88f6d0e6225a933e189cf4c14f51084d889c6f1

commit f88f6d0e6225a933e189cf4c14f51084d889c6f1
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu May 18 21:21:25 2017

[ObjC ARC] Converts ios/chrome/app:tests_fake_hook to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2891853002
Cr-Commit-Position: refs/heads/master@{#472933}

[modify] https://crrev.com/f88f6d0e6225a933e189cf4c14f51084d889c6f1/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/f88f6d0e6225a933e189cf4c14f51084d889c6f1/ios/chrome/app/tests_fake_hook.mm

Project Member Comment 243 by bugdroid1@chromium.org, May 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a88dcd92b92ad194b1a61f371a26ae81fae65b

commit 73a88dcd92b92ad194b1a61f371a26ae81fae65b
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 13:12:56 2017

[ObjC ARC] Converts ios/chrome/browser:browser_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2885163004
Cr-Commit-Position: refs/heads/master@{#473563}

[modify] https://crrev.com/73a88dcd92b92ad194b1a61f371a26ae81fae65b/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/73a88dcd92b92ad194b1a61f371a26ae81fae65b/ios/chrome/browser/callback_counter.mm

Project Member Comment 244 by bugdroid1@chromium.org, May 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd

commit a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 13:34:36 2017

[ObjC ARC] Converts ios/chrome/browser/test:perf_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2889053002
Cr-Commit-Position: refs/heads/master@{#473569}

[modify] https://crrev.com/a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd/ios/chrome/browser/test/BUILD.gn
[modify] https://crrev.com/a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd/ios/chrome/browser/test/perf_test_with_bvc_ios.mm

Project Member Comment 245 by bugdroid1@chromium.org, May 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b623d39cafb4c268d02f1c1e3051a7c9553dd19

commit 9b623d39cafb4c268d02f1c1e3051a7c9553dd19
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 13:56:20 2017

[ObjC ARC] Converts ios/chrome/browser/browsing_data:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2889083002
Cr-Commit-Position: refs/heads/master@{#473571}

[modify] https://crrev.com/9b623d39cafb4c268d02f1c1e3051a7c9553dd19/ios/chrome/browser/browsing_data/BUILD.gn
[modify] https://crrev.com/9b623d39cafb4c268d02f1c1e3051a7c9553dd19/ios/chrome/browser/browsing_data/browsing_data_removal_controller_unittest.mm

Project Member Comment 246 by bugdroid1@chromium.org, May 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09f302179d78baa49db21cb906684c26467219c6

commit 09f302179d78baa49db21cb906684c26467219c6
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 16:38:34 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_smoke_egtests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2893763002
Cr-Commit-Position: refs/heads/master@{#473597}

[modify] https://crrev.com/09f302179d78baa49db21cb906684c26467219c6/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/09f302179d78baa49db21cb906684c26467219c6/ios/chrome/test/earl_grey/smoke_egtest.mm

Project Member Comment 247 by bugdroid1@chromium.org, May 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2705e6425ef090370a6bcd167045e56a22c3d3a

commit e2705e6425ef090370a6bcd167045e56a22c3d3a
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 17:00:20 2017

[ObjC ARC] Converts components/signin/ios/browser:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2890983002
Cr-Commit-Position: refs/heads/master@{#473602}

[modify] https://crrev.com/e2705e6425ef090370a6bcd167045e56a22c3d3a/components/signin/ios/browser/BUILD.gn
[modify] https://crrev.com/e2705e6425ef090370a6bcd167045e56a22c3d3a/components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.mm

Project Member Comment 249 by bugdroid1@chromium.org, May 29
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/515ce76a623d1521ded07bc95f4dde90486b2012

commit 515ce76a623d1521ded07bc95f4dde90486b2012
Author: lindsayw <lindsayw@chromium.org>
Date: Mon May 29 10:45:10 2017

[ObjC ARC] Converts ios/chrome/browser/metrics:unit_tests_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2894653002
Cr-Commit-Position: refs/heads/master@{#475331}

[modify] https://crrev.com/515ce76a623d1521ded07bc95f4dde90486b2012/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/515ce76a623d1521ded07bc95f4dde90486b2012/ios/chrome/browser/metrics/size_class_recorder_unittest.mm
[modify] https://crrev.com/515ce76a623d1521ded07bc95f4dde90486b2012/ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm

Project Member Comment 250 by bugdroid1@chromium.org, May 30
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4afbfe12c4c71827f0481d2dc8d37fdf49866502

commit 4afbfe12c4c71827f0481d2dc8d37fdf49866502
Author: liaoyuke <liaoyuke@chromium.org>
Date: Tue May 30 18:57:41 2017

[ObjC ARC] Converts ios/chrome/browser/translate:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2889043002
Cr-Commit-Position: refs/heads/master@{#475615}

[modify] https://crrev.com/4afbfe12c4c71827f0481d2dc8d37fdf49866502/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/4afbfe12c4c71827f0481d2dc8d37fdf49866502/ios/chrome/browser/translate/js_language_detection_manager_unittest.mm

Project Member Comment 258 by bugdroid1@chromium.org, Jun 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/198dcbc93706388bf415866519065dc316f261be

commit 198dcbc93706388bf415866519065dc316f261be
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Jun 02 15:07:49 2017

[ObjC ARC] Converts ios/chrome/browser/ui/history:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2650423002
Cr-Commit-Position: refs/heads/master@{#476653}

[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_entries_status_item_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_entry_item_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_search_view_controller_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_util_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/tab_history_popup_controller_unittest.mm

Project Member Comment 259 by bugdroid1@chromium.org, Jun 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6666e3d76a0f228dc3631411235c6e20adfdc37a

commit 6666e3d76a0f228dc3631411235c6e20adfdc37a
Author: baxley <baxley@chromium.org>
Date: Fri Jun 02 15:29:45 2017

[ObjC ARC] Converts ios/chrome/browser/ui/qr_scanner:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2880373002
Cr-Commit-Position: refs/heads/master@{#476665}

[modify] https://crrev.com/6666e3d76a0f228dc3631411235c6e20adfdc37a/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/6666e3d76a0f228dc3631411235c6e20adfdc37a/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm

Project Member Comment 264 by bugdroid1@chromium.org, Jun 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62751ceeb02adc855c96e93127c1bee6c6dc9c33

commit 62751ceeb02adc855c96e93127c1bee6c6dc9c33
Author: baxley <baxley@chromium.org>
Date: Tue Jun 06 17:28:35 2017

[ObjC ARC] Converts ios/web/public/test/fakes:fakes to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2922973004
Cr-Commit-Position: refs/heads/master@{#477325}

[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/BUILD.gn
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/crw_test_js_injection_receiver.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_java_script_dialog_presenter.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_java_script_dialog_presenter.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_native_content.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_native_content_provider.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_navigation_manager.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_client.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_client.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_delegate.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_delegate.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_observer.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_observer_util.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_view_content_view.mm

Project Member Comment 265 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/981b6a8a907ce40b46fbe76881a0f0394cc00d2b

commit 981b6a8a907ce40b46fbe76881a0f0394cc00d2b
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 07 00:12:25 2017

[ObjC ARC] Converts ios/chrome/browser/browsing_data:browsing_data_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2892663003
Cr-Commit-Position: refs/heads/master@{#477475}

[modify] https://crrev.com/981b6a8a907ce40b46fbe76881a0f0394cc00d2b/ios/chrome/browser/browsing_data/BUILD.gn
[modify] https://crrev.com/981b6a8a907ce40b46fbe76881a0f0394cc00d2b/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm

Project Member Comment 266 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd4f183e08c8bbcc95b65eee4b2949ac53b87679

commit bd4f183e08c8bbcc95b65eee4b2949ac53b87679
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 07 01:26:42 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_multitasking_egtests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2886303003
Cr-Commit-Position: refs/heads/master@{#477505}

[modify] https://crrev.com/bd4f183e08c8bbcc95b65eee4b2949ac53b87679/ios/chrome/app/multitasking_test_application_delegate.mm
[modify] https://crrev.com/bd4f183e08c8bbcc95b65eee4b2949ac53b87679/ios/chrome/test/earl_grey/BUILD.gn

Project Member Comment 267 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16

commit f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16
Author: baxley <baxley@chromium.org>
Date: Wed Jun 07 15:54:14 2017

[ObjC ARC] Converts ios/web/public/test:test to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2920303003
Cr-Commit-Position: refs/heads/master@{#477662}

[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/BUILD.gn
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/js_test_util.h
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/js_test_util.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/native_controller_test_util.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/navigation_test_util.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/scoped_testing_web_client.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/test_redirect_observer.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/web_test.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/web_test_with_web_state.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/web_view_interaction_test_util.mm

Project Member Comment 268 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0527f72f6822c6aba0370d8245bd9acb6715a2f8

commit 0527f72f6822c6aba0370d8245bd9acb6715a2f8
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 07 20:08:44 2017

[ObjC ARC] Converts ios/chrome/browser/omaha:omaha to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2893523003
Cr-Commit-Position: refs/heads/master@{#477742}

[modify] https://crrev.com/0527f72f6822c6aba0370d8245bd9acb6715a2f8/ios/chrome/browser/omaha/BUILD.gn
[modify] https://crrev.com/0527f72f6822c6aba0370d8245bd9acb6715a2f8/ios/chrome/browser/omaha/omaha_service.mm

Project Member Comment 269 by bugdroid1@chromium.org, Jun 9
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e658ccd98032a0bafc7128a86b423a4436e7407

commit 4e658ccd98032a0bafc7128a86b423a4436e7407
Author: baxley <baxley@chromium.org>
Date: Fri Jun 09 02:08:26 2017

[ObjC ARC] Converts ios/web/public/test/http_server:http_server to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2923563005
Cr-Commit-Position: refs/heads/master@{#478161}

[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/BUILD.gn
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/data_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/delayed_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/error_page_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/html_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/html_response_provider_impl.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_auth_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_server.h
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_server.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_server_util.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/string_response_provider.mm

Project Member Comment 270 by bugdroid1@chromium.org, Jun 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/490d666042ff57a78a5e4f990793f375f626212f

commit 490d666042ff57a78a5e4f990793f375f626212f
Author: pkl <pkl@chromium.org>
Date: Mon Jun 12 13:59:29 2017

[ObjC ARC] Converts ios/chrome/browser/crash_report:crash_report_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2916253003
Cr-Commit-Position: refs/heads/master@{#478604}

[modify] https://crrev.com/490d666042ff57a78a5e4f990793f375f626212f/ios/chrome/browser/crash_report/BUILD.gn
[modify] https://crrev.com/490d666042ff57a78a5e4f990793f375f626212f/ios/chrome/browser/crash_report/crash_report_helper.mm
[modify] https://crrev.com/490d666042ff57a78a5e4f990793f375f626212f/ios/chrome/browser/crash_report/crash_restore_helper.mm

Project Member Comment 271 by bugdroid1@chromium.org, Jun 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac067a438e47907c38ea2093083f8e7678477b8

commit dac067a438e47907c38ea2093083f8e7678477b8
Author: marq <marq@chromium.org>
Date: Mon Jun 12 15:42:21 2017

[ObjC ARC] Converts ios/web:ios_web_inttests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2935683002
Cr-Commit-Position: refs/heads/master@{#478635}

[modify] https://crrev.com/dac067a438e47907c38ea2093083f8e7678477b8/ios/web/BUILD.gn
[modify] https://crrev.com/dac067a438e47907c38ea2093083f8e7678477b8/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/dac067a438e47907c38ea2093083f8e7678477b8/ios/web/web_state/navigation_callbacks_inttest.mm

Project Member Comment 274 by bugdroid1@chromium.org, Jun 12
Project Member Comment 276 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3cb3cf56a018f1b82a8e091f81147340dc5762c

commit c3cb3cf56a018f1b82a8e091f81147340dc5762c
Author: baxley <baxley@chromium.org>
Date: Tue Jun 13 00:48:26 2017

[ObjC ARC] Converts ios/chrome/test/app:test_support to ARC.

Also convert ios/chrome/browser/ui/sync:eg_tests to ARC, since this
simplifies use of output parameters in sync_test_util.mm.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2888173002
Cr-Commit-Position: refs/heads/master@{#478845}

[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/browser/ui/sync/BUILD.gn
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/BUILD.gn
[add] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/DEPS
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/bookmarks_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/histogram_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/history_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/navigation_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/settings_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/signin_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/stack_view_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/static_html_view_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/sync_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/tab_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/web_view_interaction_test_util.mm

Project Member Comment 278 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08012dc3513eaf24a8d44e5cd63add938ddd41e6

commit 08012dc3513eaf24a8d44e5cd63add938ddd41e6
Author: marq <marq@chromium.org>
Date: Tue Jun 13 09:50:40 2017

Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2935683002/ )

Reason for revert:
Breaks tree?

Original issue's description:
> [ObjC ARC] Converts ios/web:ios_web_inttests to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2935683002
> Cr-Commit-Position: refs/heads/master@{#478635}
> Committed: https://chromium.googlesource.com/chromium/src/+/dac067a438e47907c38ea2093083f8e7678477b8

TBR=stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2934053002
Cr-Commit-Position: refs/heads/master@{#478952}

[modify] https://crrev.com/08012dc3513eaf24a8d44e5cd63add938ddd41e6/ios/web/BUILD.gn
[modify] https://crrev.com/08012dc3513eaf24a8d44e5cd63add938ddd41e6/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/08012dc3513eaf24a8d44e5cd63add938ddd41e6/ios/web/web_state/navigation_callbacks_inttest.mm

Project Member Comment 281 by bugdroid1@chromium.org, Jun 13
Project Member Comment 285 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16b50d5d9a5c4e17fdbeee07c043186b334b08e7

commit 16b50d5d9a5c4e17fdbeee07c043186b334b08e7
Author: marq <marq@chromium.org>
Date: Tue Jun 13 13:15:28 2017

[ObjC ARC] Converts ios/chrome/browser/ui/sync:sync to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2939433002
Cr-Commit-Position: refs/heads/master@{#478993}

[modify] https://crrev.com/16b50d5d9a5c4e17fdbeee07c043186b334b08e7/ios/chrome/browser/ui/sync/BUILD.gn
[modify] https://crrev.com/16b50d5d9a5c4e17fdbeee07c043186b334b08e7/ios/chrome/browser/ui/sync/sync_error_infobar_delegate.mm
[modify] https://crrev.com/16b50d5d9a5c4e17fdbeee07c043186b334b08e7/ios/chrome/browser/ui/sync/sync_util.mm

Project Member Comment 287 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/191766192510fe8eae7d3197a19ce1a42656e3cd

commit 191766192510fe8eae7d3197a19ce1a42656e3cd
Author: marq <marq@chromium.org>
Date: Tue Jun 13 17:07:03 2017

[ObjC ARC] Converts ios/chrome/browser/ui/authentication:authentication to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2936583002
Cr-Commit-Position: refs/heads/master@{#479055}

[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/authentication_flow.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/authentication_ui_util.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

Project Member Comment 288 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82def10ead4edd5bd6d69405345f77b0d2c3222d

commit 82def10ead4edd5bd6d69405345f77b0d2c3222d
Author: marq <marq@chromium.org>
Date: Tue Jun 13 20:36:04 2017

[ObjC ARC] Converts ios/chrome/browser/passwords:passwords to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933873002
Cr-Commit-Position: refs/heads/master@{#479134}

[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/js_password_manager.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_agent.h
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_agent.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_edit_view.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_offer_view.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/update_password_infobar_controller.mm

Project Member Comment 291 by bugdroid1@chromium.org, Jun 14
Project Member Comment 295 by bugdroid1@chromium.org, Jun 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab

commit 19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab
Author: marq <marq@chromium.org>
Date: Wed Jun 14 15:48:56 2017

[ObjC ARC] Converts ios/web:ios_web_web_state_unittests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2935933003
Cr-Commit-Position: refs/heads/master@{#479400}

[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/BUILD.gn
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/context_menu_params_utils_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/error_translation_util_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/navigation_context_impl_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/page_display_state_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_delegate_bridge_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_observer_bridge_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_view_internal_creation_util_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/wk_web_view_security_util_unittest.mm

Project Member Comment 298 by bugdroid1@chromium.org, Jun 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e903119df72bd16ed4682c9e1c88ec9caeb81238

commit e903119df72bd16ed4682c9e1c88ec9caeb81238
Author: marq <marq@chromium.org>
Date: Wed Jun 14 19:11:07 2017

[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

Automatically generated ARCMigrate commit

Notable issues:

Removed WKBackForwardListItemHolderTest.GetNilBackForwardListItemFromHolder,
since it amounts to being a test of WeakNSPointer, and there's no guarantees about
object lifetimes under ARC.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933363002
Cr-Commit-Position: refs/heads/master@{#479462}

[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/BUILD.gn
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_controller_container_view_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/web_view_js_utils_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

Project Member Comment 299 by bugdroid1@chromium.org, Jun 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39

commit e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 14 20:35:56 2017

[ObjC ARC] Converts ios/chrome/test/ocmock:ocmock to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2891143002
Cr-Commit-Position: refs/heads/master@{#479492}

[modify] https://crrev.com/e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39/ios/chrome/test/ocmock/BUILD.gn
[modify] https://crrev.com/e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39/ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm

Project Member Comment 300 by bugdroid1@chromium.org, Jun 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11259e450d6002293271d60949681a1d99d7422b

commit 11259e450d6002293271d60949681a1d99d7422b
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 14 21:11:23 2017

[ObjC ARC] Converts ios/testing:ocmock_support_unittest to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2891863002
Cr-Commit-Position: refs/heads/master@{#479505}

[modify] https://crrev.com/11259e450d6002293271d60949681a1d99d7422b/ios/testing/BUILD.gn
[modify] https://crrev.com/11259e450d6002293271d60949681a1d99d7422b/ios/testing/ocmock_complex_type_helper_unittest.mm

Project Member Comment 301 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eabc5221db21a5f0036a7eed24db496187aa8e90

commit eabc5221db21a5f0036a7eed24db496187aa8e90
Author: marq <marq@chromium.org>
Date: Thu Jun 15 09:37:34 2017

[ObjC ARC] Converts components/sessions:unit_tests to ARC.

"ARC" is Automatic Reference Counting, a memory management model for Objective-C.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2937493002
Cr-Commit-Position: refs/heads/master@{#479648}

[modify] https://crrev.com/eabc5221db21a5f0036a7eed24db496187aa8e90/components/sessions/BUILD.gn
[modify] https://crrev.com/eabc5221db21a5f0036a7eed24db496187aa8e90/components/sessions/ios/ios_serialized_navigation_builder_unittest.mm

Project Member Comment 302 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a582bda6805aebbb9cc2e3d360aea2e7e9522161

commit a582bda6805aebbb9cc2e3d360aea2e7e9522161
Author: marq <marq@chromium.org>
Date: Thu Jun 15 11:57:30 2017

[ObjC ARC] Converts components/signin/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit

Notable issues: Observer bridge classes need to explicitly declare their delegates weak.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2928383002
Cr-Commit-Position: refs/heads/master@{#479670}

[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/BUILD.gn
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/account_consistency_service.h
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/account_consistency_service.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/merge_session_observer_bridge.h
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/merge_session_observer_bridge.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/oauth2_token_service_observer_bridge.h
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/oauth2_token_service_observer_bridge.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/profile_oauth2_token_service_ios_provider.mm

Project Member Comment 303 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8617ad05b5fa2d087657008cb74b73b9cb3a1050

commit 8617ad05b5fa2d087657008cb74b73b9cb3a1050
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu Jun 15 13:44:38 2017

[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2889093002
Cr-Commit-Position: refs/heads/master@{#479687}

[modify] https://crrev.com/8617ad05b5fa2d087657008cb74b73b9cb3a1050/ios/chrome/browser/geolocation/BUILD.gn
[modify] https://crrev.com/8617ad05b5fa2d087657008cb74b73b9cb3a1050/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm

Project Member Comment 304 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/309563011bbb50c1311bef5e9e99ad7319d0ee0e

commit 309563011bbb50c1311bef5e9e99ad7319d0ee0e
Author: marq <marq@chromium.org>
Date: Thu Jun 15 15:37:55 2017

[ObjC ARC] Converts ios/chrome/browser/ui:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2936833002
Cr-Commit-Position: refs/heads/master@{#479712}

[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/browser_container_view_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/file_locations_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/fullscreen_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/key_commands_provider_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/native_content_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/network_activity_indicator_manager_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/open_in_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/open_in_toolbar_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/page_not_available_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/preload_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/ui_util_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/uikit_ui_util_unittest.mm

Project Member Comment 305 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687e15bb3699072e965c4c8b02c93aec933521b8

commit 687e15bb3699072e965c4c8b02c93aec933521b8
Author: marq <marq@chromium.org>
Date: Thu Jun 15 15:53:02 2017

[ObjC ARC] Converts ios/web:ios_web_inttests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2934413002
Cr-Commit-Position: refs/heads/master@{#479719}

[modify] https://crrev.com/687e15bb3699072e965c4c8b02c93aec933521b8/ios/web/BUILD.gn
[modify] https://crrev.com/687e15bb3699072e965c4c8b02c93aec933521b8/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/687e15bb3699072e965c4c8b02c93aec933521b8/ios/web/web_state/navigation_callbacks_inttest.mm

Project Member Comment 306 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef344143929225c301200cc7687272a3490833fa

commit ef344143929225c301200cc7687272a3490833fa
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 15 16:05:00 2017

Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm.

This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
serves as a parent CL of https://codereview.chromium.org/2887413002/
so that ios/chrome/app:main can be converted to ARC.

Bug: 624363
Change-Id: I434a40bc8b6a4482d03c4be7e642a218aed61b94
Reviewed-on: https://chromium-review.googlesource.com/534874
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479722}
[modify] https://crrev.com/ef344143929225c301200cc7687272a3490833fa/ios/chrome/app/chrome_exe_main.mm

Project Member Comment 307 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1764ee16d0e69c66291f05bccfc334ae311fc83f

commit 1764ee16d0e69c66291f05bccfc334ae311fc83f
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 15 19:36:28 2017

Revert "Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm."

This reverts commit ef344143929225c301200cc7687272a3490833fa.

Reason for revert: This CL breaks ios integration egtests.

Original change's description:
> Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm.
> 
> This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
> serves as a parent CL of https://codereview.chromium.org/2887413002/
> so that ios/chrome/app:main can be converted to ARC.
> 
> Bug: 624363
> Change-Id: I434a40bc8b6a4482d03c4be7e642a218aed61b94
> Reviewed-on: https://chromium-review.googlesource.com/534874
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#479722}

TBR=marq@chromium.org,sdefresne@chromium.org,stkhapugin@chromium.org,liaoyuke@chromium.org

Change-Id: I91dc13ccccba78d772a78095484bb545dd06cf39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 624363
Reviewed-on: https://chromium-review.googlesource.com/537219
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479787}
[modify] https://crrev.com/1764ee16d0e69c66291f05bccfc334ae311fc83f/ios/chrome/app/chrome_exe_main.mm

Project Member Comment 308 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5591af73d026778aa875200962b8a4c568785059

commit 5591af73d026778aa875200962b8a4c568785059
Author: Justin Cohen <justincohen@chromium.org>
Date: Thu Jun 15 19:36:54 2017

Revert "Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm."

This reverts commit ef344143929225c301200cc7687272a3490833fa.

Reason for revert: DCHECK @ n base::AtExitManager::RegisterCallback(void (*)(void*), void*) at base/at_exit.cc:52

Original change's description:
> Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm.
> 
> This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
> serves as a parent CL of https://codereview.chromium.org/2887413002/
> so that ios/chrome/app:main can be converted to ARC.
> 
> Bug: 624363
> Change-Id: I434a40bc8b6a4482d03c4be7e642a218aed61b94
> Reviewed-on: https://chromium-review.googlesource.com/534874
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#479722}

TBR=marq@chromium.org,sdefresne@chromium.org,stkhapugin@chromium.org,liaoyuke@chromium.org

Change-Id: I394073d7c4fefa4393c81f60c8932e37dca50a61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 624363
Reviewed-on: https://chromium-review.googlesource.com/537552
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479789}

Project Member Comment 309 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec712b77733df9b3735c278ef08e99ea5a0c0dd3

commit ec712b77733df9b3735c278ef08e99ea5a0c0dd3
Author: marq <marq@chromium.org>
Date: Thu Jun 15 21:32:23 2017

[ObjC ARC] Converts ios/chrome/browser/ntp_tiles:ntp_tiles to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2936393003
Cr-Commit-Position: refs/heads/master@{#479840}

[modify] https://crrev.com/ec712b77733df9b3735c278ef08e99ea5a0c0dd3/ios/chrome/browser/ntp_tiles/BUILD.gn
[modify] https://crrev.com/ec712b77733df9b3735c278ef08e99ea5a0c0dd3/ios/chrome/browser/ntp_tiles/most_visited_sites_observer_bridge.mm

Project Member Comment 310 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0d8972ae9893eb63746a3157031829173c351eb

commit b0d8972ae9893eb63746a3157031829173c351eb
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu Jun 15 22:06:32 2017

[ObjC ARC] Converts ios/chrome/browser/upgrade:upgrade to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2889023002
Cr-Commit-Position: refs/heads/master@{#479856}

[modify] https://crrev.com/b0d8972ae9893eb63746a3157031829173c351eb/ios/chrome/browser/upgrade/BUILD.gn
[modify] https://crrev.com/b0d8972ae9893eb63746a3157031829173c351eb/ios/chrome/browser/upgrade/upgrade_center.mm

Project Member Comment 311 by bugdroid1@chromium.org, Jun 16
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d2a63048345a021592fa0afe5211f12bfffe82

commit c8d2a63048345a021592fa0afe5211f12bfffe82
Author: marq <marq@chromium.org>
Date: Fri Jun 16 12:16:55 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:tools_menu to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2941043002
Cr-Commit-Position: refs/heads/master@{#480023}

[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_constants.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member Comment 312 by bugdroid1@chromium.org, Jun 16