New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocked on:
issue 624365
issue 645125
issue 659147
issue 663723
issue 691068
issue 756439

Blocking:
issue 636372



Sign in to add a comment

Transition ios/ to ARC

Project Member Reported by stkhapugin@chromium.org, Jun 29 2016

Issue description

Transition ios/ to use Objective-C Automatic Reference Counting.
 
Showing comments 234 - 333 of 333 Older
Project Member

Comment 234 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d45a3eaaabb9a4ee55fffb80430116bd8271b75

commit 0d45a3eaaabb9a4ee55fffb80430116bd8271b75
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 16:25:11 2017

[ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2887563002
Cr-Commit-Position: refs/heads/master@{#472471}

[modify] https://crrev.com/0d45a3eaaabb9a4ee55fffb80430116bd8271b75/ios/chrome/test/base/BUILD.gn
[modify] https://crrev.com/0d45a3eaaabb9a4ee55fffb80430116bd8271b75/ios/chrome/test/base/scoped_block_swizzler_unittest.mm

Project Member

Comment 235 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/108d7013f655111f9e528bd8b8161ee58a54914f

commit 108d7013f655111f9e528bd8b8161ee58a54914f
Author: baxley <baxley@chromium.org>
Date: Wed May 17 19:01:15 2017

[ObjC ARC] Converts ios/chrome/browser/web:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2890003002
Cr-Commit-Position: refs/heads/master@{#472517}

[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/browsing_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/browsing_prevent_default_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/child_window_open_by_dom_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/forms_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/http_auth_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/js_print_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/navigation_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/progress_indicator_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/stop_loading_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/108d7013f655111f9e528bd8b8161ee58a54914f/ios/chrome/browser/web/window_open_by_dom_egtest.mm

Project Member

Comment 236 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0182ad5525a53fbd14266e3f044ad32bddc6faa0

commit 0182ad5525a53fbd14266e3f044ad32bddc6faa0
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 19:44:01 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:hooks to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2885453004
Cr-Commit-Position: refs/heads/master@{#472538}

[modify] https://crrev.com/0182ad5525a53fbd14266e3f044ad32bddc6faa0/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/0182ad5525a53fbd14266e3f044ad32bddc6faa0/ios/chrome/test/earl_grey/eg_tests_hook.mm

Project Member

Comment 237 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45371c8b1e01bac440bc20f29782ceec2580bbc7

commit 45371c8b1e01bac440bc20f29782ceec2580bbc7
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 20:15:43 2017

[ObjC ARC] Converts ios/chrome/browser/web:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2879423002
Cr-Commit-Position: refs/heads/master@{#472545}

[modify] https://crrev.com/45371c8b1e01bac440bc20f29782ceec2580bbc7/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/45371c8b1e01bac440bc20f29782ceec2580bbc7/ios/chrome/browser/web/chrome_web_test.mm
[modify] https://crrev.com/45371c8b1e01bac440bc20f29782ceec2580bbc7/ios/chrome/browser/web/fake_mailto_handler_helpers.mm

Project Member

Comment 238 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/110127094406d74519ddd40c92ec5bd0abeb5c1d

commit 110127094406d74519ddd40c92ec5bd0abeb5c1d
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed May 17 20:53:58 2017

[ObjC ARC] Converts ios/chrome/browser/web:perf_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2886843003
Cr-Commit-Position: refs/heads/master@{#472559}

[modify] https://crrev.com/110127094406d74519ddd40c92ec5bd0abeb5c1d/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/110127094406d74519ddd40c92ec5bd0abeb5c1d/ios/chrome/browser/web/early_page_script_perftest.mm

Project Member

Comment 240 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5222823cb86a00c1fcf5c90f0e08cd52367505

commit 6c5222823cb86a00c1fcf5c90f0e08cd52367505
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu May 18 16:25:47 2017

[ObjC ARC] Converts ios/chrome/test/base:perf_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2881273002
Cr-Commit-Position: refs/heads/master@{#472837}

[modify] https://crrev.com/6c5222823cb86a00c1fcf5c90f0e08cd52367505/ios/chrome/test/base/BUILD.gn
[modify] https://crrev.com/6c5222823cb86a00c1fcf5c90f0e08cd52367505/ios/chrome/test/base/perf_test_ios.mm

Project Member

Comment 241 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b6ee089c18c84e6dbd51d6ce04634b7103e3da

commit 07b6ee089c18c84e6dbd51d6ce04634b7103e3da
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu May 18 19:25:41 2017

[ObjC ARC] Converts ios/chrome/test/base:base to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2882113004
Cr-Commit-Position: refs/heads/master@{#472899}

[modify] https://crrev.com/07b6ee089c18c84e6dbd51d6ce04634b7103e3da/ios/chrome/test/base/BUILD.gn
[modify] https://crrev.com/07b6ee089c18c84e6dbd51d6ce04634b7103e3da/ios/chrome/test/base/scoped_block_swizzler.mm

Project Member

Comment 242 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f88f6d0e6225a933e189cf4c14f51084d889c6f1

commit f88f6d0e6225a933e189cf4c14f51084d889c6f1
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu May 18 21:21:25 2017

[ObjC ARC] Converts ios/chrome/app:tests_fake_hook to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2891853002
Cr-Commit-Position: refs/heads/master@{#472933}

[modify] https://crrev.com/f88f6d0e6225a933e189cf4c14f51084d889c6f1/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/f88f6d0e6225a933e189cf4c14f51084d889c6f1/ios/chrome/app/tests_fake_hook.mm

Project Member

Comment 243 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a88dcd92b92ad194b1a61f371a26ae81fae65b

commit 73a88dcd92b92ad194b1a61f371a26ae81fae65b
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 13:12:56 2017

[ObjC ARC] Converts ios/chrome/browser:browser_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2885163004
Cr-Commit-Position: refs/heads/master@{#473563}

[modify] https://crrev.com/73a88dcd92b92ad194b1a61f371a26ae81fae65b/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/73a88dcd92b92ad194b1a61f371a26ae81fae65b/ios/chrome/browser/callback_counter.mm

Project Member

Comment 244 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd

commit a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 13:34:36 2017

[ObjC ARC] Converts ios/chrome/browser/test:perf_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2889053002
Cr-Commit-Position: refs/heads/master@{#473569}

[modify] https://crrev.com/a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd/ios/chrome/browser/test/BUILD.gn
[modify] https://crrev.com/a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd/ios/chrome/browser/test/perf_test_with_bvc_ios.mm

Project Member

Comment 245 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b623d39cafb4c268d02f1c1e3051a7c9553dd19

commit 9b623d39cafb4c268d02f1c1e3051a7c9553dd19
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 13:56:20 2017

[ObjC ARC] Converts ios/chrome/browser/browsing_data:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2889083002
Cr-Commit-Position: refs/heads/master@{#473571}

[modify] https://crrev.com/9b623d39cafb4c268d02f1c1e3051a7c9553dd19/ios/chrome/browser/browsing_data/BUILD.gn
[modify] https://crrev.com/9b623d39cafb4c268d02f1c1e3051a7c9553dd19/ios/chrome/browser/browsing_data/browsing_data_removal_controller_unittest.mm

Project Member

Comment 246 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09f302179d78baa49db21cb906684c26467219c6

commit 09f302179d78baa49db21cb906684c26467219c6
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 16:38:34 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_smoke_egtests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2893763002
Cr-Commit-Position: refs/heads/master@{#473597}

[modify] https://crrev.com/09f302179d78baa49db21cb906684c26467219c6/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/09f302179d78baa49db21cb906684c26467219c6/ios/chrome/test/earl_grey/smoke_egtest.mm

Project Member

Comment 247 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2705e6425ef090370a6bcd167045e56a22c3d3a

commit e2705e6425ef090370a6bcd167045e56a22c3d3a
Author: liaoyuke <liaoyuke@chromium.org>
Date: Mon May 22 17:00:20 2017

[ObjC ARC] Converts components/signin/ios/browser:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2890983002
Cr-Commit-Position: refs/heads/master@{#473602}

[modify] https://crrev.com/e2705e6425ef090370a6bcd167045e56a22c3d3a/components/signin/ios/browser/BUILD.gn
[modify] https://crrev.com/e2705e6425ef090370a6bcd167045e56a22c3d3a/components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.mm

Project Member

Comment 249 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/515ce76a623d1521ded07bc95f4dde90486b2012

commit 515ce76a623d1521ded07bc95f4dde90486b2012
Author: lindsayw <lindsayw@chromium.org>
Date: Mon May 29 10:45:10 2017

[ObjC ARC] Converts ios/chrome/browser/metrics:unit_tests_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2894653002
Cr-Commit-Position: refs/heads/master@{#475331}

[modify] https://crrev.com/515ce76a623d1521ded07bc95f4dde90486b2012/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/515ce76a623d1521ded07bc95f4dde90486b2012/ios/chrome/browser/metrics/size_class_recorder_unittest.mm
[modify] https://crrev.com/515ce76a623d1521ded07bc95f4dde90486b2012/ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm

Project Member

Comment 250 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4afbfe12c4c71827f0481d2dc8d37fdf49866502

commit 4afbfe12c4c71827f0481d2dc8d37fdf49866502
Author: liaoyuke <liaoyuke@chromium.org>
Date: Tue May 30 18:57:41 2017

[ObjC ARC] Converts ios/chrome/browser/translate:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2889043002
Cr-Commit-Position: refs/heads/master@{#475615}

[modify] https://crrev.com/4afbfe12c4c71827f0481d2dc8d37fdf49866502/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/4afbfe12c4c71827f0481d2dc8d37fdf49866502/ios/chrome/browser/translate/js_language_detection_manager_unittest.mm

Project Member

Comment 258 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/198dcbc93706388bf415866519065dc316f261be

commit 198dcbc93706388bf415866519065dc316f261be
Author: stkhapugin <stkhapugin@chromium.org>
Date: Fri Jun 02 15:07:49 2017

[ObjC ARC] Converts ios/chrome/browser/ui/history:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2650423002
Cr-Commit-Position: refs/heads/master@{#476653}

[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_entries_status_item_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_entry_item_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_search_view_controller_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/history_util_unittest.mm
[modify] https://crrev.com/198dcbc93706388bf415866519065dc316f261be/ios/chrome/browser/ui/history/tab_history_popup_controller_unittest.mm

Project Member

Comment 259 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6666e3d76a0f228dc3631411235c6e20adfdc37a

commit 6666e3d76a0f228dc3631411235c6e20adfdc37a
Author: baxley <baxley@chromium.org>
Date: Fri Jun 02 15:29:45 2017

[ObjC ARC] Converts ios/chrome/browser/ui/qr_scanner:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2880373002
Cr-Commit-Position: refs/heads/master@{#476665}

[modify] https://crrev.com/6666e3d76a0f228dc3631411235c6e20adfdc37a/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/6666e3d76a0f228dc3631411235c6e20adfdc37a/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm

Project Member

Comment 264 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62751ceeb02adc855c96e93127c1bee6c6dc9c33

commit 62751ceeb02adc855c96e93127c1bee6c6dc9c33
Author: baxley <baxley@chromium.org>
Date: Tue Jun 06 17:28:35 2017

[ObjC ARC] Converts ios/web/public/test/fakes:fakes to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2922973004
Cr-Commit-Position: refs/heads/master@{#477325}

[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/BUILD.gn
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/crw_test_js_injection_receiver.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_java_script_dialog_presenter.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_java_script_dialog_presenter.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_native_content.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_native_content_provider.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_navigation_manager.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_client.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_client.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_delegate.h
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_delegate.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_observer.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_state_observer_util.mm
[modify] https://crrev.com/62751ceeb02adc855c96e93127c1bee6c6dc9c33/ios/web/public/test/fakes/test_web_view_content_view.mm

Project Member

Comment 265 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/981b6a8a907ce40b46fbe76881a0f0394cc00d2b

commit 981b6a8a907ce40b46fbe76881a0f0394cc00d2b
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 07 00:12:25 2017

[ObjC ARC] Converts ios/chrome/browser/browsing_data:browsing_data_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2892663003
Cr-Commit-Position: refs/heads/master@{#477475}

[modify] https://crrev.com/981b6a8a907ce40b46fbe76881a0f0394cc00d2b/ios/chrome/browser/browsing_data/BUILD.gn
[modify] https://crrev.com/981b6a8a907ce40b46fbe76881a0f0394cc00d2b/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm

Project Member

Comment 266 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd4f183e08c8bbcc95b65eee4b2949ac53b87679

commit bd4f183e08c8bbcc95b65eee4b2949ac53b87679
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 07 01:26:42 2017

[ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_multitasking_egtests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2886303003
Cr-Commit-Position: refs/heads/master@{#477505}

[modify] https://crrev.com/bd4f183e08c8bbcc95b65eee4b2949ac53b87679/ios/chrome/app/multitasking_test_application_delegate.mm
[modify] https://crrev.com/bd4f183e08c8bbcc95b65eee4b2949ac53b87679/ios/chrome/test/earl_grey/BUILD.gn

Project Member

Comment 267 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16

commit f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16
Author: baxley <baxley@chromium.org>
Date: Wed Jun 07 15:54:14 2017

[ObjC ARC] Converts ios/web/public/test:test to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2920303003
Cr-Commit-Position: refs/heads/master@{#477662}

[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/BUILD.gn
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/js_test_util.h
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/js_test_util.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/native_controller_test_util.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/navigation_test_util.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/scoped_testing_web_client.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/test_redirect_observer.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/web_test.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/web_test_with_web_state.mm
[modify] https://crrev.com/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16/ios/web/public/test/web_view_interaction_test_util.mm

Project Member

Comment 268 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0527f72f6822c6aba0370d8245bd9acb6715a2f8

commit 0527f72f6822c6aba0370d8245bd9acb6715a2f8
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 07 20:08:44 2017

[ObjC ARC] Converts ios/chrome/browser/omaha:omaha to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2893523003
Cr-Commit-Position: refs/heads/master@{#477742}

[modify] https://crrev.com/0527f72f6822c6aba0370d8245bd9acb6715a2f8/ios/chrome/browser/omaha/BUILD.gn
[modify] https://crrev.com/0527f72f6822c6aba0370d8245bd9acb6715a2f8/ios/chrome/browser/omaha/omaha_service.mm

Project Member

Comment 269 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e658ccd98032a0bafc7128a86b423a4436e7407

commit 4e658ccd98032a0bafc7128a86b423a4436e7407
Author: baxley <baxley@chromium.org>
Date: Fri Jun 09 02:08:26 2017

[ObjC ARC] Converts ios/web/public/test/http_server:http_server to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2923563005
Cr-Commit-Position: refs/heads/master@{#478161}

[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/BUILD.gn
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/data_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/delayed_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/error_page_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/html_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/html_response_provider_impl.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_auth_response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_server.h
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_server.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/http_server_util.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/response_provider.mm
[modify] https://crrev.com/4e658ccd98032a0bafc7128a86b423a4436e7407/ios/web/public/test/http_server/string_response_provider.mm

Project Member

Comment 270 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/490d666042ff57a78a5e4f990793f375f626212f

commit 490d666042ff57a78a5e4f990793f375f626212f
Author: pkl <pkl@chromium.org>
Date: Mon Jun 12 13:59:29 2017

[ObjC ARC] Converts ios/chrome/browser/crash_report:crash_report_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2916253003
Cr-Commit-Position: refs/heads/master@{#478604}

[modify] https://crrev.com/490d666042ff57a78a5e4f990793f375f626212f/ios/chrome/browser/crash_report/BUILD.gn
[modify] https://crrev.com/490d666042ff57a78a5e4f990793f375f626212f/ios/chrome/browser/crash_report/crash_report_helper.mm
[modify] https://crrev.com/490d666042ff57a78a5e4f990793f375f626212f/ios/chrome/browser/crash_report/crash_restore_helper.mm

Project Member

Comment 271 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac067a438e47907c38ea2093083f8e7678477b8

commit dac067a438e47907c38ea2093083f8e7678477b8
Author: marq <marq@chromium.org>
Date: Mon Jun 12 15:42:21 2017

[ObjC ARC] Converts ios/web:ios_web_inttests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2935683002
Cr-Commit-Position: refs/heads/master@{#478635}

[modify] https://crrev.com/dac067a438e47907c38ea2093083f8e7678477b8/ios/web/BUILD.gn
[modify] https://crrev.com/dac067a438e47907c38ea2093083f8e7678477b8/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/dac067a438e47907c38ea2093083f8e7678477b8/ios/web/web_state/navigation_callbacks_inttest.mm

Project Member

Comment 274 by bugdroid1@chromium.org, Jun 12 2017

Project Member

Comment 276 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3cb3cf56a018f1b82a8e091f81147340dc5762c

commit c3cb3cf56a018f1b82a8e091f81147340dc5762c
Author: baxley <baxley@chromium.org>
Date: Tue Jun 13 00:48:26 2017

[ObjC ARC] Converts ios/chrome/test/app:test_support to ARC.

Also convert ios/chrome/browser/ui/sync:eg_tests to ARC, since this
simplifies use of output parameters in sync_test_util.mm.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2888173002
Cr-Commit-Position: refs/heads/master@{#478845}

[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/browser/ui/sync/BUILD.gn
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/BUILD.gn
[add] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/DEPS
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/bookmarks_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/histogram_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/history_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/navigation_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/settings_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/signin_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/stack_view_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/static_html_view_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/sync_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/tab_test_util.mm
[modify] https://crrev.com/c3cb3cf56a018f1b82a8e091f81147340dc5762c/ios/chrome/test/app/web_view_interaction_test_util.mm

Project Member

Comment 278 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08012dc3513eaf24a8d44e5cd63add938ddd41e6

commit 08012dc3513eaf24a8d44e5cd63add938ddd41e6
Author: marq <marq@chromium.org>
Date: Tue Jun 13 09:50:40 2017

Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2935683002/ )

Reason for revert:
Breaks tree?

Original issue's description:
> [ObjC ARC] Converts ios/web:ios_web_inttests to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG= 624363 
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2935683002
> Cr-Commit-Position: refs/heads/master@{#478635}
> Committed: https://chromium.googlesource.com/chromium/src/+/dac067a438e47907c38ea2093083f8e7678477b8

TBR=stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 624363 

Review-Url: https://codereview.chromium.org/2934053002
Cr-Commit-Position: refs/heads/master@{#478952}

[modify] https://crrev.com/08012dc3513eaf24a8d44e5cd63add938ddd41e6/ios/web/BUILD.gn
[modify] https://crrev.com/08012dc3513eaf24a8d44e5cd63add938ddd41e6/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/08012dc3513eaf24a8d44e5cd63add938ddd41e6/ios/web/web_state/navigation_callbacks_inttest.mm

Project Member

Comment 279 by bugdroid1@chromium.org, Jun 13 2017

Project Member

Comment 281 by bugdroid1@chromium.org, Jun 13 2017

Project Member

Comment 285 by bugdroid1@chromium.org, Jun 13 2017

Project Member

Comment 287 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/191766192510fe8eae7d3197a19ce1a42656e3cd

commit 191766192510fe8eae7d3197a19ce1a42656e3cd
Author: marq <marq@chromium.org>
Date: Tue Jun 13 17:07:03 2017

[ObjC ARC] Converts ios/chrome/browser/ui/authentication:authentication to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2936583002
Cr-Commit-Position: refs/heads/master@{#479055}

[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/authentication_flow.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/authentication_ui_util.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.h
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm
[modify] https://crrev.com/191766192510fe8eae7d3197a19ce1a42656e3cd/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

Project Member

Comment 288 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82def10ead4edd5bd6d69405345f77b0d2c3222d

commit 82def10ead4edd5bd6d69405345f77b0d2c3222d
Author: marq <marq@chromium.org>
Date: Tue Jun 13 20:36:04 2017

[ObjC ARC] Converts ios/chrome/browser/passwords:passwords to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2933873002
Cr-Commit-Position: refs/heads/master@{#479134}

[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/js_password_manager.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_agent.h
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_agent.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_edit_view.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/password_generation_offer_view.mm
[modify] https://crrev.com/82def10ead4edd5bd6d69405345f77b0d2c3222d/ios/chrome/browser/passwords/update_password_infobar_controller.mm

Project Member

Comment 291 by bugdroid1@chromium.org, Jun 14 2017

Project Member

Comment 295 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab

commit 19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab
Author: marq <marq@chromium.org>
Date: Wed Jun 14 15:48:56 2017

[ObjC ARC] Converts ios/web:ios_web_web_state_unittests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2935933003
Cr-Commit-Position: refs/heads/master@{#479400}

[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/BUILD.gn
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/context_menu_params_utils_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/error_translation_util_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/navigation_context_impl_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/page_display_state_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_delegate_bridge_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_observer_bridge_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_state_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/web_view_internal_creation_util_unittest.mm
[modify] https://crrev.com/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab/ios/web/web_state/wk_web_view_security_util_unittest.mm

Project Member

Comment 298 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e903119df72bd16ed4682c9e1c88ec9caeb81238

commit e903119df72bd16ed4682c9e1c88ec9caeb81238
Author: marq <marq@chromium.org>
Date: Wed Jun 14 19:11:07 2017

[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

Automatically generated ARCMigrate commit

Notable issues:

Removed WKBackForwardListItemHolderTest.GetNilBackForwardListItemFromHolder,
since it amounts to being a test of WeakNSPointer, and there's no guarantees about
object lifetimes under ARC.

BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2933363002
Cr-Commit-Position: refs/heads/master@{#479462}

[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/BUILD.gn
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_controller_container_view_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/web_view_js_utils_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm
[modify] https://crrev.com/e903119df72bd16ed4682c9e1c88ec9caeb81238/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

Project Member

Comment 299 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39

commit e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 14 20:35:56 2017

[ObjC ARC] Converts ios/chrome/test/ocmock:ocmock to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2891143002
Cr-Commit-Position: refs/heads/master@{#479492}

[modify] https://crrev.com/e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39/ios/chrome/test/ocmock/BUILD.gn
[modify] https://crrev.com/e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39/ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm

Project Member

Comment 300 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11259e450d6002293271d60949681a1d99d7422b

commit 11259e450d6002293271d60949681a1d99d7422b
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Jun 14 21:11:23 2017

[ObjC ARC] Converts ios/testing:ocmock_support_unittest to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2891863002
Cr-Commit-Position: refs/heads/master@{#479505}

[modify] https://crrev.com/11259e450d6002293271d60949681a1d99d7422b/ios/testing/BUILD.gn
[modify] https://crrev.com/11259e450d6002293271d60949681a1d99d7422b/ios/testing/ocmock_complex_type_helper_unittest.mm

Project Member

Comment 301 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eabc5221db21a5f0036a7eed24db496187aa8e90

commit eabc5221db21a5f0036a7eed24db496187aa8e90
Author: marq <marq@chromium.org>
Date: Thu Jun 15 09:37:34 2017

[ObjC ARC] Converts components/sessions:unit_tests to ARC.

"ARC" is Automatic Reference Counting, a memory management model for Objective-C.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2937493002
Cr-Commit-Position: refs/heads/master@{#479648}

[modify] https://crrev.com/eabc5221db21a5f0036a7eed24db496187aa8e90/components/sessions/BUILD.gn
[modify] https://crrev.com/eabc5221db21a5f0036a7eed24db496187aa8e90/components/sessions/ios/ios_serialized_navigation_builder_unittest.mm

Project Member

Comment 302 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a582bda6805aebbb9cc2e3d360aea2e7e9522161

commit a582bda6805aebbb9cc2e3d360aea2e7e9522161
Author: marq <marq@chromium.org>
Date: Thu Jun 15 11:57:30 2017

[ObjC ARC] Converts components/signin/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit

Notable issues: Observer bridge classes need to explicitly declare their delegates weak.

BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2928383002
Cr-Commit-Position: refs/heads/master@{#479670}

[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/BUILD.gn
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/account_consistency_service.h
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/account_consistency_service.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/merge_session_observer_bridge.h
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/merge_session_observer_bridge.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/oauth2_token_service_observer_bridge.h
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/oauth2_token_service_observer_bridge.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm
[modify] https://crrev.com/a582bda6805aebbb9cc2e3d360aea2e7e9522161/components/signin/ios/browser/profile_oauth2_token_service_ios_provider.mm

Project Member

Comment 303 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8617ad05b5fa2d087657008cb74b73b9cb3a1050

commit 8617ad05b5fa2d087657008cb74b73b9cb3a1050
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu Jun 15 13:44:38 2017

[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2889093002
Cr-Commit-Position: refs/heads/master@{#479687}

[modify] https://crrev.com/8617ad05b5fa2d087657008cb74b73b9cb3a1050/ios/chrome/browser/geolocation/BUILD.gn
[modify] https://crrev.com/8617ad05b5fa2d087657008cb74b73b9cb3a1050/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm

Project Member

Comment 304 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/309563011bbb50c1311bef5e9e99ad7319d0ee0e

commit 309563011bbb50c1311bef5e9e99ad7319d0ee0e
Author: marq <marq@chromium.org>
Date: Thu Jun 15 15:37:55 2017

[ObjC ARC] Converts ios/chrome/browser/ui:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2936833002
Cr-Commit-Position: refs/heads/master@{#479712}

[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/browser_container_view_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/file_locations_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/fullscreen_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/key_commands_provider_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/native_content_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/network_activity_indicator_manager_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/open_in_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/open_in_toolbar_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/page_not_available_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/preload_controller_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/ui_util_unittest.mm
[modify] https://crrev.com/309563011bbb50c1311bef5e9e99ad7319d0ee0e/ios/chrome/browser/ui/uikit_ui_util_unittest.mm

Project Member

Comment 305 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687e15bb3699072e965c4c8b02c93aec933521b8

commit 687e15bb3699072e965c4c8b02c93aec933521b8
Author: marq <marq@chromium.org>
Date: Thu Jun 15 15:53:02 2017

[ObjC ARC] Converts ios/web:ios_web_inttests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2934413002
Cr-Commit-Position: refs/heads/master@{#479719}

[modify] https://crrev.com/687e15bb3699072e965c4c8b02c93aec933521b8/ios/web/BUILD.gn
[modify] https://crrev.com/687e15bb3699072e965c4c8b02c93aec933521b8/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/687e15bb3699072e965c4c8b02c93aec933521b8/ios/web/web_state/navigation_callbacks_inttest.mm

Project Member

Comment 306 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef344143929225c301200cc7687272a3490833fa

commit ef344143929225c301200cc7687272a3490833fa
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 15 16:05:00 2017

Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm.

This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
serves as a parent CL of https://codereview.chromium.org/2887413002/
so that ios/chrome/app:main can be converted to ARC.

Bug:  624363 
Change-Id: I434a40bc8b6a4482d03c4be7e642a218aed61b94
Reviewed-on: https://chromium-review.googlesource.com/534874
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479722}
[modify] https://crrev.com/ef344143929225c301200cc7687272a3490833fa/ios/chrome/app/chrome_exe_main.mm

Project Member

Comment 307 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1764ee16d0e69c66291f05bccfc334ae311fc83f

commit 1764ee16d0e69c66291f05bccfc334ae311fc83f
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 15 19:36:28 2017

Revert "Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm."

This reverts commit ef344143929225c301200cc7687272a3490833fa.

Reason for revert: This CL breaks ios integration egtests.

Original change's description:
> Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm.
> 
> This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
> serves as a parent CL of https://codereview.chromium.org/2887413002/
> so that ios/chrome/app:main can be converted to ARC.
> 
> Bug:  624363 
> Change-Id: I434a40bc8b6a4482d03c4be7e642a218aed61b94
> Reviewed-on: https://chromium-review.googlesource.com/534874
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#479722}

TBR=marq@chromium.org,sdefresne@chromium.org,stkhapugin@chromium.org,liaoyuke@chromium.org

Change-Id: I91dc13ccccba78d772a78095484bb545dd06cf39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  624363 
Reviewed-on: https://chromium-review.googlesource.com/537219
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479787}
[modify] https://crrev.com/1764ee16d0e69c66291f05bccfc334ae311fc83f/ios/chrome/app/chrome_exe_main.mm

Project Member

Comment 308 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5591af73d026778aa875200962b8a4c568785059

commit 5591af73d026778aa875200962b8a4c568785059
Author: Justin Cohen <justincohen@chromium.org>
Date: Thu Jun 15 19:36:54 2017

Revert "Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm."

This reverts commit ef344143929225c301200cc7687272a3490833fa.

Reason for revert: DCHECK @ n base::AtExitManager::RegisterCallback(void (*)(void*), void*) at base/at_exit.cc:52

Original change's description:
> Add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm.
> 
> This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
> serves as a parent CL of https://codereview.chromium.org/2887413002/
> so that ios/chrome/app:main can be converted to ARC.
> 
> Bug:  624363 
> Change-Id: I434a40bc8b6a4482d03c4be7e642a218aed61b94
> Reviewed-on: https://chromium-review.googlesource.com/534874
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#479722}

TBR=marq@chromium.org,sdefresne@chromium.org,stkhapugin@chromium.org,liaoyuke@chromium.org

Change-Id: I394073d7c4fefa4393c81f60c8932e37dca50a61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  624363 
Reviewed-on: https://chromium-review.googlesource.com/537552
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479789}

Project Member

Comment 309 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec712b77733df9b3735c278ef08e99ea5a0c0dd3

commit ec712b77733df9b3735c278ef08e99ea5a0c0dd3
Author: marq <marq@chromium.org>
Date: Thu Jun 15 21:32:23 2017

[ObjC ARC] Converts ios/chrome/browser/ntp_tiles:ntp_tiles to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2936393003
Cr-Commit-Position: refs/heads/master@{#479840}

[modify] https://crrev.com/ec712b77733df9b3735c278ef08e99ea5a0c0dd3/ios/chrome/browser/ntp_tiles/BUILD.gn
[modify] https://crrev.com/ec712b77733df9b3735c278ef08e99ea5a0c0dd3/ios/chrome/browser/ntp_tiles/most_visited_sites_observer_bridge.mm

Project Member

Comment 310 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0d8972ae9893eb63746a3157031829173c351eb

commit b0d8972ae9893eb63746a3157031829173c351eb
Author: liaoyuke <liaoyuke@chromium.org>
Date: Thu Jun 15 22:06:32 2017

[ObjC ARC] Converts ios/chrome/browser/upgrade:upgrade to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2889023002
Cr-Commit-Position: refs/heads/master@{#479856}

[modify] https://crrev.com/b0d8972ae9893eb63746a3157031829173c351eb/ios/chrome/browser/upgrade/BUILD.gn
[modify] https://crrev.com/b0d8972ae9893eb63746a3157031829173c351eb/ios/chrome/browser/upgrade/upgrade_center.mm

Project Member

Comment 311 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d2a63048345a021592fa0afe5211f12bfffe82

commit c8d2a63048345a021592fa0afe5211f12bfffe82
Author: marq <marq@chromium.org>
Date: Fri Jun 16 12:16:55 2017

[ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:tools_menu to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2941043002
Cr-Commit-Position: refs/heads/master@{#480023}

[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_constants.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm
[modify] https://crrev.com/c8d2a63048345a021592fa0afe5211f12bfffe82/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 312 by bugdroid1@chromium.org, Jun 16 2017

Project Member

Comment 313 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66

commit 95903ec2a23312d86a8c26cdcf2721ce8b8f5d66
Author: peterlaurens <peterlaurens@chromium.org>
Date: Fri Jun 16 17:12:22 2017

[ObjC ARC] Converts ios/web:web to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2916473002
Cr-Commit-Position: refs/heads/master@{#480083}

[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/BUILD.gn
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/public/web_state/ui/crw_content_view.h
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/public/web_state/ui/crw_web_view_content_view.h
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/ui/crw_web_controller_container_view.h
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/ui/crw_web_controller_container_view.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/ui/crw_web_view_content_view.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/ui/crw_wk_script_message_router.h
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/ui/crw_wk_script_message_router.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/ui/web_view_js_utils.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/web_view_internal_creation_util.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/web_state/wk_web_view_security_util.mm
[modify] https://crrev.com/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66/ios/web/webui/web_ui_mojo_inttest.mm

Project Member

Comment 314 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a9b847e0cbcfd1c8858a8fd63062221f5f96775

commit 6a9b847e0cbcfd1c8858a8fd63062221f5f96775
Author: marq <marq@chromium.org>
Date: Wed Jun 21 11:51:24 2017

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2944443003
Cr-Commit-Position: refs/heads/master@{#481177}

[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/metrics/tab_usage_recorder.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/card_set.h
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/card_set.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/card_stack_layout_manager.h
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/card_stack_layout_manager.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/card_stack_pinch_gesture_recognizer.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/card_view.h
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/card_view.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/close_button.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/page_animation_util.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/stack_card.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/stack_view_controller.h
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/6a9b847e0cbcfd1c8858a8fd63062221f5f96775/ios/chrome/browser/ui/stack_view/title_label.mm

Project Member

Comment 316 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d795cd03fde8b8e23747613e8cc21da840bc4ea8

commit d795cd03fde8b8e23747613e8cc21da840bc4ea8
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 22 21:31:59 2017

Reland add @autoreleasepool to ios/chrome/app/chrome_exe_main.mm.

This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
serves as a parent CL of https://codereview.chromium.org/2887413002/
so that ios/chrome/app:main can be converted to ARC.

Bug:  624363 
Change-Id: Ibe55897f1869643deee85723c97b0062146b01d0
Reviewed-on: https://chromium-review.googlesource.com/540701
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481670}
[modify] https://crrev.com/d795cd03fde8b8e23747613e8cc21da840bc4ea8/ios/chrome/app/chrome_exe_main.mm

Project Member

Comment 319 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2df6fd6cb908bb003302ceaa8b1e795c54a6e3

commit 1c2df6fd6cb908bb003302ceaa8b1e795c54a6e3
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Jun 26 11:29:53 2017

[ObjC ARC] Converts ios/chrome/app:main to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2959473002
Cr-Commit-Position: refs/heads/master@{#482240}

[modify] https://crrev.com/1c2df6fd6cb908bb003302ceaa8b1e795c54a6e3/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/1c2df6fd6cb908bb003302ceaa8b1e795c54a6e3/ios/chrome/app/chrome_exe_main.mm

Project Member

Comment 322 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5637eff43f718e4479c6b107ff7f3628b72b0984

commit 5637eff43f718e4479c6b107ff7f3628b72b0984
Author: stkhapugin <stkhapugin@chromium.org>
Date: Thu Jun 29 13:05:33 2017

[ObjC ARC] Converts ios/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2848673003
Cr-Commit-Position: refs/heads/master@{#483341}

[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/BUILD.gn
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/account_consistency_service_factory.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/authentication_service.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/authentication_service_factory.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/browser_state_data_remover.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/chrome_identity_service_observer_bridge.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/constants.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/oauth2_token_service_factory.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/signin_client_impl.mm
[modify] https://crrev.com/5637eff43f718e4479c6b107ff7f3628b72b0984/ios/chrome/browser/signin/signin_util.mm

Project Member

Comment 323 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f53b846dd221596595d909bc57e693e6e68d722

commit 7f53b846dd221596595d909bc57e693e6e68d722
Author: stkhapugin <stkhapugin@chromium.org>
Date: Mon Jul 03 15:37:02 2017

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2955363002
Cr-Commit-Position: refs/heads/master@{#484007}

[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/centering_scrollview.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/google_landing_view_controller.h
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/incognito_panel_controller.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/most_visited_cell.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/most_visited_layout.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/new_tab_page_bar.h
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/new_tab_page_bar_item.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/whats_new_header_view.h
[modify] https://crrev.com/7f53b846dd221596595d909bc57e693e6e68d722/ios/chrome/browser/ui/ntp/whats_new_header_view.mm

Project Member

Comment 324 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3493d6fdd063c42a50ca9a81d0c47831c605f550

commit 3493d6fdd063c42a50ca9a81d0c47831c605f550
Author: stkhapugin <stkhapugin@chromium.org>
Date: Wed Jul 12 16:56:01 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Review-Url: https://codereview.chromium.org/2964383002
Cr-Commit-Position: refs/heads/master@{#485999}

[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/BUILD.gn
[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/chrome_identity.h
[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/chrome_identity.mm
[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.h
[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm
[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm
[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/signin_error_provider.mm
[modify] https://crrev.com/3493d6fdd063c42a50ca9a81d0c47831c605f550/ios/public/provider/chrome/browser/signin/signin_resources_provider.mm

Project Member

Comment 325 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae2828e20bfca183dcc7ea0070be9372c2cd07c

commit 2ae2828e20bfca183dcc7ea0070be9372c2cd07c
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jul 17 12:02:36 2017

[ObjC ARC] Converts part of ios/web:web to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 - added bridged casts where necessary
 - replaced retain-autorelease with NS_VALID_UNTIL_END_OF_SCOPE
BUG= 624363 
TEST=None

Change-Id: Ibd7f03942d784bdcf2b95a30f693cfd736ef13c9
Reviewed-on: https://chromium-review.googlesource.com/570031
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487047}
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/BUILD.gn
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/public/web_state/ui/crw_content_view.h
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/public/web_state/ui/crw_web_view_content_view.h
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/ui/crw_web_view_content_view.mm
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/ui/crw_wk_script_message_router.h
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/ui/crw_wk_script_message_router.mm
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/ui/web_view_js_utils.mm
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/ui/wk_back_forward_list_item_holder.mm
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/web_controller_observer_bridge.mm
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/web_view_internal_creation_util.mm
[modify] https://crrev.com/2ae2828e20bfca183dcc7ea0070be9372c2cd07c/ios/web/web_state/wk_web_view_security_util.mm

Blockedon: 756439
Project Member

Comment 327 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27

commit bee7a4ff2af4c3fab525fad724201ec7fb1f9e27
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Aug 21 13:15:01 2017

Adds missing ivar annotations on ObjC type ivars.

Some variables that are marked as "// weak" were not __weak or
__unsafe_unretained. Mark them as such, or remove the "// weak", as
necessary.

Bug:  624363 
Change-Id: I96e17d26e169095d46c4917196ceeb27b8b6e90e
Reviewed-on: https://chromium-review.googlesource.com/623230
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495922}
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.mm
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.h
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/chrome/browser/ui/static_content/static_html_native_content.mm
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/net/crn_http_protocol_handler_proxy_with_client_thread.mm
[modify] https://crrev.com/bee7a4ff2af4c3fab525fad724201ec7fb1f9e27/ios/public/provider/chrome/browser/ui/text_field_styling.h

Project Member

Comment 328 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c522964852e3aae8b07bbac5aeae5b4188f257b3

commit c522964852e3aae8b07bbac5aeae5b4188f257b3
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Aug 21 13:34:52 2017

[ObjC ARC] Converts ios/web:web to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Change-Id: Ia41029159b54a20c08af66b313fa53a3138184e7
Reviewed-on: https://chromium-review.googlesource.com/570438
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495924}
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/clean/chrome/app/steps/BUILD.gn
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/clean/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/clean/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/web/BUILD.gn
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/web/public/app/BUILD.gn
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/web/public/test/BUILD.gn
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/web/web_state/ui/crw_web_controller_container_view.h
[modify] https://crrev.com/c522964852e3aae8b07bbac5aeae5b4188f257b3/ios/web/web_state/ui/crw_web_controller_container_view.mm

Project Member

Comment 329 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37b85e8e7878067a9177bc82fecb345b633c0d18

commit 37b85e8e7878067a9177bc82fecb345b633c0d18
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu Dec 28 10:41:01 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/external_search:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I178dd59af7a4d83a4eeee8543f63ee308832ca46
Reviewed-on: https://chromium-review.googlesource.com/844715
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526289}
[modify] https://crrev.com/37b85e8e7878067a9177bc82fecb345b633c0d18/ios/public/provider/chrome/browser/external_search/BUILD.gn
[modify] https://crrev.com/37b85e8e7878067a9177bc82fecb345b633c0d18/ios/public/provider/chrome/browser/external_search/test_external_search_provider.mm

Project Member

Comment 330 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1416cdb8a6cfecc470d32279d46b238092130b79

commit 1416cdb8a6cfecc470d32279d46b238092130b79
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu Dec 28 10:42:51 2017

[ObjC ARC] Converts ios/chrome/browser/ui/history:history_base_feature to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ieb7c37d3468cd2641c1efc32a6332c6b3f21a0e3
Reviewed-on: https://chromium-review.googlesource.com/844698
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526290}
[modify] https://crrev.com/1416cdb8a6cfecc470d32279d46b238092130b79/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/1416cdb8a6cfecc470d32279d46b238092130b79/ios/chrome/browser/ui/history/history_base_feature.mm

Project Member

Comment 331 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d6b82995aa95c3484cae959e41963fa6dd66f70

commit 6d6b82995aa95c3484cae959e41963fa6dd66f70
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu Dec 28 10:44:01 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/external_search:external_search to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9b0a29f86c1d035dee1e66b5723f97d9beea31c0
Reviewed-on: https://chromium-review.googlesource.com/844734
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526291}
[modify] https://crrev.com/6d6b82995aa95c3484cae959e41963fa6dd66f70/ios/public/provider/chrome/browser/external_search/BUILD.gn
[modify] https://crrev.com/6d6b82995aa95c3484cae959e41963fa6dd66f70/ios/public/provider/chrome/browser/external_search/external_search_provider.mm

Project Member

Comment 332 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9f5fc2de639dac40c6cc956ef3caca343513099

commit c9f5fc2de639dac40c6cc956ef3caca343513099
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu Dec 28 13:48:02 2017

[ObjC ARC] Converts ios/public/provider/chrome/browser/signin:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG= 624363 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifeddb8439b21e31c2880e07286ab647ac0f6b938
Reviewed-on: https://chromium-review.googlesource.com/844774
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526294}
[modify] https://crrev.com/c9f5fc2de639dac40c6cc956ef3caca343513099/ios/public/provider/chrome/browser/signin/BUILD.gn
[modify] https://crrev.com/c9f5fc2de639dac40c6cc956ef3caca343513099/ios/public/provider/chrome/browser/signin/fake_chrome_identity.mm
[modify] https://crrev.com/c9f5fc2de639dac40c6cc956ef3caca343513099/ios/public/provider/chrome/browser/signin/fake_chrome_identity_interaction_manager.h
[modify] https://crrev.com/c9f5fc2de639dac40c6cc956ef3caca343513099/ios/public/provider/chrome/browser/signin/fake_chrome_identity_interaction_manager.mm
[modify] https://crrev.com/c9f5fc2de639dac40c6cc956ef3caca343513099/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
[modify] https://crrev.com/c9f5fc2de639dac40c6cc956ef3caca343513099/ios/public/provider/chrome/browser/signin/test_signin_resources_provider.mm

Status: Fixed (was: Assigned)
Showing comments 234 - 333 of 333 Older

Sign in to add a comment