New issue
Advanced search Search tips

Issue 624360 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

R= is not necessary anymore. Add “why” to the FAQ.

Project Member Reported by serg...@chromium.org, Jun 29 2016

Issue description

New users will be confused why R= line isn't added to Gerrit reviews if -r option is passed. Perhaps a comment should be added, e.g.

# Enter a description of the change.
# This will be displayed on the codereview site.
# The first line will also be used as the subject of the review.
#--------------------This line is 72 characters long--------------------
Foo bar CL description

BUG=

#-----------------------------------------------------------------------
R=foo@chromium.org line is not necessary anymore and Reviewed-By: food@chromium.org will instead be added after the CL is committed
 
Components: Infra>Codereview>Gerrit Infra>SDK
Status: Available (was: Untriaged)
Never thought of this, but indeed great idea.
Labels: Pri-2
Labels: Type-Bug
Labels: Milestone-Launch
Summary: R= is not necessary anymore. Add “why” to the FAQ. (was: git-cl-upload should somehow indicate that R= is not necessary anymore)
My guess is that no one will read the footer. We should still add it to the docs.
Labels: -Milestone-Launch Milestone-Afterglow
+ Add documentation saying R= not necessary.
+ Modify git cl to remove it from the commit description.
+ Get other FOO= out of the description. Tranform it to Foo: in the footer.
+ Get rid of TBR= text-based check in presubmit.
+ Remove mentions of tags.
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Status: Fixed (was: Available)

Sign in to add a comment