New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624358 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[History]Focus doesn't traverse to 'Open all' buttons on 'Synced tabs' page.

Reported by dchau...@etouch.net, Jun 29 2016

Issue description

Chrome Version:53.0.2783.2 (Official Build)65c6178c55984c82fb8bebd4999395c4b364b621-refs/branch-heads/2783@{#3} 32/64-bit.
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS).

Precondition: 
1. Enable the 'Material Design history' flag from chrome://flags.
2. sign in to browser with such accounts in which browsing history from other devices are synced.

What steps will reproduce the problem?
1. Launch chrome, navigates to chrome://history page and go to 'Synced tabs' section.
2. Now, press 'Tab' key from keyboard and observe the focus.

Focus doesn't traverse to 'Open all' buttons.
Focus should traverse to 'Open all' buttons.

This is a non regression issue seen from M-52 series i.e. build #52.0.2726.0 , as this feature is introduced from r391900

Kindly review the attached screen-cast for reference.
 
Actual screenshot.png
75.3 KB View Download
Actual behavior.mp4
1.5 MB View Download
Status: Untriaged (was: Unconfirmed)
Able to repro the issue on mac 10.11 chrome version 53.0.2783.2
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 1 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: tsergeant@chromium.org
Status: Started (was: Untriaged)
We are moving the button into a menu, which will fix this in the process.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee91629ba3a0e59591bd15f67db068bbc43dec58

commit ee91629ba3a0e59591bd15f67db068bbc43dec58
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Aug 08 05:08:54 2016

MD History: Add menu to cards on Synced Tabs page

The menu has two options, 'Open all' and 'Hide for now'. This replaces
the existing 'Open All' link at the bottom of the card.

BUG= 280665 , 624358 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2204833003
Cr-Commit-Position: refs/heads/master@{#410304}

[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/browser_service.js
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/list_container.html
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Status: Fixed (was: Started)
Labels: TE-Verified-M54 TE-Verified-54.0.2824.0
Verified the fix on Windows 7, MAC (10.11.6) for Google Chrome Dev Version - 54.0.2824.0.

This issue is pending to verify on Linux OS. Since Chrome Version - 54.0.2824.0 is not available due to "635768"

Screen-recording is attached.

TE-Verified Labels are added.
624358.mov
17.7 MB Download

Sign in to add a comment