Issue metadata
Sign in to add a comment
|
Regression: Search icon button does not work on touch screens
Reported by
jshan...@etouch.net,
Jun 29 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2783.2 (Official Build)65c6178c55984c82fb8bebd4999395c4b364b621-refs/branch-heads/2783@{#3} 32/64-bit. OS: Windows 10(Touch device) Pre-condition: Enable Material Design history from chrome://flags Steps: 1. Launch Chrome and navigate to chrome://history 2. Zoom in to 175%, tap/touch on 'Search' icon and observe Actual: Search field doesn't appear via tap/touch after zoom in to 175%. Expected: Search field should appear via tap/touch after zoom in to 175%. This is a regression issue broken in M-53, below is bisect info. Good build: 53.0.2748.0 Bad build: 53.0.2750.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/3d392de68c541604a01a0c077c44d0ba4c7a02c7..d9a96896948d55fb51b919566f7a6c5ec1fd4980?pretty=fuller&n=100 Suspecting: r396115 ? Note: This is touch device specific issue, same works fine via mouse click.
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93a84398c5b2804930aa71c542617d0beae1f470 commit 93a84398c5b2804930aa71c542617d0beae1f470 Author: tsergeant <tsergeant@chromium.org> Date: Tue Nov 29 05:47:10 2016 MD WebUI: Ensure the search field opens on touchscreen tap This fixes an issue where after touchscreen tapping the search icon, the browser would return focus to the search icon, immediately closing the search field. Using the native 'click' event instead of the simulated 'tap' event fixes this issue. BUG= 624356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2530293002 Cr-Commit-Position: refs/heads/master@{#434905} [modify] https://crrev.com/93a84398c5b2804930aa71c542617d0beae1f470/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/93a84398c5b2804930aa71c542617d0beae1f470/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/93a84398c5b2804930aa71c542617d0beae1f470/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
,
Nov 30 2016
,
Dec 1 2016
Verified the fix on Canary, requesting merge back to M56.
,
Dec 1 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6644a9da1415b7700bf9b8c00d85c78d4f42535d commit 6644a9da1415b7700bf9b8c00d85c78d4f42535d Author: Tim Sergeant <tsergeant@chromium.org> Date: Thu Dec 01 02:25:32 2016 MD WebUI: Ensure the search field opens on touchscreen tap This fixes an issue where after touchscreen tapping the search icon, the browser would return focus to the search icon, immediately closing the search field. Using the native 'click' event instead of the simulated 'tap' event fixes this issue. BUG= 624356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2530293002 Cr-Commit-Position: refs/heads/master@{#434905} (cherry picked from commit 93a84398c5b2804930aa71c542617d0beae1f470) Review URL: https://codereview.chromium.org/2541273002 . Cr-Commit-Position: refs/branch-heads/2924@{#233} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/6644a9da1415b7700bf9b8c00d85c78d4f42535d/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/6644a9da1415b7700bf9b8c00d85c78d4f42535d/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/6644a9da1415b7700bf9b8c00d85c78d4f42535d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
,
Dec 2 2016
As per Comment# 9 adding TE-Verified Labels. Thank You. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tsergeant@chromium.org
, Jun 30 2016