New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624324 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on: View detail
issue 636448
issue 643966
issue 644439
issue 644442
issue 611171
issue 639494
issue 640836
issue 643264
issue 643967

Blocking:
issue 611868
issue 632467



Sign in to add a comment

Update Google Play services to v5 (9.4)

Project Member Reported by dgn@chromium.org, Jun 29 2016

Issue description

That version has been released recently: https://developers.google.com/android/guides/releases

Problem: The monolithic JAR does not ship anymore through Android SDK Manager, so we have to update the build to work with the new binaries.
 

Comment 1 by dgn@chromium.org, Jun 29 2016

Blockedon: 611171
Blocked on AAR support: issue 611171
Cc: mariakho...@chromium.org

Comment 3 by cco3@chromium.org, Jul 20 2016

It looks like AAR support is in place.  Can play services be updated now?
Blocking: 632467
Owner: paulmiller@chromium.org
Summary: Update Google Play services to v5 (9.4) (was: Update Google Play services to 9.2)
Rolling internal now but apparently I don't have access to roll public.

Comment 7 by dgn@chromium.org, Aug 3 2016

I gave it a better look today, so:
- We still have a monolithic AAR, so not too many changes to be made
- I was afraid of conflicts with the support library AARs, the library is under extras/android/m2repo and gms under extras/google/m2repo, so it's fine!
- I should be able to send the updated script for review this week.

Comment 8 by dgn@chromium.org, Aug 3 2016

(for the public update)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/70a1fdaba2b4598f5fce58ab37b1cf3c427913e4

commit 70a1fdaba2b4598f5fce58ab37b1cf3c427913e4
Author: Paul Miller <paulmiller@google.com>
Date: Tue Aug 02 19:32:32 2016

Owner: dgn@chromium.org
back to dgn@ for public update
Blockedon: 636448
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71d53fa016887abec5807c7dfcd9e93ec0ab12a5

commit 71d53fa016887abec5807c7dfcd9e93ec0ab12a5
Author: agrieve <agrieve@chromium.org>
Date: Thu Aug 11 16:44:44 2016

Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG= 624324 

Review-Url: https://codereview.chromium.org/2227523002
Cr-Commit-Position: refs/heads/master@{#411358}

[modify] https://crrev.com/71d53fa016887abec5807c7dfcd9e93ec0ab12a5/build/android/gyp/write_build_config.py
[modify] https://crrev.com/71d53fa016887abec5807c7dfcd9e93ec0ab12a5/build/config/android/internal_rules.gni
[modify] https://crrev.com/71d53fa016887abec5807c7dfcd9e93ec0ab12a5/build/config/android/rules.gni

Blocking: 611868

Comment 14 by dgn@chromium.org, Aug 22 2016

Blockedon: 639494
The pending CL to update the library dependency is https://codereview.chromium.org/2209233002/

On hold until the downstream issues are fixed: see  issue 639494  and b/30869015

Comment 15 by dgn@chromium.org, Aug 22 2016

Status: Assigned (was: Started)
Why is that blocking? You can still roll trunk while I'm reverting m53.
I am not sure we should be rolling to v5 without agreement on what to do about the memory regression in M54 with the new GMS core.

Comment 18 by dgn@chromium.org, Aug 22 2016

Exactly, I'd prefer to have downstream always moving forward first, as building with a newer SDK is not an issue there. If we move upstream and start using new APIs, downstream builds would break and upstream developers would not be aware of it.

And in general, we want to have the same version on both sides.
Blockedon: 640836
Blockedon: 643264
Blockedon: 643966
Blockedon: 643967
Blockedon: 644439
Blockedon: 644442

Comment 27 by dgn@chromium.org, Oct 31 2016

Status: Fixed (was: Assigned)

Sign in to add a comment