Issue metadata
Sign in to add a comment
|
Disabled html select option is selectable
Reported by
tim.vanb...@trifork.nl,
Jun 29 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36 Steps to reproduce the problem: 1. Start Chromium browser on Windows 7 or Windows 10 machine with a Dell Touchscreen S224OT attached 2. Open the html 5 file with the simple select with one option disabled. (see attachment) 3. Select an enabled option. Using your finger (not with an attached mouse) select the disabled option. Note this issues can only be reproduced on a touch screen. Using an attached mouse you can't. What is the expected behavior? The disabled option should not be selectable. What went wrong? Result: You can select a disabled option which you should not be able to select. Did this work before? N/A Chrome version: 51.0.2704.103 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 22.0 r0
,
Jun 29 2016
,
Jun 30 2016
Able to reproduce the issue on Win 10(Dell Precision touch) using stable 51.0.2704.103 and canary Bisect info : ============= Good:43.0.2354.0 bad :43.0.2355.0/43.0.2356.0 Change Log: =========== https://chromium.googlesource.com/chromium/src/+log/15a16244bd70fdd1f9cd27cb73dd5e981d5aa379..af1ed79a98694c4353c4234b2b6f994532bf8cb6 Blink roll from above bisect : https://chromium.googlesource.com/chromium/blink/+log/3afa9ef..395ff9e Possible suspect : https://codereview.chromium.org/983373002 keishi@ : Could you please take a look into this if its related to your change. Note : Unable to verify on Mac and Linux due to unavailability of hardware. Removing Needs-TestConfirmation label and adding TE-NeedsTriageFromMTV to update the behaviour on Linux and Mac if available.
,
Jun 30 2016
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2016
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb2759d07dc61f89764c8e9d0e0984fec59733b8 commit cb2759d07dc61f89764c8e9d0e0984fec59733b8 Author: tkent <tkent@chromium.org> Date: Wed Sep 21 07:15:37 2016 SELECT popup: Touch input should not be able to select disabled OPTIONs. In a case of mouseup, we refer to event.target and mouse-related events are never dispatched on disabled OPTIONs. In a case of touch, we need to check disabled state manually because we don't use event.target. BUG= 624302 Review-Url: https://codereview.chromium.org/2360483002 Cr-Commit-Position: refs/heads/master@{#419993} [modify] https://crrev.com/cb2759d07dc61f89764c8e9d0e0984fec59733b8/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt [modify] https://crrev.com/cb2759d07dc61f89764c8e9d0e0984fec59733b8/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html [modify] https://crrev.com/cb2759d07dc61f89764c8e9d0e0984fec59733b8/third_party/WebKit/Source/web/resources/listPicker.js
,
Sep 23 2016
Can TE verify the fix with the latest canary?
,
Sep 23 2016
,
Sep 27 2016
I'm not sure if I actually fixed this or not, but request to merge to M54.
,
Sep 27 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 27 2016
Unfortunately we missed comment #8. Please merge your change before 4.00 PM PST today ( 09/27) so that we could take it for next beta scheduled tomorrow and will also verify the fix.
,
Sep 28 2016
Rechecked this on Chrome version 55.0.2873.3 Canary and Beta version 54.0.2840.41 on Windos 10 Dell Precision Touch laptop. Fix is working as intended. Disabled html select option cannot be selected using touch. Adding TE-Verified Labels.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a365129389733cb105d15a5da4994fd3b5a00b94 commit a365129389733cb105d15a5da4994fd3b5a00b94 Author: Kent Tamura <tkent@chromium.org> Date: Tue Sep 27 21:15:18 2016 Merge "SELECT popup: Touch input should not be able to select disabled OPTIONs." to M54. In a case of mouseup, we refer to event.target and mouse-related events are never dispatched on disabled OPTIONs. In a case of touch, we need to check disabled state manually because we don't use event.target. BUG= 624302 Review-Url: https://codereview.chromium.org/2360483002 Cr-Commit-Position: refs/heads/master@{#419993} (cherry picked from commit cb2759d07dc61f89764c8e9d0e0984fec59733b8) Review URL: https://codereview.chromium.org/2373873002 . Cr-Commit-Position: refs/branch-heads/2840@{#554} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a365129389733cb105d15a5da4994fd3b5a00b94/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt [modify] https://crrev.com/a365129389733cb105d15a5da4994fd3b5a00b94/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html [modify] https://crrev.com/a365129389733cb105d15a5da4994fd3b5a00b94/third_party/WebKit/Source/web/resources/listPicker.js
,
Sep 28 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a365129389733cb105d15a5da4994fd3b5a00b94 commit a365129389733cb105d15a5da4994fd3b5a00b94 Author: Kent Tamura <tkent@chromium.org> Date: Tue Sep 27 21:15:18 2016 Merge "SELECT popup: Touch input should not be able to select disabled OPTIONs." to M54. In a case of mouseup, we refer to event.target and mouse-related events are never dispatched on disabled OPTIONs. In a case of touch, we need to check disabled state manually because we don't use event.target. BUG= 624302 Review-Url: https://codereview.chromium.org/2360483002 Cr-Commit-Position: refs/heads/master@{#419993} (cherry picked from commit cb2759d07dc61f89764c8e9d0e0984fec59733b8) Review URL: https://codereview.chromium.org/2373873002 . Cr-Commit-Position: refs/branch-heads/2840@{#554} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a365129389733cb105d15a5da4994fd3b5a00b94/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt [modify] https://crrev.com/a365129389733cb105d15a5da4994fd3b5a00b94/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html [modify] https://crrev.com/a365129389733cb105d15a5da4994fd3b5a00b94/third_party/WebKit/Source/web/resources/listPicker.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by thestig@chromium.org
, Jun 29 2016