Move permission prompt to corner when in fullscreen |
|||||||||
Issue descriptionVersion: 53 OS: Windows, Linux, Chrome OS We've had a number of issues with fullscreen and permission prompts interacting when in fullscreen mode ( Issue 619894 , Issue 623862 ). It's really hard to change the stacking order. To mitigate this, I propose moving the permission bubble to the top-left corner of the screen, when in fullscreen mode, and adding the arrow to the bubble (so it indicates it's "coming down" from the top of the screen). I think this works better anyway as the permission bubble is very close to where it would be in non-fullscreen mode. Shown the before and after screenshots.
,
Jun 29 2016
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22beefb92cb521c2aa381431b7041f2d488c7227 commit 22beefb92cb521c2aa381431b7041f2d488c7227 Author: mgiuca <mgiuca@chromium.org> Date: Wed Jul 06 02:25:04 2016 Permission prompts show in the top-left corner in fullscreen mode. Previously they were shown in the center, which causes interference with the fullscreen notification. This way, they are treated more consistently both in and out of fullscreen mode. BUG= 623862 , 624296 TEST=On https://permission.site, click Fullscreen then Location. The location prompt should be in the top-left corner and not overlapping the "Press Esc to exit full screen" bubble. TEST=As above, but with the browser window on a secondary monitor. TEST=As above, but in Arabic or Hebrew language (should be in top-right corner). Review-Url: https://codereview.chromium.org/2109663005 Cr-Commit-Position: refs/heads/master@{#403840} [modify] https://crrev.com/22beefb92cb521c2aa381431b7041f2d488c7227/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc [modify] https://crrev.com/22beefb92cb521c2aa381431b7041f2d488c7227/chrome/browser/ui/views/website_settings/permissions_bubble_view.h [modify] https://crrev.com/22beefb92cb521c2aa381431b7041f2d488c7227/chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc
,
Jul 6 2016
,
Jul 6 2016
Completed on Views. Assigning to benwells@ for Mac.
,
Jul 6 2016
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2735281192ab10e3930275697983a06df06b8171 commit 2735281192ab10e3930275697983a06df06b8171 Author: Matt Giuca <mgiuca@chromium.org> Date: Thu Jul 07 03:07:35 2016 Permission prompts show in the top-left corner in fullscreen mode. Previously they were shown in the center, which causes interference with the fullscreen notification. This way, they are treated more consistently both in and out of fullscreen mode. BUG= 623862 , 624296 TEST=On https://permission.site, click Fullscreen then Location. The location prompt should be in the top-left corner and not overlapping the "Press Esc to exit full screen" bubble. TEST=As above, but with the browser window on a secondary monitor. TEST=As above, but in Arabic or Hebrew language (should be in top-right corner). Review-Url: https://codereview.chromium.org/2109663005 Cr-Commit-Position: refs/heads/master@{#403840} (cherry picked from commit 22beefb92cb521c2aa381431b7041f2d488c7227) Review URL: https://codereview.chromium.org/2127703006 . Cr-Commit-Position: refs/branch-heads/2785@{#38} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/2735281192ab10e3930275697983a06df06b8171/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc [modify] https://crrev.com/2735281192ab10e3930275697983a06df06b8171/chrome/browser/ui/views/website_settings/permissions_bubble_view.h [modify] https://crrev.com/2735281192ab10e3930275697983a06df06b8171/chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc
,
Jul 7 2016
,
Jul 12 2016
Verified the Issue on Win 7,Ubuntu 14.04 and Mac 10.11.5 using 53.0.2785.14 and its working fine on Win and Linux. Its not working on Mac as expected. mgiuca@ : Could you please review the attached screen cast of Mac and update further.
,
Jul 12 2016
Thanks. Those screencasts match my expectations: it isn't working on Mac yet (assigned to benwells@ for that work).
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf7360dbc5ab679e20c5f03d2b7cf52b8cd7ee65 commit cf7360dbc5ab679e20c5f03d2b7cf52b8cd7ee65 Author: benwells <benwells@chromium.org> Date: Fri Aug 12 07:00:36 2016 Position Mac permission bubbles on the left when in fullscreen. This means they will not obscure the fullscreen bubble, if it is visible. As part of this change, some code which forced the location bar to be shown when a permission bubble was visible was removed. This code isn't necessary anymore, as permission bubbles are positioned appropriately when in fullscreen. BUG= 624296 Review-Url: https://codereview.chromium.org/2233293003 Cr-Commit-Position: refs/heads/master@{#411565} [modify] https://crrev.com/cf7360dbc5ab679e20c5f03d2b7cf52b8cd7ee65/chrome/browser/ui/cocoa/browser_window_controller_private.h [modify] https://crrev.com/cf7360dbc5ab679e20c5f03d2b7cf52b8cd7ee65/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/cf7360dbc5ab679e20c5f03d2b7cf52b8cd7ee65/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm [modify] https://crrev.com/cf7360dbc5ab679e20c5f03d2b7cf52b8cd7ee65/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm [modify] https://crrev.com/cf7360dbc5ab679e20c5f03d2b7cf52b8cd7ee65/chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm
,
Aug 16 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mgiuca@chromium.org
, Jun 29 2016