New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624278 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 850825
Owner: ----
Closed: Jun 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 453190



Sign in to add a comment

Pass the web-platform-test: fetch-event.https.html

Project Member Reported by shimazu@chromium.org, Jun 29 2016

Issue description

This test is here: https://github.com/w3c/web-platform-tests/blob/master/service-workers/service-worker/fetch-event.https.html

Several problems related to this test are found at my quick investigation...

On the test of referrerPolicy (l.206):

- When referrer attribute is set to undefined, fetch API seems to handle it as "undefined". (l.221)
- The test uses fetch() to HTTP_ORIGIN though the origin of main page is on https. (l.82)
- Although he test set referrer as "fake-referrer" (l.227) and fires fetch() from an iframe under resources/, expected referrer is set to "get_host_info()['HTTPS_ORIGIN'] + base_path() + 'fake-referrer'" (l.226). I took also a look at the spec[1], but I still think this might be wrong.


[1]: https://fetch.spec.whatwg.org/#concept-request-referrer
 
Summary: Pass the web-platform-test: fetch-event.https.html (was: Fix a web-platform-test: fetch-event.https.html)

Comment 2 by falken@chromium.org, Jun 30 2016

Owner: shimazu@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ed034738fe6c86c262e5cb0466b79ca84ab65f

commit a4ed034738fe6c86c262e5cb0466b79ca84ab65f
Author: shimazu <shimazu@chromium.org>
Date: Thu Oct 20 04:43:34 2016

Import w3c tests for the service workers

This patch imports wpt tests @357b83b809e3cbc7a1805e7c3ca108a7980d782f. Many
failures are left as is, so we should file each bugs after this lands.

BUG= 602693 , 618616 , 624278 ,571722,617886
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug --enable-wptserve imported/wpt/service-workers

Review-Url: https://chromiumcodereview.appspot.com/2415873002
Cr-Commit-Position: refs/heads/master@{#426405}

[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/WPTServeExpectations
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activate-event-after-install-state-change.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activation-after-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activation.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/active.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/appcache-ordering-main.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/claim-not-using-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/claim-using-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/client-navigate.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/client-navigate.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get-cross-origin.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get-cross-origin.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-client-types.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-disconnect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-disconnect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-load.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-load.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-reload.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-reload.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-async-waituntil.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-waituntil.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-cors-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-cors-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-csp.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-csp.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-after-navigation-within-page.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-network-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-frame-resource.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-mixed-content-to-inscope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-mixed-content-to-outscope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-base-url.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-images.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-fallback.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-fallback.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-no-freshness-headers.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-redirect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-resources.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-resources.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-response-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-response-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-waits-for-activate.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistrations.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistrations.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/indexeddb.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/install-event-type.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/installing.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/interfaces.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-blobtype.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-blobtype.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-header.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-header.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/multiple-register.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/multiple-update.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigate-window.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigate-window.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigation-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/onactivate-script-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/performance-timeline.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/performance-timeline.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ready.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/referer.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/referer.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-closed-window.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-default-scope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-same-scope-different-script-url.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-wait-forever-in-install-worker.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-wait-forever-in-install-worker.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-end-to-end.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-events.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-iframe.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/rejections.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resource-timing.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resource-timing.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/404.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.install.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.is-appcached.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.is-appcached.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.manifest
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/blank.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/claim-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigated-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-other-origin.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-client-types-shared-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-shared-worker-interceptor.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-worker-interceptor.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-worker-script.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy.txt
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a97fb88d5ad4c437c60562d0083a87b898547a4

commit 6a97fb88d5ad4c437c60562d0083a87b898547a4
Author: shimazu <shimazu@chromium.org>
Date: Mon Oct 24 02:57:12 2016

Update expectations of imported/wpt/service-workers

As mentioned at  https://crbug.com/602693#c17  and  https://crbug.com/657869 ,
'[ Skip ]' in TestExpectations cannot be overwritten by WPTTestExpectations.
This patch changes '[ Skip ]' to '[ Failure ]' by default in TestExpectations
in order to run the w3c tests on WPTServe bots.

BUG= 602693 , 453190 , 624278 ,617886,571722, 618616 
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug imported/wpt/service-workers
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests --enable-wptserve -f -t Debug imported/wpt/service-workers

Review-Url: https://codereview.chromium.org/2441963002
Cr-Commit-Position: refs/heads/master@{#427010}

[modify] https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4/third_party/WebKit/LayoutTests/WPTServeExpectations

Comment 5 by falken@chromium.org, Mar 23 2017

Cc: shimazu@chromium.org yhirano@chromium.org jakearchibald@chromium.org
Owner: yiyix@chromium.org
Status: Started (was: Assigned)
Regarding: When referrer attribute is set to undefined, fetch API seems to handle it as "undefined".

This can be reproduced by checking:
new Request('', { referrer: undefined });

Chrome creates a Request whose .referrer ends with "/undefined".
Firefox creates a Request whose .referrer is "about:client"

Chrome is certainly wrong, but I'm not sure what the Fetch spec says:

"Let parsedReferrer be the result of parsing referrer with baseURL." => Not clear to me what the parse algorithm says when |referrer| is undefined.

Adding jakearchibald@ and yhirano@ if they have insight.





Comment 6 by falken@chromium.org, Mar 23 2017

Just talked to domenic@, when something is undefined, it means it is not "present" in spec language.  So we don't get into the "If init’s referrer member is present, run these substeps" part. So Firefox behavior is indeed what the spec says.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/617eed180347e987f47df9bf74ae4eb20ac04cb1

commit 617eed180347e987f47df9bf74ae4eb20ac04cb1
Author: yiyix <yiyix@chromium.org>
Date: Tue Mar 28 09:24:13 2017

Fetch API: Fix behavior when Request constructor is passed an undefined referrer

When the Request constructor was called with referrer set to undefined, the
resulting referrer used "undefined" as a string. After this code change,
an undefined referrer will be considered as not present and the default referrer
"about:client" will instead be used.

BUG= 624278 

Review-Url: https://codereview.chromium.org/2772013002
Cr-Commit-Position: refs/heads/master@{#460049}

[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-base-https-other-https-expected.txt
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-expected.txt
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/http/tests/fetch/window/request-base-https-other-https-expected.txt
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/http/tests/fetch/window/request-expected.txt
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-base-https-other-https-expected.txt
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-expected.txt
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/Source/bindings/core/v8/Dictionary.h
[modify] https://crrev.com/617eed180347e987f47df9bf74ae4eb20ac04cb1/third_party/WebKit/Source/modules/fetch/RequestInit.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e589313cfc0a5f177668275af93feedb046f783f

commit e589313cfc0a5f177668275af93feedb046f783f
Author: yiyix <yiyix@chromium.org>
Date: Wed Mar 29 01:22:50 2017

Fetch API: Remove expectation files of request.js

Fixes the "duplicate test names" error for tests in request.js,
after which all test cases in request.js pass without warnings
or errors. So the expectation files can be safely removed.

BUG= 624278 

Review-Url: https://codereview.chromium.org/2778183002
Cr-Commit-Position: refs/heads/master@{#460257}

[modify] https://crrev.com/e589313cfc0a5f177668275af93feedb046f783f/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
[delete] https://crrev.com/b663358c89e05334e8cfff0f1f855fe4c72c192a/third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-base-https-other-https-expected.txt
[delete] https://crrev.com/b663358c89e05334e8cfff0f1f855fe4c72c192a/third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-expected.txt
[delete] https://crrev.com/b663358c89e05334e8cfff0f1f855fe4c72c192a/third_party/WebKit/LayoutTests/http/tests/fetch/window/request-base-https-other-https-expected.txt
[delete] https://crrev.com/b663358c89e05334e8cfff0f1f855fe4c72c192a/third_party/WebKit/LayoutTests/http/tests/fetch/window/request-expected.txt
[delete] https://crrev.com/b663358c89e05334e8cfff0f1f855fe4c72c192a/third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-base-https-other-https-expected.txt
[delete] https://crrev.com/b663358c89e05334e8cfff0f1f855fe4c72c192a/third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-expected.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3602528ca6d0a7b9bf3b8569c1974ced69249eb7

commit 3602528ca6d0a7b9bf3b8569c1974ced69249eb7
Author: yiyix <yiyix@chromium.org>
Date: Fri Apr 07 08:40:28 2017

Fix bug in request-init-003.sub.html

According to the Fetch spec, the Request constructor is called
with |input| only, then referrer attribute will be set to
"about:client".

From fetch spec, https://fetch.spec.whatwg.org/#concept-request:
Unless the referrer is set to anther value in request, it is set to
"about:client" by default.

BUG= 624278 

Review-Url: https://codereview.chromium.org/2802153002
Cr-Commit-Position: refs/heads/master@{#462811}

[modify] https://crrev.com/3602528ca6d0a7b9bf3b8569c1974ced69249eb7/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-003.sub-expected.txt
[modify] https://crrev.com/3602528ca6d0a7b9bf3b8569c1974ced69249eb7/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-003.sub.html

See https://www.chromestatus.com/feature/4753419730419712 for the change in comment 9.
Labels: M-59
Blockedon: 453190
Labels: -M-59
Owner: ----
Status: Available (was: Started)
Blocked on Request.cache among others:

FAIL Service Worker responds to fetch event with the correct cache types assert_unreached: unexpected rejection: assert_equals: Service Worker should respond to fetch with the correct type expected "no-store" but got "default" Reached unreachable code
FAIL Service Worker should intercept EventSource assert_unreached: unexpected rejection: assert_equals: EventSource should bypass the http cache. expected "no-store" but got "default" Reached unreachable code
FAIL Service Worker responds to fetch event with the correct integrity_metadata assert_unreached: unexpected rejection: assert_equals: integrity expected "gs0nqru8KbsrIt5YToQqS9fYao4GQJXtcId610g7cCU=" but got "" Reached unreachable code

Comment 14 by leon....@intel.com, Jul 16 2017

Owner: leon....@intel.com
Status: Assigned (was: Available)
I'd like to take this issue as I've already started work for  issue 453190 .
Labels: Hotlist-Interop
   
leon.han@, can you tell me the status? I also want to fix this issue.

Comment 17 by leon....@intel.com, Oct 16 2017

Cc: leon....@intel.com
Owner: yhirano@chromium.org
Sorry this has been pending for a while at my side, re-assigning.
Thanks!
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/078ce2e85256df5b1082a7eaf7661e876500ad61

commit 078ce2e85256df5b1082a7eaf7661e876500ad61
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Oct 17 06:14:11 2017

Remove DictionaryHelper::Get(..., ExceptionState&)

No one uses it.

Bug:  775318 ,  624278 
Change-Id: I1efddd76f8a7eba5fbe4a0bf1eb12899b391baa7
Reviewed-on: https://chromium-review.googlesource.com/722299
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509289}
[modify] https://crrev.com/078ce2e85256df5b1082a7eaf7661e876500ad61/third_party/WebKit/Source/bindings/core/v8/Dictionary.h
[modify] https://crrev.com/078ce2e85256df5b1082a7eaf7661e876500ad61/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/458b9132f3d40790e848d3b7dbca6d4c67d4893f

commit 458b9132f3d40790e848d3b7dbca6d4c67d4893f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Oct 24 15:17:21 2017

Unify WebCachePolicy and mojom::FetchCacheMode

This CL replaces WebCachePolicy by mojom::FetchCacheMode. Having two
similar enums is redundant / confusing, and transferring a mojo enum
is easier than transferring a usual enum over mojo.

 - kUseProtocolCachePolicy => kDefault
 - kValidatingCacheData => kValidateCache
 - kBypassingCache => kBypassCache
 - kReturnCacheDataElseLoad => kForceCache
 - kReturnCacheDataDontLoad => kOnlyIfCached
 - kReturnCacheDataIfValid => kUnspecifiedOnlyIfCachedStrictly
 - kBypassCacheLoadOnlyFromCache => kUnspecifiedForceCacheMiss


Bug:  453190 ,  624278 
Change-Id: I9b08cc47af1769960053cc540a7db5c6a1c3820b
Reviewed-on: https://chromium-review.googlesource.com/724563
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511149}
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/public/common/BUILD.gn
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/public/renderer/associated_resource_fetcher.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/fetchers/associated_resource_fetcher_impl.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/fetchers/associated_resource_fetcher_impl.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/fetchers/multi_resolution_image_resource_fetcher.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/image_downloader/image_downloader_base.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/internal_document_state_data.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/internal_document_state_data.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/content/renderer/render_frame_impl.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/dom/DocumentWriteIntervention.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/frame/FrameTestHelpers.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/HistoryItem.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/HistoryItem.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/Source/platform/loader/fetch/ResourceRequestTest.cpp
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/8761b7bf600539b8e4ec8fb08d642a547af5815d/third_party/WebKit/public/platform/WebCachePolicy.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/458b9132f3d40790e848d3b7dbca6d4c67d4893f/third_party/WebKit/public/web/WebLocalFrame.h

Project Member

Comment 21 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8abcb4440c2292b997019c7b483564322b8c2654

commit 8abcb4440c2292b997019c7b483564322b8c2654
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Oct 26 18:28:46 2017

[Fetch API] Propagate cache mode to {Browser, ServiceWorker}

This CL propagetes "cache" property in Request to the browser and
service workers.

Bug:  453190 ,  624278 
Change-Id: I27275e2274e3dd5283bde80e090bec8a8a93b816
Reviewed-on: https://chromium-review.googlesource.com/737730
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511891}
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/common/service_worker/service_worker_fetch_request_struct_traits.h
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/common/service_worker/service_worker_types.h
[add] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/content/test/BUILD.gn
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-cache-force-cache-expected.txt
[delete] https://crrev.com/ca3ccab0a9efa18e9390dceeaf4a21d74396f8da/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-cache-no-cache-expected.txt
[delete] https://crrev.com/ca3ccab0a9efa18e9390dceeaf4a21d74396f8da/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-cache-only-if-cached-expected.txt
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/Source/modules/fetch/Request.idl
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.cpp
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/8abcb4440c2292b997019c7b483564322b8c2654/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom

Owner: ----
Status: Available (was: Assigned)
I fixed the cache mode propagation issue. Integrity test remains...
Mergedinto: 850825
Status: Duplicate (was: Available)
This is a bit stale now. Opened a new bug with current failures.

Sign in to add a comment