Regression: Browser crashes on signing into Synced Tabs in history.
Reported by
lpa...@etouch.net,
Jun 29 2016
|
|||||
Issue descriptionChrome Version: 53.0.2782.0 (Official Build) 4f1d832918c5966df3cc8ac1d23c8c1544262cee-refs/heads/master@{#402386} (32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS). Steps 1. Launch chrome and open Incognito window >> History >> Synced tabs. 2. Click on 'Sign in to chrome' button and observe. Actual: The browser crashes. Expected: The browser should not crash. This is a regression issue broken in 'M-53' and below is the Manual Regression range. Good Build : 53.0.2774.2 Bad Build : 53.0.2776.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/376ce64da64999008cca67d07c394ef7f63933b2..f791fc5aab4fd9a3c984591c366edc9f1a0145a1?pretty=fuller&n=1000 Suspecting: r401220? Crash ID f1912459-fc51-4fff-a264-0966acc1c206 (Server ID: 5bad999600000000)
,
Jun 30 2016
This is a bug related to crbug.com/596781 , which we shouldn't let MD History page appear in incognito mode.
,
Jul 1 2016
M53 is branched today (2785) and will be promoted to Beta this month.Your bug is labelled as Beta ReleaseBlock, pls make sure to land and merge the fix to M53 branch 2785 by 5:00 PM PST on Friday 07/22 (sooner the better so it gets chance to bake in M53 dev releases it self). Thank you.
,
Jul 4 2016
Correction in steps: Pre-condition: Enable the Material Design history flag from chrome://flags.
,
Jul 4 2016
@lpanse: Thanks for the update. The above issue is still reproducible on All-OS with the steps provided in original bug and in comment #4. @Ishang: Hey, would you looking into the issue ? M53 will be promote to BETA soon, we need to get this before that or feel free to change the milestone accordingly. I really appreciate your help. Thank you!
,
Jul 4 2016
Move this to the next milestone.
,
Jul 11 2016
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f057c9421a0d0a5978f93cbf13a33378cbb84a7a commit f057c9421a0d0a5978f93cbf13a33378cbb84a7a Author: tsergeant <tsergeant@chromium.org> Date: Tue Jul 12 00:46:06 2016 Disable MD History in Incognito windows All Uber pages are disabled in Incognito, which implicitly disabled non-Material history. However, Material history does not use Uber UI and so was not included in the blacklist. This CL adds chrome://history to the blacklist to explicitly disable it in Incognito windows. BUG= 596781 , 624270 Review-Url: https://codereview.chromium.org/2140493002 Cr-Commit-Position: refs/heads/master@{#404755} [modify] https://crrev.com/f057c9421a0d0a5978f93cbf13a33378cbb84a7a/chrome/browser/ui/browser_navigator.cc
,
Jul 12 2016
#8 fixes the issue by preventing MD History from opening in incognito windows. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tkonch...@chromium.org
, Jun 29 2016