Adding new firmware updater for Wacom pen digitizer and its ebuilds
Reported by
tobita.t...@wacom.co.jp,
Jun 29 2016
|
||||||||||||||
Issue descriptionPRIVACY ISSUE This is to add a new auto firmware updater for Wacom pen digitizer on Chrome OS VERSION: Chrome Version: [53.0.2773.0] + [dev] Operating System: [Linux, 3.18.0.12513-g1ce75f4, Cyan] REPRODUCTION STEPS To accomplish this, get reviewers acception for each components, ebuild scripts, shell scripts, and flash program.
,
Jun 30 2016
Honestly, this is actually not a bug, but a new program in order to flash Wacom device. I was asked to add a issue in order for tracking this change. If this thread is somewhat a problem, I'd like you to tell the reason, so that I can discuss about it to the one who asked me to do this, thanks!
,
Jun 30 2016
I am a member of the Chrome Privacy team. I asked these questions to give you a privacy sign-off. You can add me to the changelists as well.
,
Jul 1 2016
Thanks!
,
Jul 4 2016
Today, I added you on the corresponding review.
,
Jul 5 2016
Could you please answer the questions from comment #1? That would be very helpful.
,
Jul 6 2016
Yes, ebuild script downloads our firmware source codes from github and yes, the log should be entered to "/var/log/messages" by and through an existing common function.
,
Jul 7 2016
Can I take your answer as a confirmation that the firmware does not *upload* anything to the internet (statistics, models of users' handwriting, text the user has written, ...)?
,
Jul 7 2016
No it does not try to upload anything and no log will be created on upstream neither. Thanks.
,
Jul 7 2016
Thanks a lot.
,
Aug 3 2016
work is still ongoing for this. Removing privacy component as this doesn't have privacy impact.
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d1a3cf4b51dd68bb471c9ccb74495b4880b2e182 commit d1a3cf4b51dd68bb471c9ccb74495b4880b2e182 Author: Douglas Anderson <dianders@chromium.org> Date: Thu Aug 04 20:56:48 2016 CHROMIUM: config: Build in i2c_hid and i2c_chardev on rockchip We want to do this for reasons similar to those expressed in <http://crosreview.com/258820>. Basically: these devices are critical path for bootup and they need to be all taken care of before UI starts up. This CL is the equivalent of: echo 'CONFIG_I2C_CHARDEV=y' >> \ chromeos/config/arm64/chromiumos-rockchip64.flavour.config echo 'CONFIG_I2C_HID=y' >> chromeos/config/arm64/chromiumos-rockchip64.flavour.config ./chromeos/scripts/kernelconfig oldconfig ...atop an already normalized config. BUG= chromium:624262 TEST=Verified FW Update works on device at bootup Change-Id: I051408b641e3145df399535748b61e3c0b3d2058 Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/366000 Commit-Ready: Andrew de los Reyes <adlr@chromium.org> Tested-by: Andrew de los Reyes <adlr@chromium.org> Reviewed-by: Andrew de los Reyes <adlr@chromium.org> [modify] https://crrev.com/d1a3cf4b51dd68bb471c9ccb74495b4880b2e182/chromeos/config/i386/common.config [modify] https://crrev.com/d1a3cf4b51dd68bb471c9ccb74495b4880b2e182/chromeos/config/armel/common.config [modify] https://crrev.com/d1a3cf4b51dd68bb471c9ccb74495b4880b2e182/chromeos/config/base.config [modify] https://crrev.com/d1a3cf4b51dd68bb471c9ccb74495b4880b2e182/chromeos/config/arm64/chromiumos-arm64.flavour.config [modify] https://crrev.com/d1a3cf4b51dd68bb471c9ccb74495b4880b2e182/chromeos/config/arm64/chromiumos-rockchip64.flavour.config [modify] https://crrev.com/d1a3cf4b51dd68bb471c9ccb74495b4880b2e182/chromeos/config/x86_64/common.config
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/53117d959287b8424cddeb0ece5a459969641bf4 commit 53117d959287b8424cddeb0ece5a459969641bf4 Author: Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp> Date: Sun Jun 12 06:29:55 2016 Addition: wacom's specific file has been added This script downloads, compiles, and runs Wacom specific firmware flash program. BUG= chromium:624262 TEST=This scripts downloads wacom flash and conduct it Change-Id: I6a610019b301f2ae087b875620db9c4cbeeb0f49 Reviewed-on: https://chromium-review.googlesource.com/351820 Commit-Ready: Andrew de los Reyes <adlr@chromium.org> Tested-by: Andrew de los Reyes <adlr@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [add] https://crrev.com/53117d959287b8424cddeb0ece5a459969641bf4/chromeos-base/wacom_fw_flash/wacom_fw_flash-1.1.3.ebuild [add] https://crrev.com/53117d959287b8424cddeb0ece5a459969641bf4/chromeos-base/wacom_fw_flash/Manifest
,
Sep 9 2016
,
Sep 9 2016
,
Sep 9 2016
Request merge of <https://chromium-review.googlesource.com/#/c/383231/3> (improperly marked, but landed). If that's not enough to fix this, we can keep the bug open after the merge.
,
Sep 9 2016
[Automated comment] Commit may have occurred before M54 branch point (8/25/2016), needs manual review.
,
Sep 9 2016
Hi Doug, I actually realized my mistake on the BUG field and made a new bug for those two related CLs here: https://code.google.com/p/chrome-os-partner/issues/detail?id=57219 There's several other changes on this bug for the actual updater scripts that are semi-independent from the USE flag stuff so I thought it was better to separate them. I'll comment the new bug onto the CLs to prevent further confusion. We'll need to merge these changes too, but they're not quite ready yet
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/52f05ef455ccf18c7fd2441f9b3752ce055e7c27 commit 52f05ef455ccf18c7fd2441f9b3752ce055e7c27 Author: Charlie Mooney <charliemooney@chromium.org> Date: Thu Aug 18 17:40:00 2016 Add Seccomp polices for touch FW updater tools This CL adds a rule to the touch_updater ebuild to install the seccomp policies for touch updater tools that need to be run in minijail. BUG= chromium:624262 TEST=manually emerged and tested on a Kevin CQ-DEPEND=CL:351830 Change-Id: Ica339dafa118c4378a5db3c86ac5343061c65c3d Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/372327 Reviewed-by: Andrew de los Reyes <adlr@chromium.org> [modify] https://crrev.com/52f05ef455ccf18c7fd2441f9b3752ce055e7c27/chromeos-base/touch_updater/touch_updater-9999.ebuild
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_updater/+/84bd46190900251f4a21cb1dfc518d3c12fde424 commit 84bd46190900251f4a21cb1dfc518d3c12fde424 Author: Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp> Date: Sun Jun 12 06:34:06 2016 Add Wacom touch FW updater script This CL adds a touch firmware updater script for Wacom touch sensors. This checks the firmware version on disk and compares it to the current active FW version on the touch IC and updates it accordingly. The actual updates are performed using a commandline tool called wacom_update. CQ-DEPEND=CL:372327 BUG= chromium:624262 TEST=Deployed on a device including a Wacom touchscreen and rebooted, the firmware script updates the firmware when needed and chooses not to when the firmware version is up to date. Change-Id: If9b22192f66a0dd434fa2030721fa2f4c98f7a49 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/351830 Reviewed-by: Andrew de los Reyes <adlr@chromium.org> [add] https://crrev.com/84bd46190900251f4a21cb1dfc518d3c12fde424/policies/wacom_flash.query.policy [add] https://crrev.com/84bd46190900251f4a21cb1dfc518d3c12fde424/scripts/chromeos-wacom-touch-firmware-update.sh [add] https://crrev.com/84bd46190900251f4a21cb1dfc518d3c12fde424/policies/wacom_flash.update.policy [modify] https://crrev.com/84bd46190900251f4a21cb1dfc518d3c12fde424/scripts/chromeos-touch-update.conf
,
Sep 10 2016
Should we mark this one as Fixed then and continue work in other bugs?
,
Sep 12 2016
Yep, this should be wrapped up at this point apart from a dependency on issue 645523 . We can merge these changes into 54 safely though without it (the dependency is just fixing some output values, so it's not so much a functional dependency as a usability issue). Requesting merge permission for the CLs in comment #19 and #20 -- these CLs just add in the Wacom touch firmware updater which should only effect Kevin.
,
Sep 12 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_updater/+/f4b8a628c6055a8327b1734a3f2ec43f5ebfd074 commit f4b8a628c6055a8327b1734a3f2ec43f5ebfd074 Author: Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp> Date: Sun Jun 12 06:34:06 2016 Add Wacom touch FW updater script This CL adds a touch firmware updater script for Wacom touch sensors. This checks the firmware version on disk and compares it to the current active FW version on the touch IC and updates it accordingly. The actual updates are performed using a commandline tool called wacom_update. CQ-DEPEND=CL:372327 BUG= chromium:624262 TEST=Deployed on a device including a Wacom touchscreen and rebooted, the firmware script updates the firmware when needed and chooses not to when the firmware version is up to date. Change-Id: If9b22192f66a0dd434fa2030721fa2f4c98f7a49 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/351830 Reviewed-by: Andrew de los Reyes <adlr@chromium.org> (cherry picked from commit 84bd46190900251f4a21cb1dfc518d3c12fde424) Reviewed-on: https://chromium-review.googlesource.com/384611 [add] https://crrev.com/f4b8a628c6055a8327b1734a3f2ec43f5ebfd074/policies/wacom_flash.query.policy [add] https://crrev.com/f4b8a628c6055a8327b1734a3f2ec43f5ebfd074/scripts/chromeos-wacom-touch-firmware-update.sh [add] https://crrev.com/f4b8a628c6055a8327b1734a3f2ec43f5ebfd074/policies/wacom_flash.update.policy [modify] https://crrev.com/f4b8a628c6055a8327b1734a3f2ec43f5ebfd074/scripts/chromeos-touch-update.conf
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8786680d6b741aac231451b155fb33775744e7dd commit 8786680d6b741aac231451b155fb33775744e7dd Author: Charlie Mooney <charliemooney@chromium.org> Date: Thu Aug 18 17:40:00 2016 Add Seccomp polices for touch FW updater tools This CL adds a rule to the touch_updater ebuild to install the seccomp policies for touch updater tools that need to be run in minijail. BUG= chromium:624262 TEST=manually emerged and tested on a Kevin CQ-DEPEND=CL:351830 Change-Id: Ica339dafa118c4378a5db3c86ac5343061c65c3d Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/372327 Reviewed-by: Andrew de los Reyes <adlr@chromium.org> (cherry picked from commit 52f05ef455ccf18c7fd2441f9b3752ce055e7c27) Reviewed-on: https://chromium-review.googlesource.com/384612 [modify] https://crrev.com/8786680d6b741aac231451b155fb33775744e7dd/chromeos-base/touch_updater/touch_updater-9999.ebuild
,
Sep 12 2016
Allright, merge into 54, should be all set.
,
Sep 28 2016
Still not updating on Kevin (fw in progress), but at least we now see errors about that! |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by battre@chromium.org
, Jun 29 2016