VEA test fails on alignment issue |
||||||||||||
Issue descriptionVersion: 8504.0.0 OS: ChromeOS What steps will reproduce the problem? (1) Run VEA test: ./video_encode_accelerator_unittest --test_stream_data=bear_320x192_40frames.yuv:320:192:11:out1.vp8:200000:30:200000:30 --v --gtest_filter=SimpleEncode/VideoEncodeAcceleratorTest.TestSimpleEncode/0 It gave the following error: ../../media/gpu/video_encode_accelerator_unittest.cc:302: Failure Value of: 0 Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63 Which is: 16 File should be mapped at a 64 byte boundary
,
Jun 29 2016
,
Jun 29 2016
,
Jun 29 2016
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b79f630424367d6d65de0e7e0a8e80a823e79952 commit b79f630424367d6d65de0e7e0a8e80a823e79952 Author: lionel.g.landwerlin <lionel.g.landwerlin@intel.com> Date: Fri Jul 01 10:49:09 2016 media: VEA unittest: make sure allocated memory is 64byte aligned When running video_encode_accelerator_unittest : ../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure Value of: 0 Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63 Which is: 32 File should be mapped at a 64 byte boundary Also reuse base::bits::Align. BUG= 624254 TEST=video_encode_accelerator_unittest Review-Url: https://codereview.chromium.org/2110063002 Cr-Commit-Position: refs/heads/master@{#403435} [modify] https://crrev.com/b79f630424367d6d65de0e7e0a8e80a823e79952/media/gpu/video_encode_accelerator_unittest.cc
,
Jul 1 2016
I'll request a merge after chrome uprev.
,
Jul 5 2016
Low risk fix and it only affects the test. Requesting a merge to M52 and M53.
,
Jul 5 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jul 5 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 5 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jul 8 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/341905a75a513580e7c1ceaa9b10ac0cbc90d08a commit 341905a75a513580e7c1ceaa9b10ac0cbc90d08a Author: Wu-Cheng Li <wuchengli@chromium.org> Date: Mon Jul 11 03:11:36 2016 media: VEA unittest: make sure allocated memory is 64byte aligned When running video_encode_accelerator_unittest : ../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure Value of: 0 Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63 Which is: 32 File should be mapped at a 64 byte boundary Also reuse base::bits::Align. BUG= 624254 TEST=video_encode_accelerator_unittest Review-Url: https://codereview.chromium.org/2110063002 Cr-Commit-Position: refs/heads/master@{#403435} (cherry picked from commit b79f630424367d6d65de0e7e0a8e80a823e79952) Review URL: https://codereview.chromium.org/2134013002 . Cr-Commit-Position: refs/branch-heads/2785@{#71} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/341905a75a513580e7c1ceaa9b10ac0cbc90d08a/media/gpu/video_encode_accelerator_unittest.cc
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb0c66d9017ce9b345a46a5d0cee0a52a3fa83f3 commit cb0c66d9017ce9b345a46a5d0cee0a52a3fa83f3 Author: Wu-Cheng Li <wuchengli@chromium.org> Date: Mon Jul 11 03:24:07 2016 media: VEA unittest: make sure allocated memory is 64byte aligned When running video_encode_accelerator_unittest : ../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure Value of: 0 Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63 Which is: 32 File should be mapped at a 64 byte boundary Also reuse base::bits::Align. BUG= 624254 TEST=video_encode_accelerator_unittest Review-Url: https://codereview.chromium.org/2110063002 Cr-Commit-Position: refs/heads/master@{#403435} (cherry picked from commit b79f630424367d6d65de0e7e0a8e80a823e79952) Review URL: https://codereview.chromium.org/2135073002 . Cr-Commit-Position: refs/branch-heads/2743@{#605} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/cb0c66d9017ce9b345a46a5d0cee0a52a3fa83f3/media/gpu/video_encode_accelerator_unittest.cc
,
Jul 11 2016
,
Jan 13 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by shenghao@chromium.org
, Jun 29 2016