Many android lint suppressions being ignored when building with GN |
|||
Issue descriptionOur suppressions.xml file: https://cs.chromium.org/chromium/src/build/android/lint/suppressions.xml?q=suppressions+file:lint&sq=package:chromium&dr=C&l=7 Contains many paths to .java files. However, when building with GN, .java files are copied to /tmp before running, so the suppressions are not being applied.
,
Aug 12 2016
This is easily worked-around by using regexp rather than path in the suppressions file. We just need to update the suppress.py script to do this (or delete the suppress.py script in favour of manually editing suppressions.xml) https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md
,
Aug 12 2016
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06ed71dfa04dd2cd44a4802630ddf192312ea61a commit 06ed71dfa04dd2cd44a4802630ddf192312ea61a Author: estevenson <estevenson@chromium.org> Date: Mon Aug 22 23:51:49 2016 Handle temporary file paths in suppress.py. This CL ensures that lint suppressions added with suppress.py don't depend on temporary file paths. BUG= 624234 Review-Url: https://codereview.chromium.org/2241563005 Cr-Commit-Position: refs/heads/master@{#413586} [modify] https://crrev.com/06ed71dfa04dd2cd44a4802630ddf192312ea61a/build/android/lint/suppress.py
,
Aug 23 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by agrieve@chromium.org
, Jul 27 2016