New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624211 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

PaymentRequestTests are breaking the Android Tests (dbg) builder

Project Member Reported by khushals...@chromium.org, Jun 29 2016

Issue description

The change that broke is this one: https://codereview.chromium.org/2108623004

Fix is coming through.

 
Cc: dfalcant...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d838a56193c7994c3abb9e9cfc1462a7e19d5f53

commit d838a56193c7994c3abb9e9cfc1462a7e19d5f53
Author: rouslan <rouslan@chromium.org>
Date: Wed Jun 29 01:52:30 2016

Remove incorrect asserts in PaymentRequest

When creating a new contact, the AutofillContact object is created with
both null phone number and null email address. Therefore, asserts that
one of them should be not null are not correct. This patch removes these
asserts.

BUG= 624211 

Review-Url: https://codereview.chromium.org/2101983004
Cr-Commit-Position: refs/heads/master@{#402642}

[modify] https://crrev.com/d838a56193c7994c3abb9e9cfc1462a7e19d5f53/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/d838a56193c7994c3abb9e9cfc1462a7e19d5f53/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java

Status: Fixed (was: Started)

Sign in to add a comment