New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624206 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Crash in content::OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl

Project Member Reported by ClusterFuzz, Jun 29 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6553782473457664

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x00000007
Crash State:
  content::OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl
  mojo::StrongBinding<content::mojom::FrameFactory>::OnConnectionError
  mojo::internal::BindingState<content::mojom::LevelDBObserver,0>::RunConnectionEr
  

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97ZqD8kwZOHkkiVZu9IHkPY8ceJZPhK944ygRloizUfa5GGZ6HEG2nXj-VF5r6OERxsU98JJNecbeGWn4kVZbwIQiHLDPN4fyuH5OYq3XVaGbFEeqzbOJpboFFD7W-vNGiXJ8OWss6I4iHVR0HzTLUd6sPIbQ?testcase_id=6553782473457664


Filer: mmohammad

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Owner: roc...@chromium.org
Status: Assigned (was: Available)
Suspected CL could be
https://chromium.googlesource.com/chromium/src/+/c383dde80197ffd21e23d89eddf0b7a4d819a3de%5E%21/mojo/public/cpp/bindings/lib/router.cc

Last updated by rockot@ weeks ago , please have a look and reassign if needed.

Thank you

Comment 2 by roc...@chromium.org, Jun 29 2016

Cc: roc...@chromium.org
Owner: xlai@chromium.org
mojo::StrongBinding is doing exactly what it's supposed to do. I suspect this might be related to https://codereview.chromium.org/2087383002.

Comment 3 by xlai@chromium.org, Jun 29 2016

Status: Started (was: Assigned)
Looks like the class doesn't handle the case when connection has error. Fixing it now.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc6d8be3a8408f452c52d7a8d0ac9529fc8c0cf1

commit cc6d8be3a8408f452c52d7a8d0ac9529fc8c0cf1
Author: xlai <xlai@chromium.org>
Date: Wed Jun 29 23:35:21 2016

Fix Crash on destructor of OffscreenCanvasSurfaceImpl during ConnectionError

TBR=junov@chromium.org
BUG= 624206 

Review-Url: https://codereview.chromium.org/2102973005
Cr-Commit-Position: refs/heads/master@{#402991}

[modify] https://crrev.com/cc6d8be3a8408f452c52d7a8d0ac9529fc8c0cf1/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Project Member

Comment 5 by ClusterFuzz, Jun 30 2016

ClusterFuzz has detected this testcase as flaky and is unable to reproduce it in the original crash revision. Skipping fixed testing check and marking it as potentially fixed.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6553782473457664

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x00000007
Crash State:
  content::OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl
  mojo::StrongBinding<content::mojom::FrameFactory>::OnConnectionError
  mojo::internal::BindingState<content::mojom::LevelDBObserver,0>::RunConnectionEr
  

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97ZqD8kwZOHkkiVZu9IHkPY8ceJZPhK944ygRloizUfa5GGZ6HEG2nXj-VF5r6OERxsU98JJNecbeGWn4kVZbwIQiHLDPN4fyuH5OYq3XVaGbFEeqzbOJpboFFD7W-vNGiXJ8OWss6I4iHVR0HzTLUd6sPIbQ?testcase_id=6553782473457664


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 6 by xlai@chromium.org, Jun 30 2016

Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment