New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624204 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Use ContextUtils in PhysicalWeb

Project Member Reported by cco3@chromium.org, Jun 29 2016

Issue description

The Physical Web code requires a lot of passing around contexts where not necessary, because we just want the Application.

 

Comment 1 by cco3@chromium.org, Jun 29 2016

Labels: OS-Android
Owner: cco3@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b444c43df71f607a72e47e234d23801c5bdff42e

commit b444c43df71f607a72e47e234d23801c5bdff42e
Author: cco3 <cco3@chromium.org>
Date: Thu Jul 07 22:04:37 2016

Use ContextUtils in PhysicalWeb

The Physical Web code currently requires a lot of passing around
Contexts where not necessary because we just want the Application.
This change uses ContextUtils.getApplicationContext() when applicable.

BUG= 624204 

Review-Url: https://codereview.chromium.org/2108983002
Cr-Commit-Position: refs/heads/master@{#404238}

[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ClearNotificationAlarmReceiver.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

Comment 3 by cco3@chromium.org, Jul 18 2016

Status: Fixed (was: Started)

Sign in to add a comment