New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624201 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 624584



Sign in to add a comment

Kiosk test suite flaky

Project Member Reported by petewil@chromium.org, Jun 29 2016

Issue description

Multiple tests from the Kiosk test suite seem to be flaking out.  Here are some sample failures.  Let's disable the tests if we can't fix it soon, and then fix the tests.


Assgning to AFakhry to take and initial look, and properly set the components.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/21953

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/15670

Builder:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29

Failed tests:
KioskTest.LaunchAppWithNetworkConfigAccelerator in build 21931
KioskTest.PRE_LaunchAppNetworkDown in build 21926
KioskTest.LaunchAppUserCancel in build 21922
KioskTest.LaunchAppWithNetworkConfigAccelerator in build 21918
 
Cc: xiy...@chromium.org
Labels: OS-Chrome
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d056e7e6f2591527523c92b429d70b5df3c3114f

commit d056e7e6f2591527523c92b429d70b5df3c3114f
Author: petewil <petewil@chromium.org>
Date: Wed Jun 29 19:41:34 2016

Comment out frequently flaky PrivateStore test

This has been failing a lot on the waterfall, commenting it out
until it can be investigated and re-enabled

BUG= 624201 

TBR=dzhioev

Review-Url: https://codereview.chromium.org/2113433002
Cr-Commit-Position: refs/heads/master@{#402903}

[modify] https://crrev.com/d056e7e6f2591527523c92b429d70b5df3c3114f/chrome/browser/chromeos/login/kiosk_browsertest.cc

Blockedon: 624584

Comment 5 by glevin@chromium.org, Jun 30 2016

Cc: glevin@chromium.org jen...@chromium.org
This looks like the same thing as  Issue 612688 . afakhry@, you should chat with 	jennyz@ about which to DUP and so forth.
Cc: rdevlin....@chromium.org asargent@chromium.org
asargent or rdevlin, I have multiple tests failing locally because a bunch of extensions are pending to be installed. Those extensions strangely pre-populated in the browser tests by the policy handler: ExtensionInstallForcelistPolicyHandler.

The kiosk app remains waiting and never launches waiting for them to be installed, which never happens. Those pending extensions are: 

ExtensionInstallForcelistPolicyHandler

abjoigjokfeibfhiahiijggogladbmfm
aihpiglmnhnhijdnjghpfnlledckkhja
beknehfpfkghjoafdifaflglpjkojoco
gbchcmhmhahfdphkhkmpfmihenigjmpp
noondiphcddnnabmjcihcjfbhfklnnep

I failed to find where they were added. It's seems they get added when the profile's local store gets created.
I'm stuck at this point, can you please help?

Comment 7 by xiy...@chromium.org, Jun 30 2016

Those looks like from corp policy:

abjoigjokfeibfhiahiijggogladbmfm -> Google Corporate Extension Reporter
aihpiglmnhnhijdnjghpfnlledckkhja -> BeyondCorp
...

Not sure how we could be able to get this list in a browser tests though. :(
I'm assuming this is on a Goobuntu Linux machine? 

Are you testing just a plain local build (ie chromium branded) or a Google Chrome branded build? 

If Chromium/Unbranded:
-Do you happen to have the directory /etc/chromium/policies/, and are there any subdirs/files in there?

If Google Chrome:
-You're likely getting these values from /etc/opt/chrome/policies/managed/extension_install_forcelist.json

If you're testing Google Chrome and getting the values from /etc/opt/chrome, those entries are placed there via some Goobuntu management facility - you may be able to temporarily clobber them temporarily but I wouldn't be surprised if they came back soon. 

Does it make sense for kiosk mode to check the local filesystem for local enterprise policy entries like regular desktop linux chrome? I assume that's not how actual chromeos kiosk devices in the field get their policy values, right? If maybe we should disable the code that reads from these in kiosk mode. 

I originally saw this on the chromium buildbots while I was sheriffing.  Not sure if they should have google corp policy extensions installed or not, but I would be surprised if they were.

So it was closer to a plain local build than a google chrome branded build, and it was running unit tests.
There are multiple failures here:
1. Gaia screen shows up during launch (after showing the launch splash screen)
  afakhry@ has a pending fix: https://codereview.chromium.org/2107353002/

2. DCHECK in ShowShelf at the end of kiosk app launching,  issue 624584 

3. Kiosk launch time out, this is what afakhry@ is trying to figure out. When I saw this on his box, the launching code is waiting for extension service to finish all pending extension installs (the list in #6). It is really puzzling where does browser_tests get this list. The browser_tests is supposed to run in an isolated env.

My guess is afakhry@ is building browser_tests of an official build (i.e. Google Chrome) flavor. And somehow the browser_tests in that config still reads the dir  asargent@ mentioned.

But that should not be the case on build bots, right?
asargent and xiyuan, thank you very much!

Re #8: I am indeed building with branding=Chrome, and I do have the file /etc/opt/chrome/policies/managed/extension_install_forcelist.json which contains those extension IDs in #6.

Now It's quite clear where they're coming from. A browser test, however, should probably ignore these policies.
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5933575e915ee8002f604b7f8cdee2b544ea3a5f

commit 5933575e915ee8002f604b7f8cdee2b544ea3a5f
Author: afakhry <afakhry@chromium.org>
Date: Fri Jul 01 14:45:28 2016

Fix the flaky test KioskTest.LaunchAppUserCancel

BUG= 624201 
TEST=browser_tests --gtest_filter=KioskTest.LaunchAppUserCancel

Review-Url: https://codereview.chromium.org/2107353002
Cr-Commit-Position: refs/heads/master@{#403455}

[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/chromeos/login/app_launch_signin_screen.h
[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/chromeos/login/ui/webui_login_display.cc
[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/chromeos/login/ui/webui_login_display.h
[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Status: Fixed (was: Started)
Labels: VerifyIn-54
Labels: VerifyIn-55

Comment 17 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 18 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 19 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 20 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 21 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 23 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment