New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624194 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 425627



Sign in to add a comment

MD Settings: missing "Use system title bar and borders"

Project Member Reported by michae...@chromium.org, Jun 28 2016

Issue description

Item is in Appearance in old Options but not in MD Settings.

The relevant pref is browser.custom_chrome_frame.
 
Cc: dschuyler@chromium.org
Labels: Hotlist-MD-Settings-Appearance
Status: Available (was: Untriaged)
Linux-only settings, good catch! Could you please attach a screenshot so we know where in the order it should go?

Could you also check (perhaps in the code) if there are any more Linux-only settings that exist?
 Issue 625012  has been merged into this issue.
Cc: dbeam@chromium.org
In Options, this checkbox is the last item in the Appearance section, below "Always show the bookmarks bar".

Re other missing settings: this is something we need to do and track in an organized manner, for all platforms, for all aspects of Options, preferably on a per-section basis by people who are familiar with those sections.

Comment 4 by dbeam@chromium.org, Jul 6 2016

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5acada556e627b6c3aceddd38fc9d9702d8d453a

commit 5acada556e627b6c3aceddd38fc9d9702d8d453a
Author: dbeam <dbeam@chromium.org>
Date: Thu Jul 07 00:45:45 2016

MD Settings: add "Use system title bar and borders"

Also, shuffle around how some strings and logic work. We really only
support removing window decorations on desktop Linux.

R=thestig@chromium.org
BUG= 624194 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2128703002
Cr-Commit-Position: refs/heads/master@{#404025}

[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/app/generated_resources.grd
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/browser/ui/views/frame/system_menu_model_delegate.cc
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/common/pref_names.cc
[modify] https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a/chrome/common/pref_names.h

Comment 6 by dbeam@chromium.org, Jul 7 2016

Status: Fixed (was: Started)

Sign in to add a comment