New issue
Advanced search Search tips

Issue 624191 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 603217



Sign in to add a comment

PIN keyboard should use enter to submit when focus is not on a button

Project Member Reported by jdufault@chromium.org, Jun 28 2016

Issue description

Repro instructions:

1. Lock the screen with the PIN keyboard
2. Press 1 with the mouse
3. Hit enter on the keyboard

The enter should be treated as a submit, not as an additional 1.

Enter should still submit a '1' if the user has explicitly tabbed to 1, though.
 
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8327e6e81fc97b5b2c3480c2671b6225e85d6c

commit 9c8327e6e81fc97b5b2c3480c2671b6225e85d6c
Author: sammiequon <sammiequon@chromium.org>
Date: Wed Jul 13 02:20:46 2016

Pin keyboard use enter to submit when focus is not on a button.

BUG= 624191 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2119713003
Cr-Commit-Position: refs/heads/master@{#404904}

[modify] https://crrev.com/9c8327e6e81fc97b5b2c3480c2671b6225e85d6c/chrome/browser/resources/chromeos/quick_unlock/compiled_resources2.gyp
[modify] https://crrev.com/9c8327e6e81fc97b5b2c3480c2671b6225e85d6c/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js

Status: Fixed (was: Started)

Sign in to add a comment