New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624184 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Use ContextUtils.getApplicationContext() in PrivacyPreferenceManager

Project Member Reported by cco3@chromium.org, Jun 28 2016

Issue description

The context parameter for the PrivacyPreferencesManager initializer is 
superfluous given that we just use it to get the app context.  The new
ContextUtils.getApplicationContext() does this this through a static 
method.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/814dd6ada11ce9b79feb7994a75d67c49d18ab63

commit 814dd6ada11ce9b79feb7994a75d67c49d18ab63
Author: cco3 <cco3@chromium.org>
Date: Wed Jun 29 17:28:01 2016

Remove parameter from Privacy prefs initializer

The context parameter for the PrivacyPreferencesManager initializer is
superfluous given that we just use it to get the app context.  The new
ContextUtils.getApplicationContext() does this this through a static
method.  This change removes the context parameter and updates all
client code.

BUG= 624184 

Review-Url: https://codereview.chromium.org/2105183002
Cr-Commit-Position: refs/heads/master@{#402850}

[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/CrashDumpUploadPreference.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java
[modify] https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

Comment 2 by cco3@chromium.org, Jul 6 2016

Status: Fixed (was: Started)

Sign in to add a comment