It's needed by a few things.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06ef3e319e3d9bd68798044b19199c3322b4beb5 commit 06ef3e319e3d9bd68798044b19199c3322b4beb5 Author: sky <sky@chromium.org> Date: Tue Aug 30 15:39:49 2016 Moves WorkspaceEventHandler to ash/common And wires up appropriately. BUG= 624173 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2285703003 Cr-Commit-Position: refs/heads/master@{#415302} [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/ash.gyp [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/aura/wm_shell_aura.h [rename] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/common/wm/workspace/workspace_event_handler.cc [rename] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/common/wm/workspace/workspace_event_handler.h [rename] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/common/wm/workspace/workspace_event_handler_test_helper.cc [rename] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/common/wm/workspace/workspace_event_handler_test_helper.h [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/common/wm_shell.h [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/common/wm_window.h [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/mus/BUILD.gn [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/mus/bridge/wm_shell_mus.h [add] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/mus/bridge/workspace_event_handler_mus.cc [add] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/mus/bridge/workspace_event_handler_mus.h [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/mus/move_event_handler.cc [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/mus/move_event_handler.h [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/wm/workspace/multi_window_resize_controller_unittest.cc [add] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/wm/workspace/workspace_event_handler_aura.cc [add] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/wm/workspace/workspace_event_handler_aura.h [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/wm/workspace_controller.cc [modify] https://crrev.com/06ef3e319e3d9bd68798044b19199c3322b4beb5/ash/wm/workspace_controller_test_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f71e6c9fa86982eed0647462082293803e39c9e6 commit f71e6c9fa86982eed0647462082293803e39c9e6 Author: sky <sky@chromium.org> Date: Tue Aug 30 18:49:19 2016 Moves WorkspaceController to ash/common I move creation to RootWindowControllerCommon, but I think RootWindowControllerCommon should go away. I'm going to do that next, which will result in some additional cleanup. BUG= 624173 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2292183003 Cr-Commit-Position: refs/heads/master@{#415374} [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/ash.gyp [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/aura/wm_root_window_controller_aura.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/common/root_window_controller_common.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/common/root_window_controller_common.h [rename] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/common/wm/workspace_controller.cc [rename] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/common/wm/workspace_controller.h [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/mus/root_window_controller.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/root_window_controller.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/root_window_controller.h [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/shell.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/window_animations.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/window_animations_unittest.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/workspace/multi_window_resize_controller_unittest.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/workspace_controller_test_helper.cc [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/workspace_controller_test_helper.h [modify] https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6/ash/wm/workspace_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d053905c2b58bb469a09d3f857d59d206c4a78b4 commit d053905c2b58bb469a09d3f857d59d206c4a78b4 Author: sky <sky@chromium.org> Date: Tue Aug 30 22:37:35 2016 Merges RootWindowControllerCommon into WmRootWindowController And some minor cleanup as a result. I left GetWorkspaceWindowState() in WmRootWindowController as it's a bit tedious to dig it out the WorkspaceController. BUG= 624173 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2297893002 Cr-Commit-Position: refs/heads/master@{#415465} [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/ash.gyp [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/aura/wm_root_window_controller_aura.cc [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/aura/wm_root_window_controller_aura.h [delete] https://crrev.com/e7c1b2121a2baf2ebb7cf93a2a669352a6059506/ash/common/root_window_controller_common.h [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/common/wm/workspace_controller.cc [rename] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/common/wm_root_window_controller.cc [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/common/wm_root_window_controller.h [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/mus/bridge/wm_root_window_controller_mus.cc [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/mus/bridge/wm_root_window_controller_mus.h [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/mus/root_window_controller.cc [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/mus/root_window_controller.h [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/mus/test/wm_test_helper.cc [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/mus/test/wm_test_helper.h [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/root_window_controller.cc [modify] https://crrev.com/d053905c2b58bb469a09d3f857d59d206c4a78b4/ash/root_window_controller.h
This was long ago fixed.
Comment 1 by sky@chromium.org
, Jun 28 2016