At this point, it's mostly there. This are some remaining integration points that need to be ported. And the tests aren't all the way there yet either.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8335eeddd6a5bc06515eb7c577a9196112f4583c commit 8335eeddd6a5bc06515eb7c577a9196112f4583c Author: sky <sky@chromium.org> Date: Thu Oct 06 23:25:09 2016 Converts most of WorkspaceLayoutManager tests to use common code A couple triggers crashes, which I've filed separately. The keyboard ones won't work in mash. I plan to move those out of this file separately. BUG= 624172 , 652871 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2391153002 Cr-Commit-Position: refs/heads/master@{#423732} [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/BUILD.gn [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/aura/wm_window_aura.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/aura/wm_window_aura.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/test/ash_test.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/test/ash_test.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/test/ash_test_impl.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/wm/default_state.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/wm/fullscreen_window_finder.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/wm_window.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/bridge/wm_window_mus.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/test/ash_test_impl_mus.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/test/ash_test_impl_mus.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/test/wm_test_base.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/system/chromeos/power/power_event_observer_unittest.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_base.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_base.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_impl_aura.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_impl_aura.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/test_session_state_delegate.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/test_session_state_delegate.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ui/aura/window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b commit 9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b Author: sky <sky@chromium.org> Date: Mon Oct 10 16:57:49 2016 Moves most of WorkspaceLayoutManagerTest into ash/common Parts using the keyboard, which isn't refactored yet, remain in ash/wm. BUG= 624172 TEST=test only changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2402643004 Cr-Commit-Position: refs/heads/master@{#424171} [modify] https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b/ash/BUILD.gn [modify] https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b/ash/common/BUILD.gn [add] https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b/ash/common/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b/ash/mus/BUILD.gn [add] https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc
[Automated comment] removing mislabelled merge-merged-2840
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b25fc47b3517d87ea086cea8a6b96a562c2dee01 commit b25fc47b3517d87ea086cea8a6b96a562c2dee01 Author: msw <msw@chromium.org> Date: Fri Feb 17 22:42:33 2017 Remove unreferenced workspace_layout_manager_unittest.cc This file is unreferenced after (and should have been removed by): https://codereview.chromium.org/2402643004 BUG= 624172 TEST=NONE R=sky@chromium.org Review-Url: https://codereview.chromium.org/2703853003 Cr-Commit-Position: refs/heads/master@{#451391} [delete] https://crrev.com/e0ee33c5a7febbfffbe75d12d21a7eb159d88d73/ash/wm/workspace/workspace_layout_manager_unittest.cc
This was long ago fixed.
Comment 1 by sky@chromium.org
, Jun 28 2016