shell_surface should use the event handler of the widget's window, not on the shell. |
|||
Issue descriptionIt's using event handler on shell, which can receive event even during modal state. It should listen the event on the widget's window instead.
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dd03dd13d630af3457d4f43beead3b83e95956a commit 0dd03dd13d630af3457d4f43beead3b83e95956a Author: hariank <hariank@google.com> Date: Thu Jul 14 23:47:33 2016 Keep the SystemModalContainerEventHandler added, and check the modality in the event handler, instead of adding/removing the event handler. Ensures that pointer/touch events on Arc windows are not registered when a system modal is open. BUG=624168 TEST=PointerTest.IgnorePointerEventDuringModal,TouchTest.IgnoreTouchEventDuringModal Review-Url: https://codereview.chromium.org/2127263002 Cr-Commit-Position: refs/heads/master@{#405632} [modify] https://crrev.com/0dd03dd13d630af3457d4f43beead3b83e95956a/ash/shell.cc [modify] https://crrev.com/0dd03dd13d630af3457d4f43beead3b83e95956a/ash/shell.h [modify] https://crrev.com/0dd03dd13d630af3457d4f43beead3b83e95956a/ash/wm/system_modal_container_event_filter.cc [modify] https://crrev.com/0dd03dd13d630af3457d4f43beead3b83e95956a/components/exo/pointer_unittest.cc [modify] https://crrev.com/0dd03dd13d630af3457d4f43beead3b83e95956a/components/exo/touch_unittest.cc
,
Jan 3 2017
This owner is not able to receive e-mails, please re-triage.
,
Jul 6
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, Jul 1 2016