New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624156 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 399828
issue 483268
issue 624377

Blocking:
issue 491419
issue 624511



Sign in to add a comment

Remove Win AMD bots from Chromium's commit queue

Project Member Reported by kbr@chromium.org, Jun 28 2016

Issue description

In Issue 614526, more bots with NVIDIA GPUs were deployed onto Chromium's commit queue. The Chromium project is facing scalability problems with the GPU machines. Some of the configurations are either over capacity or near capacity. The Windows machines with AMD GPUs are one of these configurations. It is necessary to either buy more such machines or stop loading them so heavily.

For this reason the Windows AMD configuration will be removed from Chromium's commit queue. The drivers have unfortunately been unreliable from the start (see  Issue 491419 ). They will continue to be run against ANGLE's tryjobs, and could be run against other key components (Skia and V8's rolls come to mind).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b

commit 193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b
Author: kbr <kbr@chromium.org>
Date: Wed Jun 29 00:33:55 2016

Remove Windows/AMD from chromium.gpu and win_chromium_rel_ng.

The Chromium project has grown to the point where a significant number
of machines are required in order to keep up with the load on the main
commit queue. It's infeasible to expand all of the GPU types
simultaneously so this one is being moved to the chromium.gpu.fyi
waterfall. It will still be run for ANGLE CLs and on the optional GPU
tryservers.

BUG= 624156 

Review-Url: https://codereview.chromium.org/2108803003

[modify] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/masters/master.chromium.gpu/slaves.cfg
[modify] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py
[modify] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Win_Builder.json
[delete] https://crrev.com/a8fedd0fdc9df67ee5666ffe8908f424c4a11a1e/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Win7_Release__ATI_.json

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/6c012708c8c34512ec4d31ad45e78313ef824ed5

commit 6c012708c8c34512ec4d31ad45e78313ef824ed5
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 29 00:57:23 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b Remove Windows/AMD from chromium.gpu and win_chromium_rel_ng. (kbr@chromium.org)

R=kbr@chromium.org
BUG= 624156 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2104263002

[modify] https://crrev.com/6c012708c8c34512ec4d31ad45e78313ef824ed5/infra/config/recipes.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/05046a173613fc9c2fbdb29144fc6567d7169045

commit 05046a173613fc9c2fbdb29144fc6567d7169045
Author: kbr <kbr@chromium.org>
Date: Wed Jun 29 02:10:48 2016

Run default set of Win AMD GPU tests on win_optional_gpu_tests_rel.

WebGL 1.0 test coverage on Win AMD is lost for some key commits (GPU
changes, WebGL conformance rolls) with the most recent change. Add it
back.

BUG= 624156 

Review-Url: https://codereview.chromium.org/2103843005

[modify] https://crrev.com/05046a173613fc9c2fbdb29144fc6567d7169045/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/0b00b01926a1897a41593a99ad40966f552ac2ec

commit 0b00b01926a1897a41593a99ad40966f552ac2ec
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 29 02:28:58 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/05046a173613fc9c2fbdb29144fc6567d7169045 Run default set of Win AMD GPU tests on win_optional_gpu_tests_rel. (kbr@chromium.org)

R=kbr@chromium.org
BUG= 624156 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2105223002

[modify] https://crrev.com/0b00b01926a1897a41593a99ad40966f552ac2ec/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 29 2016

Comment 8 by kbr@chromium.org, Jun 29 2016

Blockedon: 624377
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/b82da02712732f8ffdd5639566c1c297cf1a1d55

commit b82da02712732f8ffdd5639566c1c297cf1a1d55
Author: kbr <kbr@chromium.org>
Date: Wed Jun 29 18:19:22 2016

Fix win_optional_gpu_tests_rel.

Having it mirror both the Win ATI and Optional Win ATI testers was
causing duplicate step entries, leading to failure of the recipe.

BUG= 624156 
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2106133004

[modify] https://crrev.com/b82da02712732f8ffdd5639566c1c297cf1a1d55/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96561c6f52c31ae54f2519212d459bccb79ecb50

commit 96561c6f52c31ae54f2519212d459bccb79ecb50
Author: mcwilliams <mcwilliams@chromium.org>
Date: Wed Jun 29 18:17:42 2016

NTP, change the card elevation from setElevation to a 9 patch file

Because it's a nine-patch, this ensures the shadow will be visible when drawing into a bitmap (which disables hardware rendering). It also allows drawing the shadow pre-L.

Videos: https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizRW9CRHdPd0FLUVE

BUG=616706

Review-Url: https://codereview.chromium.org/2088793004
Cr-Commit-Position: refs/heads/master@{#402871}

[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-hdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-mdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-xhdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-xxhdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-xxxhdpi/ntp_card.9.png
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/layout/new_tab_page_status_card.xml
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[delete] https://crrev.com/2f793dcc427d8345550acb237aa54c144e68ccce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardItemDecoration.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java_sources.gni

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96561c6f52c31ae54f2519212d459bccb79ecb50

commit 96561c6f52c31ae54f2519212d459bccb79ecb50
Author: mcwilliams <mcwilliams@chromium.org>
Date: Wed Jun 29 18:17:42 2016

NTP, change the card elevation from setElevation to a 9 patch file

Because it's a nine-patch, this ensures the shadow will be visible when drawing into a bitmap (which disables hardware rendering). It also allows drawing the shadow pre-L.

Videos: https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizRW9CRHdPd0FLUVE

BUG=616706

Review-Url: https://codereview.chromium.org/2088793004
Cr-Commit-Position: refs/heads/master@{#402871}

[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-hdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-mdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-xhdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-xxhdpi/ntp_card.9.png
[add] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/drawable-xxxhdpi/ntp_card.9.png
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/layout/new_tab_page_status_card.xml
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[delete] https://crrev.com/2f793dcc427d8345550acb237aa54c144e68ccce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardItemDecoration.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java
[modify] https://crrev.com/96561c6f52c31ae54f2519212d459bccb79ecb50/chrome/android/java_sources.gni

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 29 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/d6855c1e3749932343e1d0d2da822d3c8f8194cf

commit d6855c1e3749932343e1d0d2da822d3c8f8194cf
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 29 18:37:09 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b82da02712732f8ffdd5639566c1c297cf1a1d55 Fix win_optional_gpu_tests_rel. (kbr@chromium.org)

R=kbr@chromium.org,dpranke@chromium.org
BUG= 624156 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2105403002

[modify] https://crrev.com/d6855c1e3749932343e1d0d2da822d3c8f8194cf/infra/config/recipes.cfg

Comment 14 by kbr@chromium.org, Jun 29 2016

Blockedon: -491419
Blocking: 491419
Status: Fixed (was: Assigned)
The work has been done here and these trybots are now only optional.

Comment 15 by kbr@chromium.org, Jun 29 2016

Blocking: 624511

Sign in to add a comment