New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624140 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 624136



Sign in to add a comment

WTF::Optional doesn't work with WTF::Vector/WTF::HashMap

Project Member Reported by yzshen@chromium.org, Jun 28 2016

Issue description

The reason is that they don't support emplacement new.

This issue is blocking the work of using WTF::Optional<WTF::Vector> and WTF::Optional<WTF::HashMap> as the blink-side C++ types for "array?" and "map?".

 

Comment 1 by yzshen@chromium.org, Jun 28 2016

Components: Blink>Internals>WTF
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51fad7a9410e6ac54bd38b4cd02bce9ee81230ee

commit 51fad7a9410e6ac54bd38b4cd02bce9ee81230ee
Author: yzshen <yzshen@chromium.org>
Date: Thu Jul 07 17:38:55 2016

Add a standard placement new operator to WTF_USE_ALLOCATOR.

So that types using WTF_USE_ALLOCATOR can work with WTF::Optional.

BUG= 624140 

Review-Url: https://codereview.chromium.org/2128583004
Cr-Commit-Position: refs/heads/master@{#404167}

[modify] https://crrev.com/51fad7a9410e6ac54bd38b4cd02bce9ee81230ee/third_party/WebKit/Source/wtf/VectorTest.cpp
[modify] https://crrev.com/51fad7a9410e6ac54bd38b4cd02bce9ee81230ee/third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h

Comment 3 by yzshen@chromium.org, Jul 11 2016

Owner: yzshen@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment