New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624132 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 624274
Owner: ----
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 605318



Sign in to add a comment

Windows Chrome is larger when built with GN than GYP

Project Member Reported by h...@chromium.org, Jun 28 2016

Issue description

With GYP:
GYP_DEFINES=branding=Chrome buildtype=Official chromium_win_pch=0 component=static_library fastbuild=1 target_arch=ia32

06/28/2016  02:22 PM        37,359,104 chrome.dll
06/28/2016  02:23 PM        47,532,032 chrome_child.dll
06/28/2016  02:23 PM           953,344 chrome.exe
06/28/2016  02:24 PM        46,540,800 mini_installer.exe

With GN:
  target_cpu="x86"
  is_chrome_branded = true
  is_debug = false
  is_official_build = true
06/28/2016  11:47 AM        38,328,320 chrome.dll
06/28/2016  11:46 AM        47,118,336 chrome_child.dll
06/28/2016  11:48 AM         1,246,208 chrome.exe
06/28/2016  11:49 AM        46,889,472 mini_installer.exe


It seems chrome.dll, chrome.exe and mini_installer.exe are larger with GN, whereas chrome_child.dll is slightly smaller for some reason. Are we getting the /Os vs. /O2 flags right?

(I was using Chromium #402497)


This makes me nervous since I'm tracking size differences between Clang and MSVC, and if some bots are switching between gyp and gn, the changes the numbers.

I assume we want the build results to be equivalent between gn and gyp?
 

Comment 1 by thakis@chromium.org, Jun 28 2016

Cc: dpranke@chromium.org brucedaw...@chromium.org brettw@chromium.org
gn being slightly larger is expected due to its source_set thing, but a while megabyte for chrome.dll is unexpected I'd say.

Comment 2 by thakis@chromium.org, Jun 28 2016

Labels: Proj-GN-Migration
Mergedinto: 624274
Status: Duplicate (was: Untriaged)
This is a dup of 624274 (or, at least, we're working on that one).

Sign in to add a comment