New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624129 link

Starred by 1 user
Status: Verified
Owner:
█ oka@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
█ rookrishna@chromium.org
weifangsun@chromium.org
█ oka@chromium.org
█ tienchang@chromium.org
dhadd...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files app QuickView: Unable to dismiss preview window with Esc key

Project Member Reported by sdantul...@chromium.org, Jun 28 2016 
Google Chrome	53.0.2773.0 (Official Build) dev (64-bit)
Revision	ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610}
Platform	8513.0.0 (Official Build) dev-channel link

What steps will reproduce the problem?
1. Open Files app.
2. Select image file
3. Press spacebar to see preview window
4. Click 'Esc' key

What is the expected output?
Should dismiss the preview window.

What do you see instead?
Unable to dismiss preview window with Esc key

Comment 1 by oka@chromium.org, Jun 29 2016

Owner: oka@chromium.org
Status: Started (was: Untriaged)

Comment 2 by oka@chromium.org, Jun 30 2016 

This will be fixed with https://codereview.chromium.org/2109563002.

Comment 3 by abod...@chromium.org, Jun 30 2016 

reproduced on ChromeOS:8526.0.0/53.0.2784.1
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d88718883e2f0525a702482bbe14f148ce62b025

commit d88718883e2f0525a702482bbe14f148ce62b025
Author: oka <oka@chromium.org>
Date: Fri Jul 01 02:00:47 2016

Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/view?usp=sharing

BUG= 613465 , 624129 
TEST=manually.

Review-Url: https://codereview.chromium.org/2109563002
Cr-Commit-Position: refs/heads/master@{#403389}

[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/tools/gritsettings/resource_ids
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.js
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_quick_view.css
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_audio.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_folder.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_generic.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_image.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_video.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_audio.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_folder.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_generic.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_image.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_video.png
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager_resources.grd

Comment 5 by oka@chromium.org, Jul 1 2016

Status: Fixed (was: Started)

Comment 6 by abod...@chromium.org, Aug 12 2016

Status: Verified (was: Fixed)
Chrome OS 8697.0.0, 54.0.2826.0
►

Sign in to add a comment