New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624113 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
User never visited
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 640330



Sign in to add a comment

Make sure get-help app can tell if it's on an android enabled device

Project Member Reported by abodenha@chromium.org, Jun 28 2016

Issue description

Sorry for filing this a little late in the game, but we need to address this in 53.

We want to extend the get-help app to contain content related to Android apps, but that content should only appear on Chrome OS devices that have Android apps available.

We need to figure out a good way to control whether that content is available.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 1 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by r...@chromium.org, Aug 4 2016

Cc: morsed@google.com
+David, who works on the help app.

Comment 3 by r...@chromium.org, Aug 24 2016

Blockedon: 640330

Comment 4 by st...@chromium.org, Aug 24 2016

Owner: st...@chromium.org

Comment 5 by st...@chromium.org, Aug 25 2016

Status: Fixed (was: Assigned)
The GetHelp app should now see a new field in the launch_data param for OnLaunched called playStoreStatus which will either have the values, available or enabled. If the value does not exist, then that device does not support the play store.

Comment 6 by morsed@google.com, Sep 13 2016

Cc: weifangsun@chromium.org
added weifangsun@ to CC list
Cc: -morsed@google.com -ksangani@google.com st...@chromium.org
Labels: -M-54 M-55
Owner: morsed@chromium.org
Status: Assigned (was: Fixed)
Updating the status per conversation with @morsed - I think we may be waiting on additional backend work for this to be fully implemented.
Components: Platform>Apps>GetHelp

Comment 9 by morsed@google.com, Oct 4 2016

This has been handled in a different way than mentioned in comment #5 here.

See https://bugs.chromium.org/p/chromium/issues/detail?id=644432 

A new ARC++ property was added for chromeosInfoPrivate (note: this will be renamed to chromeosInfo and will be available to all kiosk apps with crbug.com/629931).

- playStoreStatus ("not available", "available", "enabled")

Comment 10 by morsed@google.com, Oct 7 2016

Labels: -M-55 M-56 Merge-Request-55

Comment 11 by dimu@chromium.org, Oct 8 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/d3b49e3d7654c8668c107beb706ab8d1513bbe1d

commit d3b49e3d7654c8668c107beb706ab8d1513bbe1d
Author: David Morse <morsed@google.com>
Date: Fri Oct 07 01:59:31 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 11 2016

Labels: merge-merged-release-R55-8872.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/372c9b84a55e224c3ed30239f5bcc3eef1ba2a3c

commit 372c9b84a55e224c3ed30239f5bcc3eef1ba2a3c
Author: David Morse <morsed@google.com>
Date: Fri Oct 07 01:59:31 2016

Labels: -M-56 M-55
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 12 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by morsed@google.com, Oct 13 2016

Labels: -Hotlist-Merge-Approved -Merge-Approved-55

Comment 17 Deleted

Comment 18 by morsed@google.com, Nov 15 2016

Status: Fixed (was: Started)
landed in M56 with 8886.0/55.0.2882.0

merged into M55 with 8872.7/55.0.2883.9
Status: Verified (was: Fixed)
Cc: r...@chromium.org
Cc: -st...@chromium.org

Sign in to add a comment