New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624109 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 745999

Blocking:
issue 640685



Sign in to add a comment

Files app Quick View: Black preview for .TIF images

Project Member Reported by abod...@chromium.org, Jun 28 2016

Issue description

Google Chrome	53.0.2773.0 (Official Build) dev (64-bit)
Revision	ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610}
Platform	8513.0.0 (Official Build) dev-channel

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
Select .TIF image and press spacebar.

Expected Result:

Actual Result:
Preview is blank.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
100%
What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.
Attached screenshot

 
Screenshot 2016-06-28 at 1.49.59 PM.png
1.6 MB View Download

Comment 1 by oka@chromium.org, Jun 30 2016

Owner: oka@chromium.org
Status: Fixed (was: Untriaged)
It should be fixed on HEAD.
Screenshot: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhaWxaQTJnQ2RiWlk/view?usp=sharing
repro'd on ChromeOS:8526.0.0/53.0.2784.1
Status: Assigned (was: Fixed)
Empty image is shown in quick view. Attached screenshot.

Instead, 'This file type is not supported' dialog should be shown.
Screenshot 2016-08-12 at 5.04.33 PM.png
536 KB View Download

Comment 4 by oka@chromium.org, Aug 15 2016

Status: Started (was: Assigned)

Comment 5 by oka@chromium.org, Aug 15 2016

Could you share the file you used for the test?

Comment 6 by oka@chromium.org, Aug 15 2016

Summary: Files app Quick View: Black preview for .TIF images (was: Files app QuickView: Black preview for .TIF images)
Attached
XING_T24.TIF
115 KB Download

Comment 8 by fukino@chromium.org, Sep 30 2016

Labels: M-56

Comment 9 by oka@chromium.org, Oct 28 2016

Status: Assigned (was: Started)
Blocking: 640685
Labels: -m-56 M-57
Blockedon: 745999
Cc: oka@chromium.org
Owner: klemenko@google.com
klemenko@, could you test that the issue reproduces with the attached file in Comment #7?
oka@, please tell us if the .til file should not be supported in QuickView.
Status: Started (was: Assigned)

Comment 15 by oka@chromium.org, Jul 24 2017

Sorry for late reply.
Since Chrome and Gallery don't support tif. I guess quick view also doesn't have to support tif. We should show "not supported" image for tif.
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac526f9e321e1d7bbae54a9d944456fa0b37b9a1

commit ac526f9e321e1d7bbae54a9d944456fa0b37b9a1
Author: Klemen Kozjek <klemenko@google.com>
Date: Wed Jul 26 09:42:25 2017

Display a message for unsupported image format if it does not have an implementation(task) to open it.

As a result, when an image in TIF/F format is opened in quick view it will display 'not supported' instead of a blank image.


Bug:  624109 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie1bb6cc24236027c9828152086d046634f7535b8
Reviewed-on: https://chromium-review.googlesource.com/583877
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#489583}
[modify] https://crrev.com/ac526f9e321e1d7bbae54a9d944456fa0b37b9a1/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Status: Fixed (was: Started)
Cc: -rookrishna@chromium.org mkarkada@chromium.org
Verified on Chrome OS 9765.13.0, 61.0.3163.20 (dev build).
Status: Verified (was: Fixed)
Verified on M62 (Chrome OS  9807.0.0, 62.0.3176.0 dev build) as well.

Sign in to add a comment