New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624106 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Use white temporary tab spinner when theme is dark, not just in Incognito mode (Mac)

Project Member Reported by shrike@chromium.org, Jun 28 2016

Issue description

 Issue 618778  fixed a problem where the regular non-MD spinner wait state was not visible in Incognito mode tabs. That fix should apply to all dark themes, not just Incognito mode.

 

Comment 1 by shrike@chromium.org, Jun 28 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f61958a3d0125bc8848164c5dc6157e2c08738ae

commit f61958a3d0125bc8848164c5dc6157e2c08738ae
Author: shrike <shrike@chromium.org>
Date: Wed Jun 29 01:53:05 2016

[Mac][Material Design] Use white tab spinner for dark themes.

In Material Design we display a white tab spinner for Incognito mode
tabs, but we need to also do so for dark themes.

R=avi@chromium.org
BUG= 624106 

Review-Url: https://codereview.chromium.org/2103073003
Cr-Commit-Position: refs/heads/master@{#402643}

[modify] https://crrev.com/f61958a3d0125bc8848164c5dc6157e2c08738ae/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Comment 3 by shrike@chromium.org, Jun 29 2016

Labels: Merge-Request-52

Comment 4 by dimu@google.com, Jun 30 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 30 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47aa3d93f873a0cb700a7452690d3f273dc19791

commit 47aa3d93f873a0cb700a7452690d3f273dc19791
Author: Jayson Adams <shrike@chromium.org>
Date: Thu Jun 30 01:03:12 2016

[Mac][Material Design] Use white tab spinner for dark themes.

In Material Design we display a white tab spinner for Incognito mode
tabs, but we need to also do so for dark themes.

R=avi@chromium.org
BUG= 624106 

Review-Url: https://codereview.chromium.org/2103073003
Cr-Commit-Position: refs/heads/master@{#402643}
(cherry picked from commit f61958a3d0125bc8848164c5dc6157e2c08738ae)

Review URL: https://codereview.chromium.org/2104233004 .

Cr-Commit-Position: refs/branch-heads/2743@{#540}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/47aa3d93f873a0cb700a7452690d3f273dc19791/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Comment 6 by shrike@chromium.org, Jun 30 2016

Status: Fixed (was: Started)
Cc: ashej...@chromium.org
Labels: TE-Verified-M52 TE-Verified-52.0..2743.75.
Tested the above issue on Mac 10.11.5 with chrome version '52.0..2743.75' & white tab spinner is displayed for dark them for material design. Hence marking the same as TE-Verified-52.0..2743.75.

Thank you!

Sign in to add a comment