Other extensions on the action bar show confirmation dialogs for removal, so for consistency's sake I think it's better if we kept the ellipsis and also showed a dialog. What do you think?

I could go either way.  Since the user is not actually removing any functionality when they remove the icon (versus uninstalling an extension), the use case is different.  But the inconsistency could be irritating to finicky users.

If we have the opportunity to rename the action (which I don't know that we
do), it should probably say "Remove Icon" (w/o ellipses).  If we don't,
then we should probably just be consistent with other extensions and show a
confirmation dialog.

Another idea: what if we make it an option that says "Always show icon" and can be checked/unchecked? This way when the user sees the ephemeral icon and wants to make it persist, they can check the option. If the icon is shown as the result of the user installing the extension, it should come with the option checked.

When the user unchecks the option, we can show a confirmation dialog that says something like:
 Hide Cast?
 You can show the icon again by installing the Cast extension.
 Cancel | Hide

+1 to Takumi's suggestion in #5 for how to persist the icon even when no extension was installed.

It does raise the question of how to handle if/when the extension is removed. Should that also remove the icon at that point, or should it persist since the option is checked?

We should really address #5 as part of  crbug.com/594577 .

As it stands today the only way the user could have the icon in the toolbar
- and thus have access to the right-click context menu - and thus choose to
'Always show icon' ... is if you already have the extension installed so
that we're already showing the icon.  ;-)

*Once* we have support for an ephemeral icon (as per  Issue 594577 ), *then*
it would make sense for us to add an option to make the icon persistent
(without requiring an extension install).  At that point we should also add
a policy to allow admins (e.g., for EDU) to force the icon to display
always.

But for the purposes of this bug, and while we still have an extension, I
think we should just rename the action as described at the beginning.

If the icon is shown from an extension install or previous action we show "Remove icon" per this bug.

If the icon is shown ephemerally while casting we show "Keep icon in toolbar" or some such.  This can be done as part of 594577

Re: #6 There is no way to uninstall the cast extension once MR is enabled.  It stops being loaded into the extensions system

takumif@, I believe your patch fixed this, so you can mark this Fixed.

https://codereview.chromium.org/2112623002

For future reference, you can add a BUG=XXX line to the patch description, and the issue will be updated when the patch lands.

mfoltz@, I had entered BUG= so I'm not sure why this hasn't been updated; maybe the bot is just late. Either way, manually updating.

Could anyone let us know is there any manual test steps to verify this issue from Chrome TE end? And please let us know what's the expected behavior of this issue.

brajkumar@, this issue simply changes text in the Media Router action context menu.

To verify this issue/fix:
- Have Media Router enabled in chrome://flags
- Have the Media Router action icon showing in the toolbar (install the Google Cast extension from the Web Store if not shown)
- Right click on the action icon
- The fifth item in the context menu should say "Remove icon" instead of "Remove from Chrome..."