New issue
Advanced search Search tips

Issue 624095 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug



Sign in to add a comment

Remove SPDY/3.1.

Project Member Reported by b...@chromium.org, Jun 28 2016

Issue description

Currently SPDY/3.1 is disabled by default but can be enabled via field trials.  SPDY/3.1 should be entirely removed, and dead methods, members, enums, comments, histograms etc. cleaned up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2df4b5245b9c4350001c238dffe46d46fcf0c245

commit 2df4b5245b9c4350001c238dffe46d46fcf0c245
Author: bnc <bnc@chromium.org>
Date: Fri Jul 08 18:17:43 2016

Disable SPDY/3.1.

* Remove SPDY field trial.
* Add HTTP2 field trial to provide a kill switch for HTTP/2 just in case.
* Remove enable_spdy31 flag.

BUG= 624095 ,  521597 

Review-Url: https://codereview.chromium.org/2115213002
Cr-Commit-Position: refs/heads/master@{#404443}

[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/chrome/browser/io_thread.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/chrome/browser/io_thread.h
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/components/network_session_configurator/network_session_configurator.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/components/network_session_configurator/network_session_configurator.h
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/components/network_session_configurator/network_session_configurator_unittest.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/ios/chrome/browser/ios_chrome_io_thread.mm
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/ios/crnet/crnet_environment.mm
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/jingle/glue/proxy_resolving_client_socket.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/http/http_network_session.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/http/http_network_session.h
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/log/net_log_util.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/spdy/spdy_test_util_common.h
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245/net/url_request/url_request_context_builder.h

Comment 2 by b...@chromium.org, Jul 11 2016

Blocking: -587469
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b9e22b06bb8a4279229820e770b5a6bd19388c

commit a9b9e22b06bb8a4279229820e770b5a6bd19388c
Author: bnc <bnc@chromium.org>
Date: Mon Jul 11 20:10:40 2016

Remove SPDY/3.1 tests.

* Remove SPDY/3.1 test cases.
* s/TEST_P/TEST_F/ where there are no remaining test parameters.
* Remove SPDY/3.1-only tests.
* Remove protocol version arguments, members, accessors from test helper
  functions and classes.
* Hardwire kProtoHTTP2 or HTTP2 in SpdyFramer, BufferedSpdyFramer constructors,
  other function calls.  (Some of these arguments will be removed in follow-up
  CLs.)
* Remove SSLClientSocketTest.NPNNoOverlap and NPNServerPreference, because they
  are moot if HTTP/2 is the only non-trivial NPN protocol supported.  Note that
  NPN has been disabled anyway.
* Remove SPDY/3.1-specific MaybAddVersionHeader(), GetVersionKey().
* Remove unused HttpProxyClientSocketPoolTestParams default constructor.
* Inline UpdateSpdySessionDependencies.

BUG= 624095 

Review-Url: https://codereview.chromium.org/2140673002
Cr-Commit-Position: refs/heads/master@{#404718}

[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/http/http_stream_factory_impl_request_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/buffered_spdy_framer_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_http_stream_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_proxy_client_socket_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_session_pool_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_stream_unittest.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c/net/spdy/spdy_test_util_common.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca843ba1471a6ca4eaf9f6869153389de683d6e

commit bca843ba1471a6ca4eaf9f6869153389de683d6e
Author: bnc <bnc@chromium.org>
Date: Thu Jul 14 13:05:48 2016

Remove many-many SpdyMajorVersion and NextProto arguments and members.

Now that SPDY/3.1 is disabled, rip it out from more areas of the code:

Remove SpdyMajorVersion and NextProto members, accessors, and function arguments
from BufferedSpdyFramer, SpdySession, SpdySessionPool, HeaderCoalescer,
SpdyStream classes, from spdy_http_utils.{h,cc}, and from flipserver.

Also deprecate Net.SpdySettingsCwndSent and Net.SpdyVersion3 histograms.

BUG= 624095 

Review-Url: https://codereview.chromium.org/2141993002
Cr-Commit-Position: refs/heads/master@{#405481}

[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/http/bidirectional_stream.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/http/http_network_session.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/http/http_network_session.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/quic/bidirectional_stream_quic_impl.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/quic/quic_http_stream.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/bidirectional_stream_spdy_impl.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/buffered_spdy_framer.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/buffered_spdy_framer.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/buffered_spdy_framer_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/header_coalescer.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/header_coalescer.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_http_stream.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_http_stream_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_http_utils.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_http_utils.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_http_utils_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_proxy_client_socket.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_proxy_client_socket_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_session.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_session.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_session_pool.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_session_pool_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_stream.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_stream.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_stream_unittest.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/flip_server/sm_connection.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/flip_server/sm_connection.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/flip_server/spdy_interface.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/flip_server/spdy_interface.h
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/flip_server/spdy_interface_test.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/quic/quic_in_memory_cache.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/quic/quic_simple_client.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/net/tools/quic/quic_simple_client_bin.cc
[modify] https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/927c496c6cea4ed5f1c96ed14abdea9961749928

commit 927c496c6cea4ed5f1c96ed14abdea9961749928
Author: bnc <bnc@chromium.org>
Date: Thu Jul 21 14:45:59 2016

Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle tests.

Also mark DisableSpdy policy deprecated.

This should mean no functional change, because DisableSpdy only acts
on the SPDY/3.1 protocol (since https://crrev.com/2150773003),
which is disabled entirely anyway (since https://crrev.com/2115213002).

BUG= 624095 

Review-Url: https://codereview.chromium.org/2140733002
Cr-Commit-Position: refs/heads/master@{#406848}

[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/chrome/browser/net/net_pref_observer.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/chrome/browser/net/net_pref_observer.h
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/chrome/common/pref_names.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/components/policy/resources/policy_templates.json
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/net/http/http_network_session.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/net/http/http_stream_factory.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/net/http/http_stream_factory.h
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928/net/test/net_test_suite.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a376ed55e15fc38bb8d22fe164fb275882a37554

commit a376ed55e15fc38bb8d22fe164fb275882a37554
Author: bnc <bnc@chromium.org>
Date: Sat Jul 23 00:20:32 2016

Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG= 624095 , 526773,  334602 

Review-Url: https://codereview.chromium.org/2172543003
Cr-Commit-Position: refs/heads/master@{#407313}

[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[delete] https://crrev.com/9c770cf31089d791900b601bbc94ce49b4673b4f/chrome/browser/net/net_pref_observer.cc
[delete] https://crrev.com/9c770cf31089d791900b601bbc94ce49b4673b4f/chrome/browser/net/net_pref_observer.h
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/chrome_browser.gypi
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/common/pref_names.cc
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/chrome/common/pref_names.h
[modify] https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554/components/policy/resources/policy_templates.json

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4233140d9fb980c68a14bb014128a6df5c02e2d9

commit 4233140d9fb980c68a14bb014128a6df5c02e2d9
Author: bnc <bnc@chromium.org>
Date: Mon Jul 25 13:36:15 2016

s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG= 624095 

Review-Url: https://codereview.chromium.org/2167253002
Cr-Commit-Position: refs/heads/master@{#407465}

[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/chrome/test/data/webui/net_internals/log_view_painter.js
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/log/net_log_event_type_list.h
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_http_stream.h
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_http_stream_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_proxy_client_socket.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_proxy_client_socket.h
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_proxy_client_socket_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_session.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_session.h
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_stream.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_stream.h
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_stream_unittest.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_test_util_common.h
[modify] https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9/net/spdy/spdy_write_queue_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab

commit 7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab
Author: bnc <bnc@chromium.org>
Date: Wed Aug 03 14:08:37 2016

Deprecate SPDY/3.1 and draft HTTP/2 enum values.

* Remove NextProto::kProtoSPDY31 enum value.
* Remove unused enum NextProto values: kProtoSPDY31, kProtoMinimumVersion,
  kProtoMaximumVersion, kProtoSPDYMinimumVersion, kProtoSPDYMaximumVersion.
* Remove (and inline) now trivial NextProtoIsSPDY(); remove next_proto.cc.
* Deprecate enum HttpResponseInfo values: CONNECTION_INFO_SPDY3,
  CONNECTION_INFO_HTTP2_14, CONNECTION_INFO_HTTP2_15.

SPDY/3.1, HTTP/2 draft-14, and HTTP/2 draft-15 protocols are not supported any
more.  This CL cleans up deprecated enum values: removes them where it is
possible, marks them DEPRECATED where it is not.

BUG= 624095 

Review-Url: https://codereview.chromium.org/2195273003
Cr-Commit-Position: refs/heads/master@{#409506}

[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/components/domain_reliability/util.cc
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/http/http_response_info.cc
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/http/http_response_info.h
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/http/http_server_properties.cc
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/net.gypi
[delete] https://crrev.com/ebca0939c5c1adefb92df85d1a085d1bc6999f5b/net/socket/next_proto.cc
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/socket/next_proto.h
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/socket/ssl_client_socket.cc
[modify] https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab/net/socket/ssl_client_socket_pool.cc

Comment 10 by b...@chromium.org, Sep 30 2016

third_party/zlib/mixed-source.patch is specifically for mitigating SPDY/3.1 header compression security vulnerability, see  issue 139744 .  After SPDY/3.1 is removed, that file can be removed (and possibly other changes from https://crrev.com/10837057 can be reverted?).
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9921fa1d778e80abd7239e39457c4456122a7bdd

commit 9921fa1d778e80abd7239e39457c4456122a7bdd
Author: bnc <bnc@chromium.org>
Date: Thu Dec 01 18:51:15 2016

Remove enum SpdyMajorVersion.

This CL lands server changes 140349928 by alyssar and 140661724 by bnc.

BUG= 624095 , 488484

Review-Url: https://codereview.chromium.org/2544813002
Cr-Commit-Position: refs/heads/master@{#435661}

[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/quic/core/quic_headers_stream.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/quic/core/quic_headers_stream_test.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/quic/core/spdy_utils.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/quic/test_tools/quic_test_packet_maker.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/buffered_spdy_framer.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/buffered_spdy_framer_unittest.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_deframer_visitor_test.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_frame_builder.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_frame_builder.h
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_frame_builder_test.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_framer.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_framer.h
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_framer_decoder_adapter.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_framer_test.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_headers_block_parser.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_headers_block_parser.h
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_headers_block_parser_test.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_protocol.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_protocol.h
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_session.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_stream_unittest.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_test_utils.cc
[modify] https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd/net/spdy/spdy_test_utils.h

Comment 12 by b...@chromium.org, Feb 22 2017

This removal is now complete, therefore I am closing this issue.

For future reference, CL https://crrev.com/2579063002 was also part of this effort.

Comment 13 by b...@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50

commit b1993f1ffdb16fc9825e8a8d02c553ea3082bf50
Author: Bence Béky <bnc@chromium.org>
Date: Wed Jul 12 19:29:26 2017

Remove unused |clear_persisted| arg.

Remove unused |clear_persisted| arg and SpdySettingsControlFlags enum
that are left over from SPDY (pre-HTTP/2).  This is a follow-up to
https://crrev.com/2496683002.

BUG= 624095 

Change-Id: I418c33a8c4ac9269512b8a4fca2c220073310d89
Reviewed-on: https://chromium-review.googlesource.com/568461
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486056}
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/quic/core/quic_headers_stream_test.cc
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/chromium/buffered_spdy_framer.cc
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/chromium/buffered_spdy_framer.h
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/http2_frame_decoder_adapter.cc
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/mock_spdy_framer_visitor.h
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/spdy_deframer_visitor.cc
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/spdy_framer.cc
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/spdy_framer.h
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/spdy_framer_decoder_adapter.cc
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/spdy_framer_decoder_adapter.h
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/spdy_framer_test.cc
[modify] https://crrev.com/b1993f1ffdb16fc9825e8a8d02c553ea3082bf50/net/spdy/core/spdy_protocol.h

Sign in to add a comment