New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624080 link

Starred by 2 users
Status: Assigned
Owner:
zmo@chromium.org
Cc:
█ kbr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebGL2 Conformance test errors

Project Member Reported by erikc...@chromium.org, Jun 28 2016 
https://codereview.chromium.org/2103913002/#ps20001

I tried to added a DCHECK to RestoreCurrentTextureBindings()
"""
 DCHECK(!state->texture_units.empty());
"""

This 1-line change causes WebGL2 conformance test failures.

Comment 1 by zmo@chromium.org, Jun 28 2016 

Actually I think you were just caught up in a bad v8 roll.  The third CL just happened to be the bad roll got reverted.  There is probably nothing to fix here.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23ece3f89bebad856993492fd4d1e911d183dea4

commit 23ece3f89bebad856993492fd4d1e911d183dea4
Author: erikchen <erikchen@chromium.org>
Date: Wed Jul 06 17:42:18 2016

Add a useful DCHECK to RestoreCurrentTextureBindings.

BUG=624080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2104943003
Cr-Commit-Position: refs/heads/master@{#403929}

[modify] https://crrev.com/23ece3f89bebad856993492fd4d1e911d183dea4/gpu/command_buffer/service/gles2_cmd_decoder.cc
►

Sign in to add a comment