The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f

commit b2602438cbcdd99e6eb34d8be9c54d65e8bf087f
Author: bnc <bnc@chromium.org>
Date: Wed Jun 29 02:39:45 2016

Change a number of SPDY unittests from http to https.

* Remove enable_alternative_service_for_insecure_origins;
* change alternative service unittests from http to https;
* change kDefaultUrl from http to https;
* s/kDefaultURL/kDefaultUrl/ (to match the one in QuicStreamFactoryTest);
* adapt a number of tests, explicitly use old URL in others;
* remove SpdyTestUtil::default_url();
* remove moot SpdyAlternativeServiceThroughProxy;
* remove SpdyNetworkTransactionTest::GetDefaultUrl() and port_;
* add SpdyNetworkTransactionTest members to make tests more concise.

Besides an improvement in code health, this CL will make it easier to write
unittests for https://crbug.com/615413.

BUG= 621621 ,  624073 

Review-Url: https://codereview.chromium.org/2109803002
Cr-Commit-Position: refs/heads/master@{#402686}

[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_session.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_session.h
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_transaction.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_stream_factory_impl_request_unittest.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/quic/quic_network_transaction_unittest.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_http_stream_unittest.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_stream_unittest.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_test_util_common.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4d611d543851a8fac9c42ffe6947a39e5d7ef73

commit a4d611d543851a8fac9c42ffe6947a39e5d7ef73
Author: bnc <bnc@chromium.org>
Date: Thu Sep 22 19:55:37 2016

Remove test-only |verify_domain_authentication|.

* Remove SpdySession::verify_domain_authentication.
* Remove SpdySessionPeer::verify_domain_authentication.
* Remove SpdySessionPoolPeer::DisableDomainAuthenticationVerification.
* Add cert to HttpNetworkTransactionTest.UseIPConnectionPooling* unittests,
  change hostname in test to match cert.

BUG= 624073 

Review-Url: https://codereview.chromium.org/2360343002
Cr-Commit-Position: refs/heads/master@{#420435}

[modify] https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73/net/spdy/spdy_session.cc
[modify] https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73/net/spdy/spdy_session.h
[modify] https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73/net/spdy/spdy_session_pool.h
[modify] https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73/net/spdy/spdy_test_util_common.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc

commit 032658babe56835d8a5fafc8f1d45f4c6d4cd9dc
Author: bnc <bnc@chromium.org>
Date: Mon Sep 26 18:17:15 2016

Make (almost) all SpdySessions secure in unittests.

BUG= 624073 

Review-Url: https://codereview.chromium.org/2365263004
Cr-Commit-Position: refs/heads/master@{#420936}

[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/spdy/spdy_http_stream_unittest.cc
[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/spdy/spdy_proxy_client_socket_unittest.cc
[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/spdy/spdy_session_pool_unittest.cc
[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/spdy/spdy_stream_unittest.cc
[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc/net/spdy/spdy_test_util_common.h

The premise of this issue is incorrect: insecure SpdySessions are supported: they are used for retrieving http scheme resources over SPDY proxies.

The CLs landed so far are useful, because direct SPDY is always secure, so it was a worthwhile effort to change unittest to reflect this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c06a30cf92373b0cb4b721a4a8dac6d72635b93

commit 2c06a30cf92373b0cb4b721a4a8dac6d72635b93
Author: bnc <bnc@chromium.org>
Date: Tue Sep 27 17:31:03 2016

Remove |certificate_error_code| and SpdySession::TryAccessStream().

SpdySessionPool::CreateAvailableSessionFromSocket() is always called with a
hardcoded OK value for its |certificate_error_code| argument, so this can be
removed.  SpdySession::InitializeWithSocket() is only called from
SpdySessionPool::CreateAvailableSessionFromSocket() with |certificate_error_code
== OK|, so that argument can be removed as well.  Then
SpdySession::certificate_error_code_ member is always OK, so that can be removed
as well.  This makes SpdySession::TryAccessStream() always return OK, so that
can also be removed.

Metrics show that
SpdyProtocolErrorDetails::PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION
is almost never (1e-11 of all counts) logged in Net.SpdySessionErrorDetails2.

BUG= 624073 

Review-Url: https://codereview.chromium.org/2371943003
Cr-Commit-Position: refs/heads/master@{#421250}

[modify] https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93/net/spdy/spdy_session.cc
[modify] https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93/net/spdy/spdy_session.h
[modify] https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93/net/spdy/spdy_session_pool.h
[modify] https://crrev.com/2c06a30cf92373b0cb4b721a4a8dac6d72635b93/net/spdy/spdy_test_util_common.cc