New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624068 link

Starred by 1 user
Status: Fixed
Owner:
█ ymalik@chromium.org
(currently inactive on Chromium)
Closed: Jun 2016
Cc:
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 595826



Sign in to add a comment

Add onscroll and onresize methods to the visual viewport API

Project Member Reported by ymalik@chromium.org, Jun 28 2016 
A webpage must be able to do 
window.visualViewport.onscroll = handler
window.visualViewport.onresize = handler

Comment 1 by ymalik@chromium.org, Jun 29 2016

Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e7d4683e5b49649342a1dfe731c25108bac1ca1

commit 4e7d4683e5b49649342a1dfe731c25108bac1ca1
Author: ymalik <ymalik@chromium.org>
Date: Wed Jun 29 19:05:43 2016

Add onscroll/onresize EventHandler support to ViewportAPI

BUG= 624068 

Review-Url: https://codereview.chromium.org/2108953002
Cr-Commit-Position: refs/heads/master@{#402887}

[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
[modify] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/third_party/WebKit/Source/core/frame/VisualViewport.idl

Comment 3 by ymalik@chromium.org, Jun 29 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16924630c6f3f1b2470aef5401f90e42b190356e

commit 16924630c6f3f1b2470aef5401f90e42b190356e
Author: ymalik <ymalik@chromium.org>
Date: Tue Jul 26 23:08:07 2016

Remove onscroll/onresize EventHandler supper from ViewportAPI

This was added in https://codereview.chromium.org/2108953002 but on* handlers
exist for legacy reasons, so removing.

BUG= 624068 

Review-Url: https://codereview.chromium.org/2186713002
Cr-Commit-Position: refs/heads/master@{#407955}

[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
[modify] https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e/third_party/WebKit/Source/core/frame/VisualViewport.idl
►

Sign in to add a comment