New issue
Advanced search Search tips

Issue 624065 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Investigate removal of DeleteSoon from RenderWidgetHostViewChildFrame and Guest

Project Member Reported by kenrb@chromium.org, Jun 28 2016

Issue description

The original RenderWidgetHostViewGuest::Destroy() called DeleteSoon to defer its own deletion. This is apparently due to some kind of re-entrancy issue, of which nobody can remember the details. RenderWidgetHostViewChildFrame::Destroy() does the same because it was patterned off of RenderWidgetHostViewGuest.

The deferred deletion causes awkward conditions sometimes when RenderWidgetHostViews have had Destroy called, but still exist, and somebody tries to interact with them. It would be easier if they could delete themselves outright to eliminate the 'destroyed but not deleted' state.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f40832ec30f1e19f28ca4dfab9e24d608fcefa28

commit f40832ec30f1e19f28ca4dfab9e24d608fcefa28
Author: lfg <lfg@chromium.org>
Date: Sat Feb 25 00:58:05 2017

Delete RenderWidgetHostViewChildFrame on Destroy().

This CL changes RenderWidgetHostViewChildFrame to be synchronously deleted when Destroy() is called. This makes sure that the destructor is called on tests, and prevents complicated lifetime management for objects that depend on RenderWidgetHostViewChildFrame.

BUG= 624065 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2710023008
Cr-Commit-Position: refs/heads/master@{#453032}

[modify] https://crrev.com/f40832ec30f1e19f28ca4dfab9e24d608fcefa28/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/f40832ec30f1e19f28ca4dfab9e24d608fcefa28/content/browser/frame_host/render_widget_host_view_guest.cc

Comment 2 by kenrb@chromium.org, Mar 28 2017

Owner: lfg@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment