New issue
Advanced search Search tips

Issue 624054 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jul 2016
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[TTS] Bar doesn't show after a fling down to close the panel

Project Member Reported by donnd@chromium.org, Jun 28 2016 
When the user closes the overlay panel by flinging it down something seems to get confused and the Bar no longer shows when the user taps or longpresses to select text for a Contextual Search.  The system stays confused for a while -- subsequent searches don't show the bar, even after switching tabs.  However making the Toolbar show/hide using a browser action like sleep or the tab switcher fixes it.

Matt, I'm guessing your recent change to refactor the overlay panel height calculations might have caused this.  Do you want to take a quick look?

Comment 1 Deleted

Comment 2 by mdjones@chromium.org, Jun 28 2016

Owner: mdjones@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/296d30ec054653d9affc1d68981b6c118683272d

commit 296d30ec054653d9affc1d68981b6c118683272d
Author: mdjones <mdjones@chromium.org>
Date: Wed Jun 29 17:10:20 2016

Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG= 624054 , 623017

Review-Url: https://codereview.chromium.org/2109823002
Cr-Commit-Position: refs/heads/master@{#402843}

[modify] https://crrev.com/296d30ec054653d9affc1d68981b6c118683272d/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 1 2016

Labels: merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48b93ee3a71a592e8ecba2ff6408bc8daeba7be

commit c48b93ee3a71a592e8ecba2ff6408bc8daeba7be
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Jul 01 15:40:04 2016

Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG= 624054 , 623017

Review-Url: https://codereview.chromium.org/2109823002
Cr-Commit-Position: refs/heads/master@{#402843}
(cherry picked from commit 296d30ec054653d9affc1d68981b6c118683272d)

Review URL: https://codereview.chromium.org/2111213003 .

Cr-Commit-Position: refs/branch-heads/2743@{#565}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/c48b93ee3a71a592e8ecba2ff6408bc8daeba7be/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Comment 5 by mdjones@chromium.org, Jul 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment