New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

pull the deletion of pages with url out of informSavePageDone

Project Member Reported by romax@chromium.org, Jun 28 2016

Issue description

pull the deletion of pages with url out of informSavePageDone
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f258f19fe9c59c5f6445d069637c95a09efc926c

commit f258f19fe9c59c5f6445d069637c95a09efc926c
Author: romax <romax@chromium.org>
Date: Fri Jul 08 01:15:45 2016

[Offline Pages] Refactoring deletion of pages with same urls.

Simple refactoring to make InformSavePageDone() doesn't do extra work.

BUG= 624043 

Review-Url: https://codereview.chromium.org/2112183002
Cr-Commit-Position: refs/heads/master@{#404298}

[modify] https://crrev.com/f258f19fe9c59c5f6445d069637c95a09efc926c/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/f258f19fe9c59c5f6445d069637c95a09efc926c/components/offline_pages/offline_page_model_impl.h

Comment 2 by romax@chromium.org, Jul 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment