Either import wpt/mediasource-liveseekable.html or create similar test coverage in Blink |
|||
Issue descriptionhttps://codereview.chromium.org/2105593002/ adds MediaSource.prototype.{set,clear}liveSeekableRange() behavior, but does not include tests, in anticipation of importing upstream w3c w-p-t/media-source/mediasource-liveseekable.html. This bug tracks making sure either that import happens, or there is otherwise coverage added in Blink for this new feature.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbebef53441200e0ce94dcd41668df78c93f568e commit dbebef53441200e0ce94dcd41668df78c93f568e Author: wolenetz <wolenetz@chromium.org> Date: Wed Jul 13 22:37:11 2016 MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange() Anticipating a spec change to remove this 'updating' check to fix spec issue https://github.com/w3c/media-source/issues/118, these methods no longer throw exception if any of the SourceBuffers in sourceBuffers are currently updating. [1] https://github.com/w3c/web-platform-tests/pull/3296 BUG= 627880 , 624037 R=chcunningham@chromium.org TEST=Expected update [1, above] to upstream wpt/media-source/mediasource-liveseekable.html fails before and passes after this change (with --enable-experimental-web-platform-features in both cases, of course). Review-Url: https://codereview.chromium.org/2144063002 Cr-Commit-Position: refs/heads/master@{#405309} [modify] https://crrev.com/dbebef53441200e0ce94dcd41668df78c93f568e/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
,
Jul 13 2016
w.r.t. c#1, https://github.com/w3c/web-platform-tests/pull/3296 is out for review to update the wpt test related to the fix landed in bug 627880 (and the associated spec change that is still in review).
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b7e73684803bcf4adb6b47af752d1b81ad200e2 commit 9b7e73684803bcf4adb6b47af752d1b81ad200e2 Author: Matt Wolenetz <wolenetz@chromium.org> Date: Wed Jul 20 00:03:06 2016 MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange() Anticipating a spec change to remove this 'updating' check to fix spec issue https://github.com/w3c/media-source/issues/118, these methods no longer throw exception if any of the SourceBuffers in sourceBuffers are currently updating. [1] https://github.com/w3c/web-platform-tests/pull/3296 BUG= 627880 , 624037 TBR=chcunningham@chromium.org TEST=Expected update [1, above] to upstream wpt/media-source/mediasource-liveseekable.html fails before and passes after this change (with --enable-experimental-web-platform-features in both cases, of course). Review-Url: https://codereview.chromium.org/2144063002 Cr-Commit-Position: refs/heads/master@{#405309} (cherry picked from commit dbebef53441200e0ce94dcd41668df78c93f568e) Review URL: https://codereview.chromium.org/2166683002 . Cr-Commit-Position: refs/branch-heads/2785@{#230} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/9b7e73684803bcf4adb6b47af752d1b81ad200e2/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0452bcf300c90ef3707f530cdec61c5397627cc9 commit 0452bcf300c90ef3707f530cdec61c5397627cc9 Author: foolip <foolip@chromium.org> Date: Fri Apr 21 17:05:55 2017 Import MSE tests from web-platform-tests Some of the upstream tests originate from http/tests/media/media-source/ and in the long run these should be consolidated. Importing is the first step, and may reveal interop problems in need of attention. BUG= 624037 , 633669 ,651765 R=chcunningham@chromium.org,wolenetz@chromium.org Review-Url: https://codereview.chromium.org/2830203003 Cr-Commit-Position: refs/heads/master@{#466370} [modify] https://crrev.com/0452bcf300c90ef3707f530cdec61c5397627cc9/third_party/WebKit/LayoutTests/W3CImportExpectations
,
Sep 29 2017
The imported version of this test (external/wpt/media-source/mediasource-liveseekable.html) is the one true version of the test for Blink. There needs to be no additional downstream version. Thanks, foolip@ for getting the import done in #5 (in M60). Further, Chrome starting shipping with the test feature always-on in M62 (launch bug 623698 ). Closing this. |
|||
►
Sign in to add a comment |
|||
Comment 1 by wolenetz@chromium.org
, Jul 13 2016