New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624023 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 624651
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

compositorworker/basic-plumbing-worker-to-main.html and basic-plumbing-main-to-worker.html are failing flaky timeouts

Project Member Reported by penghuang@chromium.org, Jun 28 2016

Issue description

Cc: petewil@chromium.org
Owner: danakj@chromium.org
Seems this issue is related to CL https://codereview.chromium.org/2075343003

Dana, could you please take a look?

(Chromium Sheriff here) Looking at the Mac bot, this seems to have been failing from at least build 6204 to build 6240, succeeding intermittently.  That means we likely have a flaky test that needs to be disabled.
Correction, the build numbers are from the windows 7 bot, not the mac bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29?numbuilds=200
Correction, the build numbers are from the windows 7 bot, not the mac bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29?numbuilds=200
Looking at the flakiness dashboard, it seems that there is a lot of timeouts happening.  Maybe the right fix is to mark the test as being SLOW in the test expectations file.

Comment 6 by danakj@chromium.org, Jun 28 2016

Cc: vollick@chromium.org ajuma@chromium.org penghuang@chromium.org
Owner: ----
I think Pass Timeout seems right. It's not clear if SLOW will make it finish. 
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bc08758e4ad17d0097e139ab4ef3df6f7e1b043

commit 1bc08758e4ad17d0097e139ab4ef3df6f7e1b043
Author: penghuang <penghuang@chromium.org>
Date: Tue Jun 28 21:58:31 2016

Disable flaky virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.html

BUG= 624023 

Review-Url: https://codereview.chromium.org/2106813003
Cr-Commit-Position: refs/heads/master@{#402559}

[modify] https://crrev.com/1bc08758e4ad17d0097e139ab4ef3df6f7e1b043/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by danakj@chromium.org, Jun 28 2016

Components: Blink>Compositing
Summary: compositorworker/basic-plumbing-worker-to-main.html is failing flaky timeouts (was: Build failure on compositorworker related tests)
Summary: compositorworker/basic-plumbing-worker-to-main.html and basic-plumbing-main-to-worker.html are failing flaky timeouts (was: compositorworker/basic-plumbing-worker-to-main.html is failing flaky timeouts)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6253
Components: -Blink>Compositing Internals>Compositing
Owner: flackr@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f962b2f9db38d56c81ebc08517cfbf652bab8ba4

commit f962b2f9db38d56c81ebc08517cfbf652bab8ba4
Author: penghuang <penghuang@chromium.org>
Date: Wed Jun 29 21:05:43 2016

Disable flaky virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.html

BUG= 624023 
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2112513002
Cr-Commit-Position: refs/heads/master@{#402931}

[modify] https://crrev.com/f962b2f9db38d56c81ebc08517cfbf652bab8ba4/third_party/WebKit/LayoutTests/TestExpectations

Cc: flackr@chromium.org
Owner: majidvp@chromium.org
Majid, I suspect this is a dupe of  issue 624651 .
Seems like it and the flakiness is addressed since I landed fix for  issue 624651  (crrev.com/403819).
Screenshot from 2016-07-06 11:49:54.png
16.5 KB View Download
Mergedinto: 624651
Status: Duplicate (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9726333e1a9c3c2d13ab661f0687b0409cb70930

commit 9726333e1a9c3c2d13ab661f0687b0409cb70930
Author: majidvp <majidvp@chromium.org>
Date: Wed Jul 06 20:58:57 2016

Update TestExpectations for previously flaky compositorworker layout tests

Tests are no longer timing out as a resulf of fix in http://crrev.com/403819

BUG= 624712 ,  624023 
R=flackr

Review-Url: https://codereview.chromium.org/2123093004
Cr-Commit-Position: refs/heads/master@{#403949}

[modify] https://crrev.com/9726333e1a9c3c2d13ab661f0687b0409cb70930/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment