"Mac10.11" is used in TestExpectations, but "10.11" is used in the builder list. |
||
Issue descriptionAs noted by wkorman: "10.11" is used for WebKit Mac 10.11 in https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py, but "Mac10.11" appears in layout_tests/models/test_expectations.py as well as the actual TestExpectations file.
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f6e8febf7b1b5fbcf0b25fc20e29f8d3baa1529 commit 6f6e8febf7b1b5fbcf0b25fc20e29f8d3baa1529 Author: qyearsley <qyearsley@chromium.org> Date: Tue Jul 19 00:35:29 2016 Revert of Remove Mac10.11 specifiers from TestExpectations as an experiment. (patchset #1 id:1 of https://codereview.chromium.org/2106903002/ ) Reason for revert: After this was committed, the webkit_tests on the waterfall went red (example build https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/7222) This means that these lines in TestExpectations are *not* without effect. Original issue's description: > Remove Mac10.11 specifiers from TestExpectations as an experiment. > > Due to bug 624020 , it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed. > > Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted. > > BUG= 624020 > > Committed: https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a > Cr-Commit-Position: refs/heads/master@{#406134} TBR=wkorman@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 624020 Review-Url: https://codereview.chromium.org/2160113003 Cr-Commit-Position: refs/heads/master@{#406160} [modify] https://crrev.com/6f6e8febf7b1b5fbcf0b25fc20e29f8d3baa1529/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 13 2016
Original issue fixed by https://codereview.chromium.org/2102873002. When changing this, we also discussed changing other specifier names to make them more consistent (e.g. Precise -> LinuxPrecise, Retina -> MacRetina), but this is a separate issue. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 18 2016