New issue
Advanced search Search tips

Issue 624012 link

Starred by 2 users
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Aug 2016
Cc:
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Change Input Event Path so multiple events aren't in flight at once

Project Member Reported by dtapu...@chromium.org, Jun 28 2016 
Events are queued in the browser, and between the compositor thread and the main thread.

It is possible that there can be multiple events in the message event loop queue that aren't coalesced.

We should pull the data out the the message event loop and store only an indication that there is work to be done.

Doing so will allow us to coalesce events in the side queue so we deliver the most recent event information.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb9341c9f5539577a82aae52e19bd789148001bc

commit cb9341c9f5539577a82aae52e19bd789148001bc
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Jul 26 16:27:53 2016

Generalize the main thread event queue into a common event queue.

Teach the WebInputEventQueue about ScopedWebInputEvents so we can
use a single queue instead of one per event class.

This reduces code duplication and allows for another patch to then take
advantage of this for all events.

BUG= 624012 , 599152 

Review-Url: https://codereview.chromium.org/2170913002
Cr-Commit-Position: refs/heads/master@{#407826}

[modify] https://crrev.com/cb9341c9f5539577a82aae52e19bd789148001bc/content/common/input/event_with_latency_info.cc
[modify] https://crrev.com/cb9341c9f5539577a82aae52e19bd789148001bc/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/cb9341c9f5539577a82aae52e19bd789148001bc/content/common/input/web_input_event_queue.h
[modify] https://crrev.com/cb9341c9f5539577a82aae52e19bd789148001bc/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/cb9341c9f5539577a82aae52e19bd789148001bc/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/cb9341c9f5539577a82aae52e19bd789148001bc/content/renderer/input/main_thread_event_queue_unittest.cc
[modify] https://crrev.com/cb9341c9f5539577a82aae52e19bd789148001bc/third_party/WebKit/public/platform/WebInputEvent.h

Comment 2 by dtapu...@chromium.org, Aug 12 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment